From: Mark Brown <broonie@kernel.org> To: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com> Cc: "Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Timur Tabi <timur@tabi.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "guangyu.chen@freescale.com" <guangyu.chen@freescale.com>, Markus Pargmann <mpa@pengutronix.de>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 01/15] ASoC: fsl-ssi: Use regmap Date: Wed, 5 Mar 2014 14:21:14 +0800 [thread overview] Message-ID: <20140305062114.GT13126@sirena.org.uk> (raw) In-Reply-To: <6dc5873dcdf54e13aecbf7c6be03f8bf@BY2PR03MB505.namprd03.prod.outlook.com> [-- Attachment #1.1: Type: text/plain, Size: 756 bytes --] On Thu, Feb 27, 2014 at 02:08:45AM +0000, Li.Xiubo@freescale.com wrote: > > +static const struct regmap_config fsl_ssi_regconfig = { > > + .max_register = CCSR_SSI_SACCDIS, > > + .reg_bits = 32, > > + .val_bits = 32, > > + .reg_stride = 4, > > +#ifdef PPC > > + .val_format_endian = REGMAP_ENDIAN_BIG, > > +#endif > Is this really needed for your PPC platforms? > If so, I think this should depend on one specified platform, which > the CPU is in LE mode while the SSI is in BE mode... Since the entire series depends on this patch due to the fact that it makes changes throughout the driver we need this resolving to make any progress here. Perhaps it makes sense to restructure the series so that this is at the end rather than start of the series? [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/15] ASoC: fsl-ssi: Use regmap Date: Wed, 5 Mar 2014 14:21:14 +0800 [thread overview] Message-ID: <20140305062114.GT13126@sirena.org.uk> (raw) In-Reply-To: <6dc5873dcdf54e13aecbf7c6be03f8bf@BY2PR03MB505.namprd03.prod.outlook.com> On Thu, Feb 27, 2014 at 02:08:45AM +0000, Li.Xiubo at freescale.com wrote: > > +static const struct regmap_config fsl_ssi_regconfig = { > > + .max_register = CCSR_SSI_SACCDIS, > > + .reg_bits = 32, > > + .val_bits = 32, > > + .reg_stride = 4, > > +#ifdef PPC > > + .val_format_endian = REGMAP_ENDIAN_BIG, > > +#endif > Is this really needed for your PPC platforms? > If so, I think this should depend on one specified platform, which > the CPU is in LE mode while the SSI is in BE mode... Since the entire series depends on this patch due to the fact that it makes changes throughout the driver we need this resolving to make any progress here. Perhaps it makes sense to restructure the series so that this is at the end rather than start of the series? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140305/34f299ed/attachment.sig>
next prev parent reply other threads:[~2014-03-05 6:21 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-26 16:02 [PATCH 00/15] ASoC: fsl-ssi: Driver cleanup Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 01/15] ASoC: fsl-ssi: Use regmap Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-27 2:08 ` Li.Xiubo 2014-02-27 2:08 ` Li.Xiubo at freescale.com 2014-02-27 15:23 ` Markus Pargmann 2014-02-27 15:23 ` Markus Pargmann 2014-02-27 16:06 ` Timur Tabi 2014-02-27 16:06 ` Timur Tabi 2014-03-05 6:21 ` Mark Brown [this message] 2014-03-05 6:21 ` Mark Brown 2014-03-05 7:04 ` Li.Xiubo 2014-03-05 7:04 ` Li.Xiubo at freescale.com 2014-03-05 7:07 ` Li.Xiubo 2014-03-05 7:07 ` Li.Xiubo at freescale.com 2014-02-26 16:02 ` [PATCH 02/15] ASoC: fsl-ssi: Remove fsl_ssi_setup Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 03/15] ASoC: fsl-ssi: Move debugging to seperate file Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 04/15] ASoC: fsl-ssi: Use dev_name for DAI driver struct Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 05/15] ASoC: fsl-ssi: Move imx-specific probe to seperate function Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 06/15] ASoC: fsl-ssi: Remove useless DMA code Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 07/15] ASoC: fsl-ssi: baud clock error handling Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 08/15] ASoC: fsl-ssi: Cleanup probe function Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 09/15] ASoC: fsl-ssi: Remove unnecessary variables from ssi_private Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 10/15] ASoC: fsl-ssi: reorder and document fsl_ssi_private Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 11/15] ASoC: fsl-ssi: Fix register values when disabling Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 12/15] ASoC: fsl-ssi: Only enable baudclk when used Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 13/15] ASoC: fsl-ssi: Set default dai-fmts Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 14/15] ASoC: fsl-ssi: Transmit enable synchronization Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann 2014-02-26 16:02 ` [PATCH 15/15] ASoC: fsl-ssi: Update binding documentation Markus Pargmann 2014-02-26 16:02 ` Markus Pargmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140305062114.GT13126@sirena.org.uk \ --to=broonie@kernel.org \ --cc=Fabio.Estevam@freescale.com \ --cc=Li.Xiubo@freescale.com \ --cc=alsa-devel@alsa-project.org \ --cc=guangyu.chen@freescale.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=mpa@pengutronix.de \ --cc=timur@tabi.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.