* [PATCH] ata: fix kconfig selection warning
@ 2014-04-15 17:50 Peter Foley
2014-04-15 18:17 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Peter Foley @ 2014-04-15 17:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Foley, tj, linux-ide
When building with COMPILE_TEST, AHCI_XGENE is enabled even though
PHY_XGENE (which it selects) requires OF to be enabled.
Fix this by adding a dependency on OF to AHCI_XGENE.
warning: (AHCI_XGENE) selects PHY_XGENE which has unmet direct
dependencies (HAS_IOMEM && OF && (ARM64 || COMPILE_TEST))
Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 20e03a7..071f399 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -134,7 +134,7 @@ config AHCI_SUNXI
config AHCI_XGENE
tristate "APM X-Gene 6.0Gbps AHCI SATA host controller support"
- depends on ARM64 || COMPILE_TEST
+ depends on OF && (ARM64 || COMPILE_TEST)
select PHY_XGENE
help
This option enables support for APM X-Gene SoC SATA host controller.
--
1.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: fix kconfig selection warning
2014-04-15 17:50 [PATCH] ata: fix kconfig selection warning Peter Foley
@ 2014-04-15 18:17 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-04-15 18:17 UTC (permalink / raw)
To: Peter Foley; +Cc: linux-kernel, linux-ide
Hello,
On Tue, Apr 15, 2014 at 01:50:55PM -0400, Peter Foley wrote:
> When building with COMPILE_TEST, AHCI_XGENE is enabled even though
> PHY_XGENE (which it selects) requires OF to be enabled.
> Fix this by adding a dependency on OF to AHCI_XGENE.
>
> warning: (AHCI_XGENE) selects PHY_XGENE which has unmet direct
> dependencies (HAS_IOMEM && OF && (ARM64 || COMPILE_TEST))
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
Already fixed in libata/for-3.15-fixes. Will push out in several
days.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-15 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-15 17:50 [PATCH] ata: fix kconfig selection warning Peter Foley
2014-04-15 18:17 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.