All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <shijie8@gmail.com>
To: Graham Moore <ggrahammoore@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>, Marek Vasut <marex@denx.de>,
	Graham Moore <grmoore@altera.com>,
	Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Jingoo Han <jg1.han@samsung.com>,
	linux-kernel@vger.kernel.org,
	Yves Vandervennet <rocket.yvanderv@gmail.com>,
	linux-mtd@lists.infradead.org,
	Insop Song <insop.song@gainspeed.com>,
	Alan Tull <atull@altera.com>,
	Sourav Poddar <sourav.poddar@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Dinh Nguyen <dinguyen@altera.com>
Subject: Re: [PATCH V3] Add support for flag status register on Micron chips.
Date: Mon, 28 Apr 2014 23:37:32 +0800	[thread overview]
Message-ID: <20140428153728.GA2020@localhost.localdomain> (raw)
In-Reply-To: <CA+iBjpS9gstvippLHzm_Tpgxx19VxnRzWEwi_tJV5d7+snnfWg@mail.gmail.com>

On Mon, Apr 28, 2014 at 09:22:58AM -0500, Graham Moore wrote:
> On Mon, Apr 28, 2014 at 2:06 AM, Huang Shijie <b32955@freescale.com> wrote:
> > On Mon, Apr 28, 2014 at 07:06:17AM +0200, Marek Vasut wrote:
> >>
> >> Two things competing over the same pointer looks misdesigned to me. I will need
> >> to dig into this one more time ...
> > Please refer to the code for NAND chip, the nand_get_flash_type() :
> >
> > -----------------------------------------------------------
> >         /* Do not replace user supplied command function! */
> >         if (mtd->writesize > 512 && chip->cmdfunc == nand_command)
> >                 chip->cmdfunc = nand_command_lp;
> > -----------------------------------------------------------
> >
> > It uses the same logic:
> >         " Do not replace user supplied command function!"
> >
> > thanks
> > Huang Shijie
> 
> I would like to set the @wait_till_ready in m25p80.c, because the
> USE_FSR flag is only for Micron chips.  But the m25p80 driver doesn't
m25p80.c is not the right place. 

we should put these code in the spi-nor.c

thanks
Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <shijie8@gmail.com>
To: Graham Moore <ggrahammoore@gmail.com>
Cc: Marek Vasut <marex@denx.de>,
	Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
	Yves Vandervennet <rocket.yvanderv@gmail.com>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Jingoo Han <jg1.han@samsung.com>,
	linux-kernel@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
	linux-mtd@lists.infradead.org, Graham Moore <grmoore@altera.com>,
	Alan Tull <atull@altera.com>,
	Sourav Poddar <sourav.poddar@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Insop Song <insop.song@gainspeed.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Dinh Nguyen <dinguyen@altera.com>
Subject: Re: [PATCH V3] Add support for flag status register on Micron chips.
Date: Mon, 28 Apr 2014 23:37:32 +0800	[thread overview]
Message-ID: <20140428153728.GA2020@localhost.localdomain> (raw)
In-Reply-To: <CA+iBjpS9gstvippLHzm_Tpgxx19VxnRzWEwi_tJV5d7+snnfWg@mail.gmail.com>

On Mon, Apr 28, 2014 at 09:22:58AM -0500, Graham Moore wrote:
> On Mon, Apr 28, 2014 at 2:06 AM, Huang Shijie <b32955@freescale.com> wrote:
> > On Mon, Apr 28, 2014 at 07:06:17AM +0200, Marek Vasut wrote:
> >>
> >> Two things competing over the same pointer looks misdesigned to me. I will need
> >> to dig into this one more time ...
> > Please refer to the code for NAND chip, the nand_get_flash_type() :
> >
> > -----------------------------------------------------------
> >         /* Do not replace user supplied command function! */
> >         if (mtd->writesize > 512 && chip->cmdfunc == nand_command)
> >                 chip->cmdfunc = nand_command_lp;
> > -----------------------------------------------------------
> >
> > It uses the same logic:
> >         " Do not replace user supplied command function!"
> >
> > thanks
> > Huang Shijie
> 
> I would like to set the @wait_till_ready in m25p80.c, because the
> USE_FSR flag is only for Micron chips.  But the m25p80 driver doesn't
m25p80.c is not the right place. 

we should put these code in the spi-nor.c

thanks
Huang Shijie

  reply	other threads:[~2014-04-28 15:37 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 14:03 [PATCH V3] Add support for flag status register on Micron chips Graham Moore
2014-04-22 14:03 ` Graham Moore
2014-04-22 14:03 ` Graham Moore
2014-04-22 14:03   ` Graham Moore
2014-04-22 16:55   ` Marek Vasut
2014-04-22 16:55     ` Marek Vasut
2014-04-22 18:48     ` Graham Moore
2014-04-22 18:48       ` Graham Moore
2014-04-22 18:58       ` Marek Vasut
2014-04-22 18:58         ` Marek Vasut
2014-04-25  4:47       ` Huang Shijie
2014-04-25  4:47         ` Huang Shijie
2014-04-25 15:50         ` Marek Vasut
2014-04-25 15:50           ` Marek Vasut
2014-04-22 18:45   ` Gerhard Sittig
2014-04-22 18:45     ` Gerhard Sittig
2014-04-22 19:17     ` Graham Moore
2014-04-22 19:17       ` Graham Moore
2014-04-25  1:34   ` Huang Shijie
2014-04-25  1:34     ` Huang Shijie
2014-04-25  2:42     ` Marek Vasut
2014-04-25  2:42       ` Marek Vasut
2014-04-25  1:52       ` Huang Shijie
2014-04-25  1:52         ` Huang Shijie
2014-04-25 22:12         ` Marek Vasut
2014-04-25 22:12           ` Marek Vasut
2014-04-26  3:10           ` Huang Shijie
2014-04-26  3:10             ` Huang Shijie
2014-04-28  5:06             ` Marek Vasut
2014-04-28  5:06               ` Marek Vasut
2014-04-28  7:06               ` Huang Shijie
2014-04-28  7:06                 ` Huang Shijie
2014-04-28 14:22                 ` Graham Moore
2014-04-28 14:22                   ` Graham Moore
2014-04-28 15:37                   ` Huang Shijie [this message]
2014-04-28 15:37                     ` Huang Shijie
2014-07-12  2:07               ` Brian Norris
2014-07-12  2:07                 ` Brian Norris
2014-04-25  1:54       ` Huang Shijie
2014-04-25  1:54         ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140428153728.GA2020@localhost.localdomain \
    --to=shijie8@gmail.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=atull@altera.com \
    --cc=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dinguyen@altera.com \
    --cc=dwmw2@infradead.org \
    --cc=geert+renesas@linux-m68k.org \
    --cc=ggrahammoore@gmail.com \
    --cc=grmoore@altera.com \
    --cc=insop.song@gainspeed.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=rocket.yvanderv@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sourav.poddar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.