From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> To: Tiejun Chen <tiejun.chen@intel.com> Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, mst@redhat.com, allen.m.kay@intel.com, stefano.stabellini@eu.citrix.com, weidong.han@intel.com, Kelly.Zytaruk@amd.com, jean.guyader@eu.citrix.com, qemu-devel@nongnu.org, yang.z.zhang@intel.com, anthony@codemonkey.ws, anthony.perard@citrix.com Subject: Re: [Qemu-devel] [Xen-devel] [v2][PATCH 5/8] xen, gfx passthrough: create intel isa bridge Date: Fri, 16 May 2014 10:11:33 -0400 [thread overview] Message-ID: <20140516141133.GD3154@phenom.dumpdata.com> (raw) In-Reply-To: <1400237624-8505-6-git-send-email-tiejun.chen@intel.com> On Fri, May 16, 2014 at 06:53:41PM +0800, Tiejun Chen wrote: > ISA bridge is needed since Intel gfx drive will probe it instead > of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that > only need to expose ISA bridge to let driver know the real hardware underneath. > > The original patch is from Allen Kay [allen.m.kay@intel.com] > > Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com> > Signed-off-by: Tiejun Chen <tiejun.chen@intel.com> > Cc: Allen Kay <allen.m.kay@intel.com> > --- > v2: > > * Nothing is changed. > > hw/xen/xen_pt_graphics.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c > index e1f0724..6b86293 100644 > --- a/hw/xen/xen_pt_graphics.c > +++ b/hw/xen/xen_pt_graphics.c > @@ -175,3 +175,74 @@ out: > g_free(bios); > return rc; > } > + > +static uint32_t isa_bridge_read_config(PCIDevice *d, uint32_t addr, int len) > +{ > + uint32_t v; > + > + v = pci_default_read_config(d, addr, len); > + > + return v; return pci_default_read_config... > +} > + > +static void isa_bridge_write_config(PCIDevice *d, uint32_t addr, uint32_t v, > + int len) > +{ > + pci_default_write_config(d, addr, v, len); > + > + return; > +} > + > +static void isa_bridge_class_init(ObjectClass *klass, void *data) > +{ > + PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > + > + k->config_read = isa_bridge_read_config; > + k->config_write = isa_bridge_write_config; > + > + return; > +}; > + > +typedef struct { > + PCIDevice dev; > +} ISABridgeState; > + > +static TypeInfo isa_bridge_info = { > + .name = "inte-pch-isa-bridge", s/inte/intel/ > + .parent = TYPE_PCI_DEVICE, > + .instance_size = sizeof(ISABridgeState), > + .class_init = isa_bridge_class_init, > +}; > + > +static void xen_pt_graphics_register_types(void) > +{ > + type_register_static(&isa_bridge_info); > +} > + > +type_init(xen_pt_graphics_register_types) > + > +static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) > +{ > + struct PCIDevice *dev; > + > + char rid; > + > + dev = pci_create(bus, PCI_DEVFN(0x1f, 0), "inte-pch-isa-bridge"); s/inte/intel/? > + if (!dev) { > + XEN_PT_LOG(dev, "fail to create PCH ISA bridge.\n"); failed > + return -1; Could we return a better error code to help troubleshoot why we failed? > + } > + > + qdev_init_nofail(&dev->qdev); > + > + pci_config_set_vendor_id(dev->config, hdev->vendor_id); > + pci_config_set_device_id(dev->config, hdev->device_id); > + > + xen_host_pci_get_block(hdev, PCI_REVISION_ID, (uint8_t *)&rid, 1); > + > + pci_config_set_revision(dev->config, rid); > + pci_config_set_class(dev->config, PCI_CLASS_BRIDGE_ISA); > + > + XEN_PT_LOG(dev, "Intel PCH ISA bridge is created.\n"); s/is// > + return 0; > +} > -- > 1.9.1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> To: Tiejun Chen <tiejun.chen@intel.com> Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, mst@redhat.com, allen.m.kay@intel.com, stefano.stabellini@eu.citrix.com, weidong.han@intel.com, Kelly.Zytaruk@amd.com, jean.guyader@eu.citrix.com, qemu-devel@nongnu.org, yang.z.zhang@intel.com, anthony@codemonkey.ws, anthony.perard@citrix.com Subject: Re: [Xen-devel] [v2][PATCH 5/8] xen, gfx passthrough: create intel isa bridge Date: Fri, 16 May 2014 10:11:33 -0400 [thread overview] Message-ID: <20140516141133.GD3154@phenom.dumpdata.com> (raw) In-Reply-To: <1400237624-8505-6-git-send-email-tiejun.chen@intel.com> On Fri, May 16, 2014 at 06:53:41PM +0800, Tiejun Chen wrote: > ISA bridge is needed since Intel gfx drive will probe it instead > of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that > only need to expose ISA bridge to let driver know the real hardware underneath. > > The original patch is from Allen Kay [allen.m.kay@intel.com] > > Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com> > Signed-off-by: Tiejun Chen <tiejun.chen@intel.com> > Cc: Allen Kay <allen.m.kay@intel.com> > --- > v2: > > * Nothing is changed. > > hw/xen/xen_pt_graphics.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c > index e1f0724..6b86293 100644 > --- a/hw/xen/xen_pt_graphics.c > +++ b/hw/xen/xen_pt_graphics.c > @@ -175,3 +175,74 @@ out: > g_free(bios); > return rc; > } > + > +static uint32_t isa_bridge_read_config(PCIDevice *d, uint32_t addr, int len) > +{ > + uint32_t v; > + > + v = pci_default_read_config(d, addr, len); > + > + return v; return pci_default_read_config... > +} > + > +static void isa_bridge_write_config(PCIDevice *d, uint32_t addr, uint32_t v, > + int len) > +{ > + pci_default_write_config(d, addr, v, len); > + > + return; > +} > + > +static void isa_bridge_class_init(ObjectClass *klass, void *data) > +{ > + PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > + > + k->config_read = isa_bridge_read_config; > + k->config_write = isa_bridge_write_config; > + > + return; > +}; > + > +typedef struct { > + PCIDevice dev; > +} ISABridgeState; > + > +static TypeInfo isa_bridge_info = { > + .name = "inte-pch-isa-bridge", s/inte/intel/ > + .parent = TYPE_PCI_DEVICE, > + .instance_size = sizeof(ISABridgeState), > + .class_init = isa_bridge_class_init, > +}; > + > +static void xen_pt_graphics_register_types(void) > +{ > + type_register_static(&isa_bridge_info); > +} > + > +type_init(xen_pt_graphics_register_types) > + > +static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) > +{ > + struct PCIDevice *dev; > + > + char rid; > + > + dev = pci_create(bus, PCI_DEVFN(0x1f, 0), "inte-pch-isa-bridge"); s/inte/intel/? > + if (!dev) { > + XEN_PT_LOG(dev, "fail to create PCH ISA bridge.\n"); failed > + return -1; Could we return a better error code to help troubleshoot why we failed? > + } > + > + qdev_init_nofail(&dev->qdev); > + > + pci_config_set_vendor_id(dev->config, hdev->vendor_id); > + pci_config_set_device_id(dev->config, hdev->device_id); > + > + xen_host_pci_get_block(hdev, PCI_REVISION_ID, (uint8_t *)&rid, 1); > + > + pci_config_set_revision(dev->config, rid); > + pci_config_set_class(dev->config, PCI_CLASS_BRIDGE_ISA); > + > + XEN_PT_LOG(dev, "Intel PCH ISA bridge is created.\n"); s/is// > + return 0; > +} > -- > 1.9.1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-05-16 14:12 UTC|newest] Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-16 10:53 [Qemu-devel] [v2][PATCH 0/8] xen: add Intel IGD passthrough support Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-16 10:53 ` [Qemu-devel] [v2][PATCH 1/8] pci: use bitmap to manage registe/runregister pci device Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-16 10:53 ` [Qemu-devel] [v2][PATCH 2/8] pci: provide a way to reserve some specific devfn Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-16 14:07 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk 2014-05-16 14:07 ` Konrad Rzeszutek Wilk 2014-05-19 9:43 ` [Qemu-devel] " Chen, Tiejun 2014-05-19 9:43 ` Chen, Tiejun 2014-05-16 10:53 ` [Qemu-devel] [v2][PATCH 3/8] xen, gfx passthrough: basic graphics passthrough support Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-16 14:06 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk 2014-05-16 14:06 ` Konrad Rzeszutek Wilk 2014-05-19 9:42 ` [Qemu-devel] " Chen, Tiejun 2014-05-19 9:42 ` Chen, Tiejun 2014-05-19 13:35 ` [Qemu-devel] " Konrad Rzeszutek Wilk 2014-05-19 13:35 ` Konrad Rzeszutek Wilk 2014-05-20 9:32 ` [Qemu-devel] " Chen, Tiejun 2014-05-20 9:32 ` Chen, Tiejun 2014-05-19 12:10 ` [Qemu-devel] " Stefano Stabellini 2014-05-19 12:10 ` Stefano Stabellini 2014-05-20 5:09 ` [Qemu-devel] " Chen, Tiejun 2014-05-20 5:09 ` Chen, Tiejun 2014-05-16 10:53 ` [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-16 14:08 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk 2014-05-16 14:08 ` Konrad Rzeszutek Wilk 2014-05-19 9:54 ` [Qemu-devel] " Chen, Tiejun 2014-05-19 9:54 ` Chen, Tiejun 2014-05-19 6:44 ` [Qemu-devel] " Gerd Hoffmann 2014-05-19 6:44 ` Gerd Hoffmann 2014-05-19 7:48 ` [Qemu-devel] [Xen-devel] " Fabio Fantoni 2014-05-19 7:48 ` Fabio Fantoni 2014-05-19 8:15 ` [Qemu-devel] " Zhang, Yang Z 2014-05-19 8:15 ` Zhang, Yang Z 2014-05-19 9:34 ` [Qemu-devel] " Chen, Tiejun 2014-05-19 9:34 ` Chen, Tiejun 2014-05-19 9:25 ` [Qemu-devel] " Chen, Tiejun 2014-05-19 9:25 ` Chen, Tiejun 2014-05-19 10:13 ` [Qemu-devel] " Michael S. Tsirkin 2014-05-19 10:13 ` Michael S. Tsirkin 2014-05-20 9:34 ` [Qemu-devel] " Chen, Tiejun 2014-05-20 9:34 ` Chen, Tiejun 2014-05-20 11:36 ` [Qemu-devel] " Michael S. Tsirkin 2014-05-20 11:36 ` Michael S. Tsirkin 2014-05-19 11:22 ` [Qemu-devel] " Gerd Hoffmann 2014-05-19 11:22 ` Gerd Hoffmann 2014-05-19 12:04 ` [Qemu-devel] " Chen, Tiejun 2014-05-19 12:04 ` Chen, Tiejun 2014-05-19 13:50 ` [Qemu-devel] " Gerd Hoffmann 2014-05-19 13:50 ` Gerd Hoffmann 2014-05-19 14:00 ` [Qemu-devel] " Daniel P. Berrange 2014-05-19 14:00 ` Daniel P. Berrange 2014-05-21 7:07 ` [Qemu-devel] " Chen, Tiejun 2014-05-21 7:07 ` Chen, Tiejun 2014-05-22 0:31 ` [Qemu-devel] " Chen, Tiejun 2014-05-22 0:31 ` Chen, Tiejun 2014-05-22 5:39 ` [Qemu-devel] " Gerd Hoffmann 2014-05-22 5:39 ` Gerd Hoffmann 2014-05-22 6:18 ` [Qemu-devel] " Chen, Tiejun 2014-05-22 6:18 ` Chen, Tiejun 2014-05-22 6:44 ` [Qemu-devel] " Gerd Hoffmann 2014-05-22 6:44 ` Gerd Hoffmann 2014-05-22 6:49 ` [Qemu-devel] " Michael S. Tsirkin 2014-05-22 6:49 ` Michael S. Tsirkin 2014-05-22 7:11 ` [Qemu-devel] " Chen, Tiejun 2014-05-22 7:11 ` Chen, Tiejun 2014-05-22 10:50 ` [Qemu-devel] " Chen, Tiejun 2014-05-22 10:50 ` Chen, Tiejun 2014-05-22 11:03 ` [Qemu-devel] " Gonglei (Arei) 2014-05-22 11:03 ` Gonglei (Arei) 2014-05-22 11:22 ` [Qemu-devel] " Gerd Hoffmann 2014-05-22 11:22 ` Gerd Hoffmann 2014-05-23 1:07 ` Chen, Tiejun 2014-05-23 1:07 ` Chen, Tiejun 2014-05-22 11:25 ` [Qemu-devel] " Michael S. Tsirkin 2014-05-22 11:25 ` Michael S. Tsirkin 2014-05-22 14:20 ` [Qemu-devel] [Xen-devel] " Igor Mammedov 2014-05-22 14:20 ` Igor Mammedov 2014-05-23 1:18 ` [Qemu-devel] " Chen, Tiejun 2014-05-23 1:18 ` Chen, Tiejun 2014-05-23 7:38 ` [Qemu-devel] " Igor Mammedov 2014-05-23 7:38 ` Igor Mammedov 2014-05-23 10:52 ` [Qemu-devel] " Anthony PERARD 2014-05-23 10:52 ` Anthony PERARD 2014-05-23 11:40 ` [Qemu-devel] " Stefano Stabellini 2014-05-23 11:40 ` Stefano Stabellini 2014-05-23 11:53 ` [Qemu-devel] " Gerd Hoffmann 2014-05-23 11:53 ` Gerd Hoffmann 2014-05-23 12:06 ` [Qemu-devel] " Igor Mammedov 2014-05-23 12:06 ` Igor Mammedov 2014-05-23 12:16 ` [Qemu-devel] " Igor Mammedov 2014-05-23 12:16 ` Igor Mammedov 2014-05-22 9:58 ` [Qemu-devel] " Konrad Rzeszutek Wilk 2014-05-22 9:58 ` Konrad Rzeszutek Wilk 2014-05-20 14:45 ` [Qemu-devel] " Anthony PERARD 2014-05-20 14:45 ` Anthony PERARD 2014-05-21 1:25 ` [Qemu-devel] " Chen, Tiejun 2014-05-21 1:25 ` Chen, Tiejun 2014-06-25 2:49 ` [Qemu-devel] " Chen, Tiejun 2014-06-25 2:49 ` Chen, Tiejun 2014-06-25 23:04 ` [Qemu-devel] " Slutz, Donald Christopher 2014-06-25 23:04 ` Slutz, Donald Christopher 2014-06-26 2:00 ` [Qemu-devel] " Chen, Tiejun 2014-06-26 2:00 ` Chen, Tiejun 2014-06-26 8:23 ` [Qemu-devel] " Chen, Tiejun 2014-06-26 8:23 ` Chen, Tiejun 2014-06-26 16:58 ` [Qemu-devel] " Don Slutz 2014-06-26 16:58 ` Don Slutz 2014-06-30 9:29 ` [Qemu-devel] " Gerd Hoffmann 2014-06-30 9:29 ` Gerd Hoffmann 2014-06-30 10:23 ` [Qemu-devel] " Chen, Tiejun 2014-06-30 10:23 ` Chen, Tiejun 2014-05-16 10:53 ` [Qemu-devel] [v2][PATCH 5/8] xen, gfx passthrough: create intel isa bridge Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-16 14:11 ` Konrad Rzeszutek Wilk [this message] 2014-05-16 14:11 ` [Xen-devel] " Konrad Rzeszutek Wilk 2014-05-19 9:59 ` [Qemu-devel] " Chen, Tiejun 2014-05-19 9:59 ` Chen, Tiejun 2014-05-16 10:53 ` [Qemu-devel] [v2][PATCH 6/8] xen, gfx passthrough: support Intel IGD passthrough with VT-D Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-16 14:35 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk 2014-05-16 14:35 ` Konrad Rzeszutek Wilk 2014-05-19 0:58 ` [Qemu-devel] " Zhang, Yang Z 2014-05-19 0:58 ` Zhang, Yang Z 2014-05-19 13:34 ` [Qemu-devel] " Konrad Rzeszutek Wilk 2014-05-19 13:34 ` Konrad Rzeszutek Wilk 2014-05-20 5:13 ` [Qemu-devel] " Chen, Tiejun 2014-05-20 5:13 ` Chen, Tiejun 2014-05-20 13:39 ` [Qemu-devel] " Konrad Rzeszutek Wilk 2014-05-20 13:39 ` Konrad Rzeszutek Wilk 2014-05-19 10:02 ` [Qemu-devel] [Xen-devel] " Chen, Tiejun 2014-05-19 10:02 ` Chen, Tiejun 2014-05-16 10:53 ` [Qemu-devel] [v2][PATCH 7/8] xen, gfx passthrough: create host bridge to passthrough Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-16 14:37 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk 2014-05-16 14:37 ` Konrad Rzeszutek Wilk 2014-05-19 10:03 ` [Qemu-devel] " Chen, Tiejun 2014-05-19 10:03 ` Chen, Tiejun 2014-05-16 10:53 ` [Qemu-devel] [v2][PATCH 8/8] xen, gfx passthrough: add opregion mapping Tiejun Chen 2014-05-16 10:53 ` Tiejun Chen 2014-05-19 11:53 ` [Qemu-devel] " Stefano Stabellini 2014-05-19 11:53 ` Stefano Stabellini 2014-05-20 9:24 ` [Qemu-devel] " Chen, Tiejun 2014-05-20 9:24 ` Chen, Tiejun 2014-05-20 10:50 ` [Qemu-devel] " Stefano Stabellini 2014-05-20 10:50 ` Stefano Stabellini 2014-05-21 0:57 ` [Qemu-devel] " Chen, Tiejun 2014-05-21 0:57 ` Chen, Tiejun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140516141133.GD3154@phenom.dumpdata.com \ --to=konrad.wilk@oracle.com \ --cc=Kelly.Zytaruk@amd.com \ --cc=allen.m.kay@intel.com \ --cc=anthony.perard@citrix.com \ --cc=anthony@codemonkey.ws \ --cc=jean.guyader@eu.citrix.com \ --cc=mst@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=stefano.stabellini@eu.citrix.com \ --cc=tiejun.chen@intel.com \ --cc=weidong.han@intel.com \ --cc=xen-devel@lists.xensource.com \ --cc=yang.z.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.