* Re: regulator: bcm590xx: Add support for regulators on secondary I2C slave [not found] <20140603192910.BB56066103D@gitolite.kernel.org> @ 2014-06-10 15:22 ` Dave Jones 2014-06-16 8:06 ` Lee Jones 0 siblings, 1 reply; 3+ messages in thread From: Dave Jones @ 2014-06-10 15:22 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: mporter, lee.jones On Tue, Jun 03, 2014 at 07:29:10PM +0000, Linux Kernel wrote: > Gitweb: http://git.kernel.org/linus/;a=commit;h=c6466950e917890be3050171f6745ccb9d91d35f > Commit: c6466950e917890be3050171f6745ccb9d91d35f > Parent: 9e1e726311830bc5b8b568d5178f6a52c357fb6e > Refname: refs/heads/next > Author: Matt Porter <mporter@linaro.org> > AuthorDate: Wed Apr 23 19:21:32 2014 -0400 > Committer: Lee Jones <lee.jones@linaro.org> > CommitDate: Wed May 21 10:40:16 2014 +0100 > > regulator: bcm590xx: Add support for regulators on secondary I2C slave > > The bcm590xx MFD driver now exposes a secondary regmap descriptor > making the registers for regulators on the secondary I2C slave address > available. Add support for GPLDO1-6 and VBUS regulators found within > this register range. > -#define BCM590XX_NUM_REGS 20 > +#define BCM590XX_NUM_REGS 27 Coverity picked up that this change has introduced a out of bounds read. The loop in bcm590xx_probe iterates from 0 to NUM_REGS, but the bcm590xx_regs struct it iterates over using the ptr 'info' is only 26 elements. Dave ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: regulator: bcm590xx: Add support for regulators on secondary I2C slave 2014-06-10 15:22 ` regulator: bcm590xx: Add support for regulators on secondary I2C slave Dave Jones @ 2014-06-16 8:06 ` Lee Jones 2014-06-17 15:38 ` Matt Porter 0 siblings, 1 reply; 3+ messages in thread From: Lee Jones @ 2014-06-16 8:06 UTC (permalink / raw) To: Dave Jones, Linux Kernel Mailing List, mporter On Tue, 10 Jun 2014, Dave Jones wrote: > On Tue, Jun 03, 2014 at 07:29:10PM +0000, Linux Kernel wrote: > > Gitweb: http://git.kernel.org/linus/;a=commit;h=c6466950e917890be3050171f6745ccb9d91d35f > > Commit: c6466950e917890be3050171f6745ccb9d91d35f > > Parent: 9e1e726311830bc5b8b568d5178f6a52c357fb6e > > Refname: refs/heads/next > > Author: Matt Porter <mporter@linaro.org> > > AuthorDate: Wed Apr 23 19:21:32 2014 -0400 > > Committer: Lee Jones <lee.jones@linaro.org> > > CommitDate: Wed May 21 10:40:16 2014 +0100 > > > > regulator: bcm590xx: Add support for regulators on secondary I2C slave > > > > The bcm590xx MFD driver now exposes a secondary regmap descriptor > > making the registers for regulators on the secondary I2C slave address > > available. Add support for GPLDO1-6 and VBUS regulators found within > > this register range. > > > -#define BCM590XX_NUM_REGS 20 > > +#define BCM590XX_NUM_REGS 27 > > Coverity picked up that this change has introduced a out of bounds read. > The loop in bcm590xx_probe iterates from 0 to NUM_REGS, > but the bcm590xx_regs struct it iterates over using the ptr 'info' is only 26 > elements. Nice little tool. :) Matt, I assume you'll fix this yourself? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: regulator: bcm590xx: Add support for regulators on secondary I2C slave 2014-06-16 8:06 ` Lee Jones @ 2014-06-17 15:38 ` Matt Porter 0 siblings, 0 replies; 3+ messages in thread From: Matt Porter @ 2014-06-17 15:38 UTC (permalink / raw) To: Lee Jones; +Cc: Dave Jones, Linux Kernel Mailing List On Mon, Jun 16, 2014 at 09:06:01AM +0100, Lee Jones wrote: > On Tue, 10 Jun 2014, Dave Jones wrote: > > On Tue, Jun 03, 2014 at 07:29:10PM +0000, Linux Kernel wrote: > > > Gitweb: http://git.kernel.org/linus/;a=commit;h=c6466950e917890be3050171f6745ccb9d91d35f > > > Commit: c6466950e917890be3050171f6745ccb9d91d35f > > > Parent: 9e1e726311830bc5b8b568d5178f6a52c357fb6e > > > Refname: refs/heads/next > > > Author: Matt Porter <mporter@linaro.org> > > > AuthorDate: Wed Apr 23 19:21:32 2014 -0400 > > > Committer: Lee Jones <lee.jones@linaro.org> > > > CommitDate: Wed May 21 10:40:16 2014 +0100 > > > > > > regulator: bcm590xx: Add support for regulators on secondary I2C slave > > > > > > The bcm590xx MFD driver now exposes a secondary regmap descriptor > > > making the registers for regulators on the secondary I2C slave address > > > available. Add support for GPLDO1-6 and VBUS regulators found within > > > this register range. > > > > > -#define BCM590XX_NUM_REGS 20 > > > +#define BCM590XX_NUM_REGS 27 > > > > Coverity picked up that this change has introduced a out of bounds read. > > The loop in bcm590xx_probe iterates from 0 to NUM_REGS, > > but the bcm590xx_regs struct it iterates over using the ptr 'info' is only 26 > > elements. > > Nice little tool. :) Indeed > Matt, I assume you'll fix this yourself? Yes, we actually found this from functional tests before Dave's coverity run found it. Graham Williams is going to post a patch that fixes this issue since he noticed it while working on some dwc2 support. -Matt ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-17 15:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20140603192910.BB56066103D@gitolite.kernel.org>
2014-06-10 15:22 ` regulator: bcm590xx: Add support for regulators on secondary I2C slave Dave Jones
2014-06-16 8:06 ` Lee Jones
2014-06-17 15:38 ` Matt Porter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.