* [PATCH] Frees gate after if statement in clk-sunxi.c
@ 2014-06-14 18:11 ` Nick
0 siblings, 0 replies; 14+ messages in thread
From: Nick @ 2014-06-14 18:11 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Nick <xerofoify@gmail.com>
---
drivers/clk/sunxi/clk-sunxi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index 4264834..6f4fc51 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
u32 rate;
if (of_property_read_u32(node, "clock-frequency", &rate))
+ kree(gate);
return;
/* allocate fixed-rate and gate clock structs */
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] Frees gate after if statement in clk-sunxi.c
2014-06-14 18:11 ` Nick
@ 2014-06-14 19:35 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2014-06-14 19:35 UTC (permalink / raw)
To: Nick, emilio; +Cc: maxime.ripard, mturquette, linux-kernel, linux-arm-kernel
On 06/14/2014 10:11 PM, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
'gate' is not allocated at this point either... at least not in Linus' tree.
> return;
And you forgot {} around these 2 statements.
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] Frees gate after if statement in clk-sunxi.c
@ 2014-06-14 19:35 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2014-06-14 19:35 UTC (permalink / raw)
To: linux-arm-kernel
On 06/14/2014 10:11 PM, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
'gate' is not allocated at this point either... at least not in Linus' tree.
> return;
And you forgot {} around these 2 statements.
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Frees gate after if statement in clk-sunxi.c
2014-06-14 18:11 ` Nick
@ 2014-06-14 22:06 ` Adam Baker
-1 siblings, 0 replies; 14+ messages in thread
From: Adam Baker @ 2014-06-14 22:06 UTC (permalink / raw)
To: Nick, emilio; +Cc: maxime.ripard, mturquette, linux-kernel, linux-arm-kernel
On 14/06/14 19:11, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
> return;
There are no braces around this so the function of this code as written
is an unconditional return and the return shouldn't be indented. I
suspect, without reading the rest of the file, that that isn't what you
intended.
>
> /* allocate fixed-rate and gate clock structs */
>
Adam
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] Frees gate after if statement in clk-sunxi.c
@ 2014-06-14 22:06 ` Adam Baker
0 siblings, 0 replies; 14+ messages in thread
From: Adam Baker @ 2014-06-14 22:06 UTC (permalink / raw)
To: linux-arm-kernel
On 14/06/14 19:11, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
> return;
There are no braces around this so the function of this code as written
is an unconditional return and the return shouldn't be indented. I
suspect, without reading the rest of the file, that that isn't what you
intended.
>
> /* allocate fixed-rate and gate clock structs */
>
Adam
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Frees gate after if statement in clk-sunxi.c
2014-06-14 18:11 ` Nick
@ 2014-06-15 20:30 ` Maxime Ripard
-1 siblings, 0 replies; 14+ messages in thread
From: Maxime Ripard @ 2014-06-15 20:30 UTC (permalink / raw)
To: Nick; +Cc: emilio, mturquette, linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
This should be your full real name here.
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
There's a typo in kfree. How does that even compile?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] Frees gate after if statement in clk-sunxi.c
@ 2014-06-15 20:30 ` Maxime Ripard
0 siblings, 0 replies; 14+ messages in thread
From: Maxime Ripard @ 2014-06-15 20:30 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
This should be your full real name here.
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
There's a typo in kfree. How does that even compile?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140615/ff1118cc/attachment.sig>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Frees gate after if statement in clk-sunxi.c
2014-06-15 20:30 ` Maxime Ripard
@ 2014-06-16 3:21 ` Nick Krause
-1 siblings, 0 replies; 14+ messages in thread
From: Nick Krause @ 2014-06-16 3:21 UTC (permalink / raw)
To: Maxime Ripard
Cc: Emilio López, Mike Turquette, linux-kernel, linux-arm-kernel
New Patch Just Fixed Typo for my email client.
Signed-off-by: Nick <xerofoify@gmail.com>
---
drivers/clk/sunxi/clk-sunxi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.
c b/drivers/clk/sunxi/clk-sunxi.c
index 4264834..6f4fc51 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
device_node *node)
u32 rate;
if (of_property_read_u32(node, "clock-frequency", &rate))
+ kfree(gate);
return;
/* allocate fixed-rate and gate clock structs */
Cheers Nick
On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>> Signed-off-by: Nick <xerofoify@gmail.com>
>
> This should be your full real name here.
>
>> ---
>> drivers/clk/sunxi/clk-sunxi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>> index 4264834..6f4fc51 100644
>> --- a/drivers/clk/sunxi/clk-sunxi.c
>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>> u32 rate;
>>
>> if (of_property_read_u32(node, "clock-frequency", &rate))
>> + kree(gate);
>
> There's a typo in kfree. How does that even compile?
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH] Frees gate after if statement in clk-sunxi.c
@ 2014-06-16 3:21 ` Nick Krause
0 siblings, 0 replies; 14+ messages in thread
From: Nick Krause @ 2014-06-16 3:21 UTC (permalink / raw)
To: linux-arm-kernel
New Patch Just Fixed Typo for my email client.
Signed-off-by: Nick <xerofoify@gmail.com>
---
drivers/clk/sunxi/clk-sunxi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.
c b/drivers/clk/sunxi/clk-sunxi.c
index 4264834..6f4fc51 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
device_node *node)
u32 rate;
if (of_property_read_u32(node, "clock-frequency", &rate))
+ kfree(gate);
return;
/* allocate fixed-rate and gate clock structs */
Cheers Nick
On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>> Signed-off-by: Nick <xerofoify@gmail.com>
>
> This should be your full real name here.
>
>> ---
>> drivers/clk/sunxi/clk-sunxi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>> index 4264834..6f4fc51 100644
>> --- a/drivers/clk/sunxi/clk-sunxi.c
>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>> u32 rate;
>>
>> if (of_property_read_u32(node, "clock-frequency", &rate))
>> + kree(gate);
>
> There's a typo in kfree. How does that even compile?
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] Frees gate after if statement in clk-sunxi.c
2014-06-16 3:21 ` Nick Krause
@ 2014-06-16 3:31 ` Nick Krause
-1 siblings, 0 replies; 14+ messages in thread
From: Nick Krause @ 2014-06-16 3:31 UTC (permalink / raw)
To: Maxime Ripard
Cc: Emilio López, Mike Turquette, linux-kernel, linux-arm-kernel
Seems the bug is fixed , don't worry about resent patch.
Thanks Nick
On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <xerofoify@gmail.com> wrote:
> New Patch Just Fixed Typo for my email client.
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.
> c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kfree(gate);
> return;
>
> /* allocate fixed-rate and gate clock structs */
> Cheers Nick
>
> On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>>> Signed-off-by: Nick <xerofoify@gmail.com>
>>
>> This should be your full real name here.
>>
>>> ---
>>> drivers/clk/sunxi/clk-sunxi.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>>> index 4264834..6f4fc51 100644
>>> --- a/drivers/clk/sunxi/clk-sunxi.c
>>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>>> u32 rate;
>>>
>>> if (of_property_read_u32(node, "clock-frequency", &rate))
>>> + kree(gate);
>>
>> There's a typo in kfree. How does that even compile?
>>
>> --
>> Maxime Ripard, Free Electrons
>> Embedded Linux, Kernel and Android engineering
>> http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] Frees gate after if statement in clk-sunxi.c
@ 2014-06-16 3:31 ` Nick Krause
0 siblings, 0 replies; 14+ messages in thread
From: Nick Krause @ 2014-06-16 3:31 UTC (permalink / raw)
To: linux-arm-kernel
Seems the bug is fixed , don't worry about resent patch.
Thanks Nick
On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <xerofoify@gmail.com> wrote:
> New Patch Just Fixed Typo for my email client.
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.
> c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kfree(gate);
> return;
>
> /* allocate fixed-rate and gate clock structs */
> Cheers Nick
>
> On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>>> Signed-off-by: Nick <xerofoify@gmail.com>
>>
>> This should be your full real name here.
>>
>>> ---
>>> drivers/clk/sunxi/clk-sunxi.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>>> index 4264834..6f4fc51 100644
>>> --- a/drivers/clk/sunxi/clk-sunxi.c
>>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>>> u32 rate;
>>>
>>> if (of_property_read_u32(node, "clock-frequency", &rate))
>>> + kree(gate);
>>
>> There's a typo in kfree. How does that even compile?
>>
>> --
>> Maxime Ripard, Free Electrons
>> Embedded Linux, Kernel and Android engineering
>> http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Frees gate after if statement in clk-sunxi.c
2014-06-16 3:31 ` Nick Krause
@ 2014-06-16 8:15 ` Russell King - ARM Linux
-1 siblings, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux @ 2014-06-16 8:15 UTC (permalink / raw)
To: Nick Krause
Cc: Maxime Ripard, Emilio López, Mike Turquette, linux-kernel,
linux-arm-kernel
On Sun, Jun 15, 2014 at 11:31:41PM -0400, Nick Krause wrote:
> Seems the bug is fixed , don't worry about resent patch.
> Thanks Nick
>
> On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <xerofoify@gmail.com> wrote:
> > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> > device_node *node)
> > u32 rate;
> >
> > if (of_property_read_u32(node, "clock-frequency", &rate))
> > + kfree(gate);
> > return;
In any case, the kernel is not coded in Python.
C uses braces { } to enclose blocks of code, and does not care about
indentation - indentation is meaningless to C. Python purely identifies
blocks of code by indentation alone.
Please take account of the programming language when creating patches.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] Frees gate after if statement in clk-sunxi.c
@ 2014-06-16 8:15 ` Russell King - ARM Linux
0 siblings, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux @ 2014-06-16 8:15 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jun 15, 2014 at 11:31:41PM -0400, Nick Krause wrote:
> Seems the bug is fixed , don't worry about resent patch.
> Thanks Nick
>
> On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <xerofoify@gmail.com> wrote:
> > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> > device_node *node)
> > u32 rate;
> >
> > if (of_property_read_u32(node, "clock-frequency", &rate))
> > + kfree(gate);
> > return;
In any case, the kernel is not coded in Python.
C uses braces { } to enclose blocks of code, and does not care about
indentation - indentation is meaningless to C. Python purely identifies
blocks of code by indentation alone.
Please take account of the programming language when creating patches.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
^ permalink raw reply [flat|nested] 14+ messages in thread