From: Mark Brown <broonie@kernel.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH] regulator: core: Still free GPIOs using gpio_free()
Date: Tue, 1 Jul 2014 13:11:42 +0100 [thread overview]
Message-ID: <20140701121142.GM23300@sirena.org.uk> (raw)
In-Reply-To: <20140701120622.GJ32514@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
On Tue, Jul 01, 2014 at 01:06:22PM +0100, Russell King - ARM Linux wrote:
> On Tue, Jul 01, 2014 at 12:55:26PM +0100, Mark Brown wrote:
> > Even though we mostly use GPIO descriptors internally we still use
> > gpio_request_one() to request so we need to pair that with gpio_free() to
> > release the GPIO.
> This doesn't explain the reason... I see the current GPIO code doing this:
> void gpio_free(unsigned gpio)
> {
> gpiod_free(gpio_to_desc(gpio));
> }
> EXPORT_SYMBOL_GPL(gpio_free);
Huh, good point (though it still seems a bit neater to match up the
request and release functions I guess). Linus?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: core: Still free GPIOs using gpio_free()
Date: Tue, 1 Jul 2014 13:11:42 +0100 [thread overview]
Message-ID: <20140701121142.GM23300@sirena.org.uk> (raw)
In-Reply-To: <20140701120622.GJ32514@n2100.arm.linux.org.uk>
On Tue, Jul 01, 2014 at 01:06:22PM +0100, Russell King - ARM Linux wrote:
> On Tue, Jul 01, 2014 at 12:55:26PM +0100, Mark Brown wrote:
> > Even though we mostly use GPIO descriptors internally we still use
> > gpio_request_one() to request so we need to pair that with gpio_free() to
> > release the GPIO.
> This doesn't explain the reason... I see the current GPIO code doing this:
> void gpio_free(unsigned gpio)
> {
> gpiod_free(gpio_to_desc(gpio));
> }
> EXPORT_SYMBOL_GPL(gpio_free);
Huh, good point (though it still seems a bit neater to match up the
request and release functions I guess). Linus?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140701/833c328d/attachment.sig>
next prev parent reply other threads:[~2014-07-01 12:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 11:55 [PATCH] regulator: core: Still free GPIOs using gpio_free() Mark Brown
2014-07-01 11:55 ` Mark Brown
2014-07-01 12:06 ` Russell King - ARM Linux
2014-07-01 12:06 ` Russell King - ARM Linux
2014-07-01 12:11 ` Mark Brown [this message]
2014-07-01 12:11 ` Mark Brown
2014-07-01 12:24 ` Alexandre Courbot
2014-07-01 12:24 ` Alexandre Courbot
2014-07-01 12:27 ` Mark Brown
2014-07-01 12:27 ` Mark Brown
2014-07-08 8:33 ` Linus Walleij
2014-07-08 8:33 ` Linus Walleij
2014-07-08 11:53 ` Mark Brown
2014-07-08 11:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701121142.GM23300@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.