From: Mark Brown <broonie@kernel.org> To: Beniamino Galvani <b.galvani@gmail.com> Cc: Liam Girdwood <lgirdwood@gmail.com>, Wenyou Yang <wenyou.yang@atmel.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Heiko Stuebner <heiko@sntech.de>, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/5] regulator: act8865: set correct number of regulators in pdata Date: Thu, 3 Jul 2014 16:55:38 +0100 [thread overview] Message-ID: <20140703155538.GG410@sirena.org.uk> (raw) In-Reply-To: <20140629094642.GA13485@gmail.com> [-- Attachment #1: Type: text/plain, Size: 1346 bytes --] On Sun, Jun 29, 2014 at 11:46:43AM +0200, Beniamino Galvani wrote: > On Fri, Jun 27, 2014 at 05:07:25PM +0100, Mark Brown wrote: > > On Sun, Jun 22, 2014 at 05:31:42PM +0200, Beniamino Galvani wrote: > > > When platform data is populated from DT all the regulators are > > > instantiated and the value of num_regulators should be the number of > > > all available regulators rather than the number of matched ones. > > Could you go into more detail on your logic on this one please? The > > platform data (and DT configuration) for regulators should be completely > > optional. > pdata contains an array of struct act8865_regulator_data and a > num_regulators field which should hold the number of elements in the > array, if I understand correctly. > So in the current code, when populating platform data from DT, there > is a mismatch between the number of elements that are put in the array > (ARRAY_SIZE(act8865_matches)) and the value of num_regulators, which > is set to the number of regulators found in the DT. > In case of missing regulator nodes in DT, pdata->regulators will be > populated with all the regulators but their init_data will be NULL. OK, so that was slightly unclear but I see what you're saying now - the issue isn't that there will be fewer valid elements in the array, it's that the array is sparsely populated. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] regulator: act8865: set correct number of regulators in pdata Date: Thu, 3 Jul 2014 16:55:38 +0100 [thread overview] Message-ID: <20140703155538.GG410@sirena.org.uk> (raw) In-Reply-To: <20140629094642.GA13485@gmail.com> On Sun, Jun 29, 2014 at 11:46:43AM +0200, Beniamino Galvani wrote: > On Fri, Jun 27, 2014 at 05:07:25PM +0100, Mark Brown wrote: > > On Sun, Jun 22, 2014 at 05:31:42PM +0200, Beniamino Galvani wrote: > > > When platform data is populated from DT all the regulators are > > > instantiated and the value of num_regulators should be the number of > > > all available regulators rather than the number of matched ones. > > Could you go into more detail on your logic on this one please? The > > platform data (and DT configuration) for regulators should be completely > > optional. > pdata contains an array of struct act8865_regulator_data and a > num_regulators field which should hold the number of elements in the > array, if I understand correctly. > So in the current code, when populating platform data from DT, there > is a mismatch between the number of elements that are put in the array > (ARRAY_SIZE(act8865_matches)) and the value of num_regulators, which > is set to the number of regulators found in the DT. > In case of missing regulator nodes in DT, pdata->regulators will be > populated with all the regulators but their init_data will be NULL. OK, so that was slightly unclear but I see what you're saying now - the issue isn't that there will be fewer valid elements in the array, it's that the array is sparsely populated. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140703/a270ced5/attachment-0001.sig>
next prev parent reply other threads:[~2014-07-03 15:56 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-22 15:31 [PATCH 0/5] regulator: act8865: add support for act8846 Beniamino Galvani 2014-06-22 15:31 ` Beniamino Galvani 2014-06-22 15:31 ` [PATCH 1/5] regulator: act8865: fix parsing of platform data Beniamino Galvani 2014-06-22 15:31 ` Beniamino Galvani 2014-06-23 9:45 ` Yang, Wenyou 2014-06-23 9:45 ` Yang, Wenyou 2014-06-23 9:45 ` Yang, Wenyou 2014-06-27 16:09 ` Mark Brown 2014-06-27 16:09 ` Mark Brown 2014-06-22 15:31 ` [PATCH 2/5] regulator: act8865: set correct number of regulators in pdata Beniamino Galvani 2014-06-22 15:31 ` Beniamino Galvani 2014-06-23 9:45 ` Yang, Wenyou 2014-06-23 9:45 ` Yang, Wenyou 2014-06-23 9:45 ` Yang, Wenyou 2014-06-27 16:07 ` Mark Brown 2014-06-27 16:07 ` Mark Brown 2014-06-29 9:46 ` Beniamino Galvani 2014-06-29 9:46 ` Beniamino Galvani 2014-06-29 9:46 ` Beniamino Galvani 2014-07-03 15:55 ` Mark Brown [this message] 2014-07-03 15:55 ` Mark Brown 2014-07-03 15:58 ` Mark Brown 2014-07-03 15:58 ` Mark Brown 2014-06-22 15:31 ` [PATCH 3/5] regulator: act8865: prepare support for other act88xx devices Beniamino Galvani 2014-06-22 15:31 ` Beniamino Galvani 2014-06-23 9:46 ` Yang, Wenyou 2014-06-23 9:46 ` Yang, Wenyou 2014-06-23 9:46 ` Yang, Wenyou 2014-07-03 16:00 ` Mark Brown 2014-07-03 16:00 ` Mark Brown 2014-06-22 15:31 ` [PATCH 4/5] regulator: act8865: add support for act8846 Beniamino Galvani 2014-06-22 15:31 ` Beniamino Galvani 2014-06-23 9:46 ` Yang, Wenyou 2014-06-23 9:46 ` Yang, Wenyou 2014-06-23 9:46 ` Yang, Wenyou 2014-06-22 15:31 ` [PATCH 5/5] regulator: act8865: add act8846 to DT binding documentation Beniamino Galvani 2014-06-22 15:31 ` Beniamino Galvani
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140703155538.GG410@sirena.org.uk \ --to=broonie@kernel.org \ --cc=b.galvani@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=wenyou.yang@atmel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.