From: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
To: Beniamino Galvani <b.galvani@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/5] regulator: act8865: set correct number of regulators in pdata
Date: Mon, 23 Jun 2014 09:45:51 +0000 [thread overview]
Message-ID: <B256D81BAE5131468A838E5D7A2436419D1B5CB1@penmbx01> (raw)
In-Reply-To: <1403451105-31929-3-git-send-email-b.galvani@gmail.com>
> -----Original Message-----
> From: Beniamino Galvani [mailto:b.galvani@gmail.com]
> Sent: Sunday, June 22, 2014 11:32 PM
> To: Liam Girdwood; Mark Brown
> Cc: Yang, Wenyou; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell;
> Kumar Gala; Heiko Stuebner; devicetree@vger.kernel.org; linux-
> doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; Beniamino Galvani
> Subject: [PATCH 2/5] regulator: act8865: set correct number of
> regulators in pdata
>
> When platform data is populated from DT all the regulators are
> instantiated and the value of num_regulators should be the number of
> all available regulators rather than the number of matched ones.
>
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
> drivers/regulator/act8865-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8865-regulator.c
> b/drivers/regulator/act8865-regulator.c
> index fe2c038..b03a0e8 100644
> --- a/drivers/regulator/act8865-regulator.c
> +++ b/drivers/regulator/act8865-regulator.c
> @@ -230,7 +230,7 @@ static int act8865_pdata_from_dt(struct device *dev,
> if (!pdata->regulators)
> return -ENOMEM;
>
> - pdata->num_regulators = matched;
> + pdata->num_regulators = ARRAY_SIZE(act8865_matches);
> regulator = pdata->regulators;
>
> for (i = 0; i < ARRAY_SIZE(act8865_matches); i++) {
> --
> 1.7.10.4
Tested on at91-sama5d3_xplained with ACT8865
Tested-by Wenyou.Yang <wenyou.yang@atmel.com>
Best Regards,
Wenyou Yang
WARNING: multiple messages have this Message-ID (diff)
From: Wenyou.Yang@atmel.com (Yang, Wenyou)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] regulator: act8865: set correct number of regulators in pdata
Date: Mon, 23 Jun 2014 09:45:51 +0000 [thread overview]
Message-ID: <B256D81BAE5131468A838E5D7A2436419D1B5CB1@penmbx01> (raw)
In-Reply-To: <1403451105-31929-3-git-send-email-b.galvani@gmail.com>
> -----Original Message-----
> From: Beniamino Galvani [mailto:b.galvani at gmail.com]
> Sent: Sunday, June 22, 2014 11:32 PM
> To: Liam Girdwood; Mark Brown
> Cc: Yang, Wenyou; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell;
> Kumar Gala; Heiko Stuebner; devicetree at vger.kernel.org; linux-
> doc at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; Beniamino Galvani
> Subject: [PATCH 2/5] regulator: act8865: set correct number of
> regulators in pdata
>
> When platform data is populated from DT all the regulators are
> instantiated and the value of num_regulators should be the number of
> all available regulators rather than the number of matched ones.
>
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
> drivers/regulator/act8865-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8865-regulator.c
> b/drivers/regulator/act8865-regulator.c
> index fe2c038..b03a0e8 100644
> --- a/drivers/regulator/act8865-regulator.c
> +++ b/drivers/regulator/act8865-regulator.c
> @@ -230,7 +230,7 @@ static int act8865_pdata_from_dt(struct device *dev,
> if (!pdata->regulators)
> return -ENOMEM;
>
> - pdata->num_regulators = matched;
> + pdata->num_regulators = ARRAY_SIZE(act8865_matches);
> regulator = pdata->regulators;
>
> for (i = 0; i < ARRAY_SIZE(act8865_matches); i++) {
> --
> 1.7.10.4
Tested on at91-sama5d3_xplained with ACT8865
Tested-by Wenyou.Yang <wenyou.yang@atmel.com>
Best Regards,
Wenyou Yang
next prev parent reply other threads:[~2014-06-23 9:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 15:31 [PATCH 0/5] regulator: act8865: add support for act8846 Beniamino Galvani
2014-06-22 15:31 ` Beniamino Galvani
2014-06-22 15:31 ` [PATCH 1/5] regulator: act8865: fix parsing of platform data Beniamino Galvani
2014-06-22 15:31 ` Beniamino Galvani
2014-06-23 9:45 ` Yang, Wenyou
2014-06-23 9:45 ` Yang, Wenyou
2014-06-23 9:45 ` Yang, Wenyou
2014-06-27 16:09 ` Mark Brown
2014-06-27 16:09 ` Mark Brown
2014-06-22 15:31 ` [PATCH 2/5] regulator: act8865: set correct number of regulators in pdata Beniamino Galvani
2014-06-22 15:31 ` Beniamino Galvani
2014-06-23 9:45 ` Yang, Wenyou [this message]
2014-06-23 9:45 ` Yang, Wenyou
2014-06-23 9:45 ` Yang, Wenyou
2014-06-27 16:07 ` Mark Brown
2014-06-27 16:07 ` Mark Brown
2014-06-29 9:46 ` Beniamino Galvani
2014-06-29 9:46 ` Beniamino Galvani
2014-06-29 9:46 ` Beniamino Galvani
2014-07-03 15:55 ` Mark Brown
2014-07-03 15:55 ` Mark Brown
2014-07-03 15:58 ` Mark Brown
2014-07-03 15:58 ` Mark Brown
2014-06-22 15:31 ` [PATCH 3/5] regulator: act8865: prepare support for other act88xx devices Beniamino Galvani
2014-06-22 15:31 ` Beniamino Galvani
2014-06-23 9:46 ` Yang, Wenyou
2014-06-23 9:46 ` Yang, Wenyou
2014-06-23 9:46 ` Yang, Wenyou
2014-07-03 16:00 ` Mark Brown
2014-07-03 16:00 ` Mark Brown
2014-06-22 15:31 ` [PATCH 4/5] regulator: act8865: add support for act8846 Beniamino Galvani
2014-06-22 15:31 ` Beniamino Galvani
2014-06-23 9:46 ` Yang, Wenyou
2014-06-23 9:46 ` Yang, Wenyou
2014-06-23 9:46 ` Yang, Wenyou
2014-06-22 15:31 ` [PATCH 5/5] regulator: act8865: add act8846 to DT binding documentation Beniamino Galvani
2014-06-22 15:31 ` Beniamino Galvani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B256D81BAE5131468A838E5D7A2436419D1B5CB1@penmbx01 \
--to=wenyou.yang@atmel.com \
--cc=b.galvani@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.