From: Marc Dietrich <marvin24@gmx.de>
To: Julian Andres Klode <jak@jak-linux.org>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pawel Lebioda <pawel.lebioda89@gmail.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
ac100@lists.launchpad.net
Subject: Re: [PATCH] staging: nvec: remove unneccessary 'else' after 'return'statement
Date: Sat, 5 Jul 2014 13:49:03 +0200 [thread overview]
Message-ID: <20140705134903.89ec088a6b90e48be9c36f89@gmx.de> (raw)
In-Reply-To: <20140704205941.GA7406@jak-x230>
On Fri, 4 Jul 2014 22:59:41 +0200
Julian Andres Klode <jak@jak-linux.org> wrote:
> On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote:
> > Hi,
> >
> > This patch fixes the following warning reported by checkpatch.pl:
> >
> > WARNING: else is not generally useful after a break or return
> > #235: FILE: drivers/staging/nvec/nvec.c:235:
> >
> > Regards
> > Pawel Lebioda
> >
> > Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
> > drivers/staging/nvec/nvec.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Hi Pawel,
>
> Please format your patches correctly. There should be no
> "Hi", no "Regards", etc. After the signed off should be a
> dashed line.
>
> Use git format-patch to format patches and you can send
> them using git-send-email.
yes, this way you reduce some apply-burdon from Greg. Ideally,
you would combine all patches (one patch per checkpatch warning)
in a common thread like this:
git-format-patch --cover-letter --thread -s <first commit of your
patches>
This way you could add some comments (if any) to the cover letter
and just keep the plain checkpatch message in the other patches. This
has also the advantage that the maintainers only have to ack the "cover
letter".
Marc
--
Marc Dietrich <marvin24@gmx.de>
WARNING: multiple messages have this Message-ID (diff)
From: Marc Dietrich <marvin24@gmx.de>
To: Julian Andres Klode <jak@jak-linux.org>
Cc: Pawel Lebioda <pawel.lebioda89@gmail.com>,
Marc Dietrich <marvin24@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: nvec: remove unneccessary 'else' after 'return'statement
Date: Sat, 5 Jul 2014 13:49:03 +0200 [thread overview]
Message-ID: <20140705134903.89ec088a6b90e48be9c36f89@gmx.de> (raw)
In-Reply-To: <20140704205941.GA7406@jak-x230>
On Fri, 4 Jul 2014 22:59:41 +0200
Julian Andres Klode <jak@jak-linux.org> wrote:
> On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote:
> > Hi,
> >
> > This patch fixes the following warning reported by checkpatch.pl:
> >
> > WARNING: else is not generally useful after a break or return
> > #235: FILE: drivers/staging/nvec/nvec.c:235:
> >
> > Regards
> > Pawel Lebioda
> >
> > Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
> > drivers/staging/nvec/nvec.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Hi Pawel,
>
> Please format your patches correctly. There should be no
> "Hi", no "Regards", etc. After the signed off should be a
> dashed line.
>
> Use git format-patch to format patches and you can send
> them using git-send-email.
yes, this way you reduce some apply-burdon from Greg. Ideally,
you would combine all patches (one patch per checkpatch warning)
in a common thread like this:
git-format-patch --cover-letter --thread -s <first commit of your
patches>
This way you could add some comments (if any) to the cover letter
and just keep the plain checkpatch message in the other patches. This
has also the advantage that the maintainers only have to ack the "cover
letter".
Marc
--
Marc Dietrich <marvin24@gmx.de>
next prev parent reply other threads:[~2014-07-05 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 19:57 [PATCH] staging: nvec: remove unneccessary 'else' after 'return' statement Pawel Lebioda
2014-07-04 19:57 ` Pawel Lebioda
2014-07-04 20:59 ` Julian Andres Klode
2014-07-04 20:59 ` Julian Andres Klode
2014-07-05 11:49 ` Marc Dietrich [this message]
2014-07-05 11:49 ` [PATCH] staging: nvec: remove unneccessary 'else' after 'return'statement Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140705134903.89ec088a6b90e48be9c36f89@gmx.de \
--to=marvin24@gmx.de \
--cc=ac100@lists.launchpad.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jak@jak-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pawel.lebioda89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.