All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mach-omap1: Fix call to omap_cfg_reg
@ 2014-07-04 17:02 ` Nicholas Krause
  0 siblings, 0 replies; 9+ messages in thread
From: Nicholas Krause @ 2014-07-04 17:02 UTC (permalink / raw)
  To: balbi; +Cc: tony, linux, linux-usb, linux-omap, linux-arm-kernel, linux-kernel

This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
that the cpu is a omap16xx and the nwires are not equal to 3.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 arch/arm/mach-omap1/usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
index 4118db5..17e3139 100644
--- a/arch/arm/mach-omap1/usb.c
+++ b/arch/arm/mach-omap1/usb.c
@@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
 		omap_cfg_reg(W9_USB2_TXEN);
 		omap_cfg_reg(W5_USB2_SE0);
 		if (nwires != 3)
-			omap_cfg_reg(Y5_USB2_RCV);
-		// FIXME omap_cfg_reg(USB2_SPEED);
+			omap_cfg_reg(USB2_SPEED)
 	} else {
 		pr_debug("usb%d cpu unrecognized\n", 1);
 		return 0;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] mach-omap1: Fix call to omap_cfg_reg
@ 2014-07-04 17:02 ` Nicholas Krause
  0 siblings, 0 replies; 9+ messages in thread
From: Nicholas Krause @ 2014-07-04 17:02 UTC (permalink / raw)
  To: linux-arm-kernel

This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
that the cpu is a omap16xx and the nwires are not equal to 3.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 arch/arm/mach-omap1/usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
index 4118db5..17e3139 100644
--- a/arch/arm/mach-omap1/usb.c
+++ b/arch/arm/mach-omap1/usb.c
@@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
 		omap_cfg_reg(W9_USB2_TXEN);
 		omap_cfg_reg(W5_USB2_SE0);
 		if (nwires != 3)
-			omap_cfg_reg(Y5_USB2_RCV);
-		// FIXME omap_cfg_reg(USB2_SPEED);
+			omap_cfg_reg(USB2_SPEED)
 	} else {
 		pr_debug("usb%d cpu unrecognized\n", 1);
 		return 0;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] mach-omap1: Fix call to omap_cfg_reg
@ 2014-07-07  8:14   ` Tony Lindgren
  0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2014-07-07  8:14 UTC (permalink / raw)
  To: Nicholas Krause
  Cc: balbi, linux, linux-usb, linux-omap, linux-arm-kernel, linux-kernel

* Nicholas Krause <xerofoify@gmail.com> [140704 10:03]:
> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
> that the cpu is a omap16xx and the nwires are not equal to 3.

This is most likely unsafe to do as the pin is probably
shared with some other device and we have to rely for
the bootloader to do the right thing for the board.

Regards,

Tony
 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/arm/mach-omap1/usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
> index 4118db5..17e3139 100644
> --- a/arch/arm/mach-omap1/usb.c
> +++ b/arch/arm/mach-omap1/usb.c
> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
>  		omap_cfg_reg(W9_USB2_TXEN);
>  		omap_cfg_reg(W5_USB2_SE0);
>  		if (nwires != 3)
> -			omap_cfg_reg(Y5_USB2_RCV);
> -		// FIXME omap_cfg_reg(USB2_SPEED);
> +			omap_cfg_reg(USB2_SPEED)
>  	} else {
>  		pr_debug("usb%d cpu unrecognized\n", 1);
>  		return 0;
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] mach-omap1: Fix call to omap_cfg_reg
@ 2014-07-07  8:14   ` Tony Lindgren
  0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2014-07-07  8:14 UTC (permalink / raw)
  To: Nicholas Krause
  Cc: balbi-l0cyMroinI0, linux-lFZ/pmaqli7XmaaqVzeoHQ,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-omap-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

* Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [140704 10:03]:
> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
> that the cpu is a omap16xx and the nwires are not equal to 3.

This is most likely unsafe to do as the pin is probably
shared with some other device and we have to rely for
the bootloader to do the right thing for the board.

Regards,

Tony
 
> Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/mach-omap1/usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
> index 4118db5..17e3139 100644
> --- a/arch/arm/mach-omap1/usb.c
> +++ b/arch/arm/mach-omap1/usb.c
> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
>  		omap_cfg_reg(W9_USB2_TXEN);
>  		omap_cfg_reg(W5_USB2_SE0);
>  		if (nwires != 3)
> -			omap_cfg_reg(Y5_USB2_RCV);
> -		// FIXME omap_cfg_reg(USB2_SPEED);
> +			omap_cfg_reg(USB2_SPEED)
>  	} else {
>  		pr_debug("usb%d cpu unrecognized\n", 1);
>  		return 0;
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] mach-omap1: Fix call to omap_cfg_reg
@ 2014-07-07  8:14   ` Tony Lindgren
  0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2014-07-07  8:14 UTC (permalink / raw)
  To: linux-arm-kernel

* Nicholas Krause <xerofoify@gmail.com> [140704 10:03]:
> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
> that the cpu is a omap16xx and the nwires are not equal to 3.

This is most likely unsafe to do as the pin is probably
shared with some other device and we have to rely for
the bootloader to do the right thing for the board.

Regards,

Tony
 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/arm/mach-omap1/usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
> index 4118db5..17e3139 100644
> --- a/arch/arm/mach-omap1/usb.c
> +++ b/arch/arm/mach-omap1/usb.c
> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
>  		omap_cfg_reg(W9_USB2_TXEN);
>  		omap_cfg_reg(W5_USB2_SE0);
>  		if (nwires != 3)
> -			omap_cfg_reg(Y5_USB2_RCV);
> -		// FIXME omap_cfg_reg(USB2_SPEED);
> +			omap_cfg_reg(USB2_SPEED)
>  	} else {
>  		pr_debug("usb%d cpu unrecognized\n", 1);
>  		return 0;
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] mach-omap1: Fix call to omap_cfg_reg
  2014-07-07  8:14   ` Tony Lindgren
@ 2014-07-07 17:40     ` Nick Krause
  -1 siblings, 0 replies; 9+ messages in thread
From: Nick Krause @ 2014-07-07 17:40 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: balbi, Russell King - ARM Linux, linux-usb, linux-omap,
	linux-arm-kernel, linux-kernel

Hey Tony,
This seems to be a false positive then.Please reply if it is so I can remove the
Fix me message.
Cheers Nick

On Mon, Jul 7, 2014 at 4:14 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Nicholas Krause <xerofoify@gmail.com> [140704 10:03]:
>> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
>> that the cpu is a omap16xx and the nwires are not equal to 3.
>
> This is most likely unsafe to do as the pin is probably
> shared with some other device and we have to rely for
> the bootloader to do the right thing for the board.
>
> Regards,
>
> Tony
>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  arch/arm/mach-omap1/usb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
>> index 4118db5..17e3139 100644
>> --- a/arch/arm/mach-omap1/usb.c
>> +++ b/arch/arm/mach-omap1/usb.c
>> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
>>               omap_cfg_reg(W9_USB2_TXEN);
>>               omap_cfg_reg(W5_USB2_SE0);
>>               if (nwires != 3)
>> -                     omap_cfg_reg(Y5_USB2_RCV);
>> -             // FIXME omap_cfg_reg(USB2_SPEED);
>> +                     omap_cfg_reg(USB2_SPEED)
>>       } else {
>>               pr_debug("usb%d cpu unrecognized\n", 1);
>>               return 0;
>> --
>> 1.9.1
>>

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] mach-omap1: Fix call to omap_cfg_reg
@ 2014-07-07 17:40     ` Nick Krause
  0 siblings, 0 replies; 9+ messages in thread
From: Nick Krause @ 2014-07-07 17:40 UTC (permalink / raw)
  To: linux-arm-kernel

Hey Tony,
This seems to be a false positive then.Please reply if it is so I can remove the
Fix me message.
Cheers Nick

On Mon, Jul 7, 2014 at 4:14 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Nicholas Krause <xerofoify@gmail.com> [140704 10:03]:
>> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
>> that the cpu is a omap16xx and the nwires are not equal to 3.
>
> This is most likely unsafe to do as the pin is probably
> shared with some other device and we have to rely for
> the bootloader to do the right thing for the board.
>
> Regards,
>
> Tony
>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  arch/arm/mach-omap1/usb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
>> index 4118db5..17e3139 100644
>> --- a/arch/arm/mach-omap1/usb.c
>> +++ b/arch/arm/mach-omap1/usb.c
>> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
>>               omap_cfg_reg(W9_USB2_TXEN);
>>               omap_cfg_reg(W5_USB2_SE0);
>>               if (nwires != 3)
>> -                     omap_cfg_reg(Y5_USB2_RCV);
>> -             // FIXME omap_cfg_reg(USB2_SPEED);
>> +                     omap_cfg_reg(USB2_SPEED)
>>       } else {
>>               pr_debug("usb%d cpu unrecognized\n", 1);
>>               return 0;
>> --
>> 1.9.1
>>

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] mach-omap1: Fix call to omap_cfg_reg
  2014-07-07 17:40     ` Nick Krause
@ 2014-07-08  8:10       ` Tony Lindgren
  -1 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2014-07-08  8:10 UTC (permalink / raw)
  To: Nick Krause
  Cc: balbi, Russell King - ARM Linux, linux-usb, linux-omap,
	linux-arm-kernel, linux-kernel

* Nick Krause <xerofoify@gmail.com> [140707 10:42]:
> Hey Tony,
> This seems to be a false positive then.Please reply if it is so I can remove the
> Fix me message.

Yes, just replace the FIXME with a comment please.

Regards,

Tony

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] mach-omap1: Fix call to omap_cfg_reg
@ 2014-07-08  8:10       ` Tony Lindgren
  0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2014-07-08  8:10 UTC (permalink / raw)
  To: linux-arm-kernel

* Nick Krause <xerofoify@gmail.com> [140707 10:42]:
> Hey Tony,
> This seems to be a false positive then.Please reply if it is so I can remove the
> Fix me message.

Yes, just replace the FIXME with a comment please.

Regards,

Tony

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-07-08  8:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-04 17:02 [PATCH] mach-omap1: Fix call to omap_cfg_reg Nicholas Krause
2014-07-04 17:02 ` Nicholas Krause
2014-07-07  8:14 ` Tony Lindgren
2014-07-07  8:14   ` Tony Lindgren
2014-07-07  8:14   ` Tony Lindgren
2014-07-07 17:40   ` Nick Krause
2014-07-07 17:40     ` Nick Krause
2014-07-08  8:10     ` Tony Lindgren
2014-07-08  8:10       ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.