From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] socfpga: initialize MMC
Date: Thu, 17 Jul 2014 14:01:20 +0200 [thread overview]
Message-ID: <20140717120120.125DC383374@gemini.denx.de> (raw)
In-Reply-To: <1405594852.2088.8.camel@clsee-VirtualBox.altera.com>
Dear Chin Liang,
In message <1405594852.2088.8.camel@clsee-VirtualBox.altera.com> you wrote:
>
> > > > + add_dwmci(host, host->bus_hz, host->bus_hz);
> > >
> > > Is there a free(host) anywhere?
>
> Actually the host will be referred throughout the code execution when
> SDMMC access is required. Hence, we can only call the free when exit
> which deems not needed then.
I have to admit that I have hard times trying to understand the
concept of behind this code.
1) The new patches add altera_dwmmc_init() - but is this not
basically a verbatim copy of socfpga_dwmmc_init() which is
alreday in mainline?
Except that the new patches use hardcoded constants (which is BAD)
where the current mainline code uses #defines:
altera_dwmmc_init():
host->bus_hz = 400000;
socfpga_dwmmc_init():
host->bus_hz = CONFIG_SOCFPGA_DWMMC_BUS_HZ;
2) Is it really necessary to always and unconditionally initialyze
the MMC subsystem, even in nobody will ever use any MMC commands in
U-Boot? The rule is that we only initialize hardwar when we
actually use them inside of U-Boot, i. e. if any commands are
executed that access such hardware?
[Ok, this seems to be a generic problem, not specific you your
patch set.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The average woman would rather have beauty than brains, because the
average man can see better than he can think.
next prev parent reply other threads:[~2014-07-17 12:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 12:34 [U-Boot] socfpga: initialize MMC Pavel Machek
2014-07-16 12:52 ` Wolfgang Denk
2014-07-16 13:13 ` Wolfgang Denk
2014-07-17 11:00 ` Chin Liang See
2014-07-17 12:01 ` Wolfgang Denk [this message]
2014-07-19 12:03 ` Pavel Machek
2014-07-21 10:20 ` Pavel Machek
2014-07-21 10:50 ` Wolfgang Denk
2014-07-21 12:05 ` Pavel Machek
2014-07-22 9:33 ` Chin Liang See
2014-09-09 13:16 ` [U-Boot] [PATCH] sort drivers/mmc/Makefile Pavel Machek
2014-09-12 7:25 ` Chin Liang See
2014-11-10 21:29 ` [U-Boot] " Tom Rini
2014-07-21 10:30 ` [U-Boot] [PATCH] socfpga: cleanup socfpga_dw_mmc Pavel Machek
2014-07-21 10:49 ` Chin Liang See
2014-07-21 11:30 ` [U-Boot] [PATCHv2] " Pavel Machek
2014-07-22 4:55 ` Chin Liang See
2014-08-30 15:13 ` [U-Boot] [U-Boot,PATCHv2] " Tom Rini
2014-07-22 3:22 ` [U-Boot] socfpga: initialize MMC Jaehoon Chung
2014-07-22 8:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717120120.125DC383374@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.