From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] socfpga: initialize MMC
Date: Mon, 21 Jul 2014 12:50:37 +0200 [thread overview]
Message-ID: <20140721105037.D9A353802AE@gemini.denx.de> (raw)
In-Reply-To: <20140721102004.GA12896@amd.pavel.ucw.cz>
Dear Pavel,
In message <20140721102004.GA12896@amd.pavel.ucw.cz> you wrote:
>
> > > #define SOCFPGA_CLKMGR_ADDRESS 0xffd04000
> > > #define SOCFPGA_RSTMGR_ADDRESS 0xffd05000
> > > #define SOCFPGA_SYSMGR_ADDRESS 0xffd08000
> > > +#define SOCFPGA_SDMMC_ADDRESS 0xff704000
> >
> > Please keep list sorted.
>
> It was sorted by address before, so I'll keep it like that.
Yes, it was sorted by address, and 0xff704000 goes _before_
0xffd08000, not after.
> > > --- a/drivers/mmc/Makefile
> > > +++ b/drivers/mmc/Makefile
> > > @@ -28,6 +28,7 @@ obj-$(CONFIG_SPEAR_SDHCI) += spear_sdhci.o
> > > obj-$(CONFIG_TEGRA_MMC) += tegra_mmc.o
> > > obj-$(CONFIG_DWMMC) += dw_mmc.o
> > > obj-$(CONFIG_EXYNOS_DWMMC) += exynos_dw_mmc.o
> > > +obj-$(CONFIG_ALTERA_DWMMC) += altera_dw_mmc.o
> > > obj-$(CONFIG_MMC_SUNXI) += sunxi_mmc.o
> > > obj-$(CONFIG_ZYNQ_SDHCI) += zynq_sdhci.o
> > > obj-$(CONFIG_SOCFPGA_DWMMC) += socfpga_dw_mmc.o
> >
> > Ditto. This should be a sorted list.
>
> This was not sorted and I will not need to modify it in next patch
> version, so I'll leave this unfixed.
No, please clean up and fix it.
> > Is there a free(host) anywhere?
>
> Dynamic allocation does not make much sense here, agreed. But as it is
> existing code, and there are bigger issues around, I'd prefer to leave
> it to someone else to clean it up...
I tend to disagree. If we do not fix the problems as we see them, and
when we are working on the code anyway, they will never get fixed.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When the bosses talk about improving productivity, they are never
talking about themselves.
next prev parent reply other threads:[~2014-07-21 10:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 12:34 [U-Boot] socfpga: initialize MMC Pavel Machek
2014-07-16 12:52 ` Wolfgang Denk
2014-07-16 13:13 ` Wolfgang Denk
2014-07-17 11:00 ` Chin Liang See
2014-07-17 12:01 ` Wolfgang Denk
2014-07-19 12:03 ` Pavel Machek
2014-07-21 10:20 ` Pavel Machek
2014-07-21 10:50 ` Wolfgang Denk [this message]
2014-07-21 12:05 ` Pavel Machek
2014-07-22 9:33 ` Chin Liang See
2014-09-09 13:16 ` [U-Boot] [PATCH] sort drivers/mmc/Makefile Pavel Machek
2014-09-12 7:25 ` Chin Liang See
2014-11-10 21:29 ` [U-Boot] " Tom Rini
2014-07-21 10:30 ` [U-Boot] [PATCH] socfpga: cleanup socfpga_dw_mmc Pavel Machek
2014-07-21 10:49 ` Chin Liang See
2014-07-21 11:30 ` [U-Boot] [PATCHv2] " Pavel Machek
2014-07-22 4:55 ` Chin Liang See
2014-08-30 15:13 ` [U-Boot] [U-Boot,PATCHv2] " Tom Rini
2014-07-22 3:22 ` [U-Boot] socfpga: initialize MMC Jaehoon Chung
2014-07-22 8:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721105037.D9A353802AE@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.