From: Andrew Lunn <andrew@lunn.ch>
To: Jason Cooper <jason@lakedaemon.net>
Cc: benoitm974 <yahoo@perenite.com>,
benoitm@perenite.com, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>
Subject: Re: [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas
Date: Wed, 23 Jul 2014 16:14:43 +0200 [thread overview]
Message-ID: <20140723141443.GC2856@lunn.ch> (raw)
In-Reply-To: <20140723134534.GF23220@titan.lakedaemon.net>
Hi Benoit,
>
> > + };
> > +
> > + serial@12000 {
> > + clocks = <&coreclk 0>;
I don't think you need the clocks property. It should be already set
in armada-xp.dtsi.
> > + adt7473@2e {
> > + compatible = "adt7473";
Please include a vendor prefix here.
> > + reg = <0x2e>;
> > + };
> > +
> > + pcf8563@51 {
> > + compatible = "pcf8563";
and a vendor prefix here.
> > + /* warning: you need both eth1 & 0 to be initialize for poweroff to shutdown otherwise it reboots */
What do you mean by initialized? Driver loaded? Interface up?
> This is a great first version
I agree with Jason, well done.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Cc: benoitm974 <yahoo-+V3Jd3LB6RBWk0Htik3J/w@public.gmane.org>,
benoitm-+V3Jd3LB6RBWk0Htik3J/w@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Subject: Re: [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas
Date: Wed, 23 Jul 2014 16:14:43 +0200 [thread overview]
Message-ID: <20140723141443.GC2856@lunn.ch> (raw)
In-Reply-To: <20140723134534.GF23220-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
Hi Benoit,
>
> > + };
> > +
> > + serial@12000 {
> > + clocks = <&coreclk 0>;
I don't think you need the clocks property. It should be already set
in armada-xp.dtsi.
> > + adt7473@2e {
> > + compatible = "adt7473";
Please include a vendor prefix here.
> > + reg = <0x2e>;
> > + };
> > +
> > + pcf8563@51 {
> > + compatible = "pcf8563";
and a vendor prefix here.
> > + /* warning: you need both eth1 & 0 to be initialize for poweroff to shutdown otherwise it reboots */
What do you mean by initialized? Driver loaded? Interface up?
> This is a great first version
I agree with Jason, well done.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas
Date: Wed, 23 Jul 2014 16:14:43 +0200 [thread overview]
Message-ID: <20140723141443.GC2856@lunn.ch> (raw)
In-Reply-To: <20140723134534.GF23220@titan.lakedaemon.net>
Hi Benoit,
>
> > + };
> > +
> > + serial at 12000 {
> > + clocks = <&coreclk 0>;
I don't think you need the clocks property. It should be already set
in armada-xp.dtsi.
> > + adt7473 at 2e {
> > + compatible = "adt7473";
Please include a vendor prefix here.
> > + reg = <0x2e>;
> > + };
> > +
> > + pcf8563 at 51 {
> > + compatible = "pcf8563";
and a vendor prefix here.
> > + /* warning: you need both eth1 & 0 to be initialize for poweroff to shutdown otherwise it reboots */
What do you mean by initialized? Driver loaded? Interface up?
> This is a great first version
I agree with Jason, well done.
Andrew
next prev parent reply other threads:[~2014-07-23 14:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 12:07 [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas benoitm974
2014-07-23 12:07 ` benoitm974
2014-07-23 12:07 ` [PATCH 2/2] Adding lenovo in vendor benoitm974
2014-07-23 12:07 ` benoitm974
2014-07-23 13:47 ` Jason Cooper
2014-07-23 13:47 ` Jason Cooper
2014-07-23 13:47 ` Jason Cooper
2014-07-23 15:10 ` Andrew Lunn
2014-07-23 15:10 ` Andrew Lunn
2014-07-23 15:10 ` Andrew Lunn
2014-07-23 17:26 ` Jason Cooper
2014-07-23 17:26 ` Jason Cooper
2014-07-23 21:03 ` Benoit Masson
2014-07-23 21:03 ` Benoit Masson
2014-07-23 21:03 ` Benoit Masson
2014-07-23 13:45 ` [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas Jason Cooper
2014-07-23 13:45 ` Jason Cooper
2014-07-23 13:45 ` Jason Cooper
2014-07-23 14:14 ` Andrew Lunn [this message]
2014-07-23 14:14 ` Andrew Lunn
2014-07-23 14:14 ` Andrew Lunn
2014-07-23 15:52 ` Benoit Masson
2014-07-23 15:52 ` Benoit Masson
2014-07-23 16:49 ` Andrew Lunn
2014-07-23 16:49 ` Andrew Lunn
2014-07-23 21:15 ` Benoit Masson
2014-07-23 21:15 ` Benoit Masson
2014-07-23 21:15 ` Benoit Masson
2014-07-23 22:26 ` Andrew Lunn
2014-07-23 22:26 ` Andrew Lunn
2014-07-23 23:26 ` Benoit Masson
2014-07-23 23:26 ` Benoit Masson
2014-07-23 15:45 ` Sebastian Hesselbarth
2014-07-23 15:45 ` Sebastian Hesselbarth
2014-07-23 15:45 ` Sebastian Hesselbarth
2014-07-23 13:49 ` Jason Cooper
2014-07-23 13:49 ` Jason Cooper
2014-07-23 13:49 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723141443.GC2856@lunn.ch \
--to=andrew@lunn.ch \
--cc=benoitm@perenite.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@googlemail.com \
--cc=yahoo@perenite.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.