All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Benoit Masson <benoitm@perenite.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
	benoitm974 <yahoo@perenite.com>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>
Subject: Re: [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas
Date: Thu, 24 Jul 2014 00:26:40 +0200	[thread overview]
Message-ID: <20140723222640.GA28485@lunn.ch> (raw)
In-Reply-To: <9AE6F1AD-9296-47E9-91E2-9E34AA48EBB4@perenite.com>

> Both phy are :
> marvell,88e1318

I don't have the datasheet for this specific phy model, but i do have
the datasheet for another similar phy.
 
> example of a minimal reg write that lead MPP24 to shutdown instead
> of rebooting on original BSP driver

> XXXXX BasicInit

I'm assuming regOffs is decimal, and data is hex?

> phyAdr 0: regOffs: 16 data: 3

Copper Specific control register. 3 means Polarity Reversal Disable &
Jabber function disable.

> phyAdr 0: regOffs: 10 data: 830

Reg 10 is the 1000BASE-T Status register, which is read only!

So this is not making much sense. Are we missing some changes to the
page register? Register 16 of page 3 is the LED control register.

     Andrew


WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas
Date: Thu, 24 Jul 2014 00:26:40 +0200	[thread overview]
Message-ID: <20140723222640.GA28485@lunn.ch> (raw)
In-Reply-To: <9AE6F1AD-9296-47E9-91E2-9E34AA48EBB4@perenite.com>

> Both phy are :
> marvell,88e1318

I don't have the datasheet for this specific phy model, but i do have
the datasheet for another similar phy.
 
> example of a minimal reg write that lead MPP24 to shutdown instead
> of rebooting on original BSP driver

> XXXXX BasicInit

I'm assuming regOffs is decimal, and data is hex?

> phyAdr 0: regOffs: 16 data: 3

Copper Specific control register. 3 means Polarity Reversal Disable &
Jabber function disable.

> phyAdr 0: regOffs: 10 data: 830

Reg 10 is the 1000BASE-T Status register, which is read only!

So this is not making much sense. Are we missing some changes to the
page register? Register 16 of page 3 is the LED control register.

     Andrew

  reply	other threads:[~2014-07-23 22:31 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 12:07 [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas benoitm974
2014-07-23 12:07 ` benoitm974
2014-07-23 12:07 ` [PATCH 2/2] Adding lenovo in vendor benoitm974
2014-07-23 12:07   ` benoitm974
2014-07-23 13:47   ` Jason Cooper
2014-07-23 13:47     ` Jason Cooper
2014-07-23 13:47     ` Jason Cooper
2014-07-23 15:10     ` Andrew Lunn
2014-07-23 15:10       ` Andrew Lunn
2014-07-23 15:10       ` Andrew Lunn
2014-07-23 17:26       ` Jason Cooper
2014-07-23 17:26         ` Jason Cooper
2014-07-23 21:03         ` Benoit Masson
2014-07-23 21:03           ` Benoit Masson
2014-07-23 21:03           ` Benoit Masson
2014-07-23 13:45 ` [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas Jason Cooper
2014-07-23 13:45   ` Jason Cooper
2014-07-23 13:45   ` Jason Cooper
2014-07-23 14:14   ` Andrew Lunn
2014-07-23 14:14     ` Andrew Lunn
2014-07-23 14:14     ` Andrew Lunn
2014-07-23 15:52     ` Benoit Masson
2014-07-23 15:52       ` Benoit Masson
2014-07-23 16:49       ` Andrew Lunn
2014-07-23 16:49         ` Andrew Lunn
2014-07-23 21:15         ` Benoit Masson
2014-07-23 21:15           ` Benoit Masson
2014-07-23 21:15           ` Benoit Masson
2014-07-23 22:26           ` Andrew Lunn [this message]
2014-07-23 22:26             ` Andrew Lunn
2014-07-23 23:26             ` Benoit Masson
2014-07-23 23:26               ` Benoit Masson
2014-07-23 15:45   ` Sebastian Hesselbarth
2014-07-23 15:45     ` Sebastian Hesselbarth
2014-07-23 15:45     ` Sebastian Hesselbarth
2014-07-23 13:49 ` Jason Cooper
2014-07-23 13:49   ` Jason Cooper
2014-07-23 13:49   ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140723222640.GA28485@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=benoitm@perenite.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@googlemail.com \
    --cc=yahoo@perenite.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.