All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kishon@ti.com,
	kgene.kim@samsung.com, maxime.ripard@free-electrons.com,
	linux-samsung-soc@vger.kernel.org, lee.jones@linaro.org,
	patches@linaro.org
Subject: Re: [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc
Date: Fri, 15 Aug 2014 15:10:26 +0200	[thread overview]
Message-ID: <20140815131026.GA17800@lunn.ch> (raw)
In-Reply-To: <1408106416-19044-3-git-send-email-peter.griffin@linaro.org>

On Fri, Aug 15, 2014 at 01:40:09PM +0100, Peter Griffin wrote:
> Currently this driver is missing a check on the return value of devm_kzalloc,
> which would cause a NULL pointer dereference in a OOM situation.
> 
> This patch adds the aformentioned missing check.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

Acked-by: Andrew Lunn <andrew@lunn.ch>

Thanks
	Andrew

> ---
>  drivers/phy/phy-mvebu-sata.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/phy-mvebu-sata.c b/drivers/phy/phy-mvebu-sata.c
> index cc3c0e1..10bb8e5 100644
> --- a/drivers/phy/phy-mvebu-sata.c
> +++ b/drivers/phy/phy-mvebu-sata.c
> @@ -89,6 +89,8 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev)
>  	struct phy *phy;
>  
>  	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	priv->base = devm_ioremap_resource(&pdev->dev, res);
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc
Date: Fri, 15 Aug 2014 15:10:26 +0200	[thread overview]
Message-ID: <20140815131026.GA17800@lunn.ch> (raw)
In-Reply-To: <1408106416-19044-3-git-send-email-peter.griffin@linaro.org>

On Fri, Aug 15, 2014 at 01:40:09PM +0100, Peter Griffin wrote:
> Currently this driver is missing a check on the return value of devm_kzalloc,
> which would cause a NULL pointer dereference in a OOM situation.
> 
> This patch adds the aformentioned missing check.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

Acked-by: Andrew Lunn <andrew@lunn.ch>

Thanks
	Andrew

> ---
>  drivers/phy/phy-mvebu-sata.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/phy-mvebu-sata.c b/drivers/phy/phy-mvebu-sata.c
> index cc3c0e1..10bb8e5 100644
> --- a/drivers/phy/phy-mvebu-sata.c
> +++ b/drivers/phy/phy-mvebu-sata.c
> @@ -89,6 +89,8 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev)
>  	struct phy *phy;
>  
>  	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	priv->base = devm_ioremap_resource(&pdev->dev, res);
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2014-08-15 13:16 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
2014-08-15 12:40 ` Peter Griffin
2014-08-15 12:40 ` [PATCH 1/9] phy: phy-omap-control: Remove unncessary site specific OOM messages Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 13:10   ` Andrew Lunn [this message]
2014-08-15 13:10     ` Andrew Lunn
2014-08-15 12:40 ` [PATCH 3/9] phy: phy-omap-usb2: Remove unncessary site specific OOM messages Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 4/9] phy: phy-ti-pipe3: " Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 5/9] phy: phy-spear1310-miphy: " Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 6/9] phy: phy-spear1340-miphy: " Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-09-17 16:19   ` Kishon Vijay Abraham I
2014-09-17 16:19     ` Kishon Vijay Abraham I
2014-09-17 16:19     ` Kishon Vijay Abraham I
2014-09-17 19:04     ` Peter Griffin
2014-09-17 19:04       ` Peter Griffin
2014-09-18  5:32       ` Kishon Vijay Abraham I
2014-09-18  5:32         ` Kishon Vijay Abraham I
2014-09-18  5:32         ` Kishon Vijay Abraham I
2014-08-15 12:40 ` [PATCH 8/9] phy: phy-spear1310-miphy: Use module_platform_driver to register driver Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 9/9] phy: phy-spear1340-miphy: " Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-20 15:03 ` [PATCH 0/9] phy: various misc cleanups to phy drivers Kishon Vijay Abraham I
2014-08-20 15:03   ` Kishon Vijay Abraham I
2014-08-20 15:03   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140815131026.GA17800@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=kgene.kim@samsung.com \
    --cc=kishon@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=patches@linaro.org \
    --cc=peter.griffin@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.