All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Peter Griffin <peter.griffin@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <kgene.kim@samsung.com>,
	<maxime.ripard@free-electrons.com>,
	<linux-samsung-soc@vger.kernel.org>
Cc: <patches@linaro.org>, <lee.jones@linaro.org>
Subject: Re: [PATCH 0/9] phy: various misc cleanups to phy drivers
Date: Wed, 20 Aug 2014 20:33:42 +0530	[thread overview]
Message-ID: <53F4B8CE.50300@ti.com> (raw)
In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org>

Hi,

On Friday 15 August 2014 06:10 PM, Peter Griffin wrote:
> Hi,
> 
> This series some a few misc cleanups to the PHY drivers: -
> 
> 1) Use module_platform_driver to register spear PHY drivers. This gets rid
> of a lof of boiler plate code.
> 
> 2) Remove .owner field from drivers using module_platform_driver, as this gets
> overridden anyway in __platform_driver_register.
> 
> 3) Remove OOM site specific failure messages. These are unecessary and make
> the kernel bigger.
> 
> 4) Add missing kzalloc error check, which could avoid NULL ptr dereference.

Thanks for doing this clean-up.
But I can queue this only for 3.18 (since these are cleanups) after -rc4 is tagged.

Thanks
Kishon

> 
> regards,
> 
> Peter.
> 
> Peter Griffin (9):
>   phy: phy-omap-control: Remove unncessary site specific OOM messages
>   phy: phy-mvebu-sata: Add missing error check for devm_kzalloc
>   phy: phy-omap-usb2: Remove unncessary site specific OOM messages
>   phy: phy-ti-pipe3: Remove unncessary site specific OOM messages
>   phy: phy-spear1310-miphy: Remove unncessary site specific OOM messages
>   phy: phy-spear1340-miphy: Remove unncessary site specific OOM messages
>   phy: remove .owner field for drivers using module_platform_driver
>   phy: phy-spear1310-miphy: Use module_platform_driver to register
>     driver.
>   phy: phy-spear1340-miphy: Use module_platform_driver to register
>     driver.
> 
>  drivers/phy/phy-bcm-kona-usb2.c     |  1 -
>  drivers/phy/phy-berlin-sata.c       |  1 -
>  drivers/phy/phy-exynos-dp-video.c   |  1 -
>  drivers/phy/phy-exynos-mipi-video.c |  1 -
>  drivers/phy/phy-exynos5-usbdrd.c    |  1 -
>  drivers/phy/phy-exynos5250-sata.c   |  1 -
>  drivers/phy/phy-hix5hd2-sata.c      |  1 -
>  drivers/phy/phy-miphy365x.c         |  1 -
>  drivers/phy/phy-mvebu-sata.c        |  3 ++-
>  drivers/phy/phy-omap-control.c      |  5 +----
>  drivers/phy/phy-omap-usb2.c         |  9 ++-------
>  drivers/phy/phy-qcom-apq8064-sata.c |  1 -
>  drivers/phy/phy-qcom-ipq806x-sata.c |  1 -
>  drivers/phy/phy-samsung-usb2.c      |  1 -
>  drivers/phy/phy-spear1310-miphy.c   | 17 ++---------------
>  drivers/phy/phy-spear1340-miphy.c   | 17 ++---------------
>  drivers/phy/phy-sun4i-usb.c         |  1 -
>  drivers/phy/phy-ti-pipe3.c          |  6 ++----
>  drivers/phy/phy-twl4030-usb.c       |  1 -
>  drivers/phy/phy-xgene.c             |  1 -
>  20 files changed, 11 insertions(+), 60 deletions(-)
> 

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Peter Griffin <peter.griffin@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kgene.kim@samsung.com,
	maxime.ripard@free-electrons.com,
	linux-samsung-soc@vger.kernel.org
Cc: patches@linaro.org, lee.jones@linaro.org
Subject: Re: [PATCH 0/9] phy: various misc cleanups to phy drivers
Date: Wed, 20 Aug 2014 20:33:42 +0530	[thread overview]
Message-ID: <53F4B8CE.50300@ti.com> (raw)
In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org>

Hi,

On Friday 15 August 2014 06:10 PM, Peter Griffin wrote:
> Hi,
> 
> This series some a few misc cleanups to the PHY drivers: -
> 
> 1) Use module_platform_driver to register spear PHY drivers. This gets rid
> of a lof of boiler plate code.
> 
> 2) Remove .owner field from drivers using module_platform_driver, as this gets
> overridden anyway in __platform_driver_register.
> 
> 3) Remove OOM site specific failure messages. These are unecessary and make
> the kernel bigger.
> 
> 4) Add missing kzalloc error check, which could avoid NULL ptr dereference.

Thanks for doing this clean-up.
But I can queue this only for 3.18 (since these are cleanups) after -rc4 is tagged.

Thanks
Kishon

> 
> regards,
> 
> Peter.
> 
> Peter Griffin (9):
>   phy: phy-omap-control: Remove unncessary site specific OOM messages
>   phy: phy-mvebu-sata: Add missing error check for devm_kzalloc
>   phy: phy-omap-usb2: Remove unncessary site specific OOM messages
>   phy: phy-ti-pipe3: Remove unncessary site specific OOM messages
>   phy: phy-spear1310-miphy: Remove unncessary site specific OOM messages
>   phy: phy-spear1340-miphy: Remove unncessary site specific OOM messages
>   phy: remove .owner field for drivers using module_platform_driver
>   phy: phy-spear1310-miphy: Use module_platform_driver to register
>     driver.
>   phy: phy-spear1340-miphy: Use module_platform_driver to register
>     driver.
> 
>  drivers/phy/phy-bcm-kona-usb2.c     |  1 -
>  drivers/phy/phy-berlin-sata.c       |  1 -
>  drivers/phy/phy-exynos-dp-video.c   |  1 -
>  drivers/phy/phy-exynos-mipi-video.c |  1 -
>  drivers/phy/phy-exynos5-usbdrd.c    |  1 -
>  drivers/phy/phy-exynos5250-sata.c   |  1 -
>  drivers/phy/phy-hix5hd2-sata.c      |  1 -
>  drivers/phy/phy-miphy365x.c         |  1 -
>  drivers/phy/phy-mvebu-sata.c        |  3 ++-
>  drivers/phy/phy-omap-control.c      |  5 +----
>  drivers/phy/phy-omap-usb2.c         |  9 ++-------
>  drivers/phy/phy-qcom-apq8064-sata.c |  1 -
>  drivers/phy/phy-qcom-ipq806x-sata.c |  1 -
>  drivers/phy/phy-samsung-usb2.c      |  1 -
>  drivers/phy/phy-spear1310-miphy.c   | 17 ++---------------
>  drivers/phy/phy-spear1340-miphy.c   | 17 ++---------------
>  drivers/phy/phy-sun4i-usb.c         |  1 -
>  drivers/phy/phy-ti-pipe3.c          |  6 ++----
>  drivers/phy/phy-twl4030-usb.c       |  1 -
>  drivers/phy/phy-xgene.c             |  1 -
>  20 files changed, 11 insertions(+), 60 deletions(-)
> 

WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/9] phy: various misc cleanups to phy drivers
Date: Wed, 20 Aug 2014 20:33:42 +0530	[thread overview]
Message-ID: <53F4B8CE.50300@ti.com> (raw)
In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org>

Hi,

On Friday 15 August 2014 06:10 PM, Peter Griffin wrote:
> Hi,
> 
> This series some a few misc cleanups to the PHY drivers: -
> 
> 1) Use module_platform_driver to register spear PHY drivers. This gets rid
> of a lof of boiler plate code.
> 
> 2) Remove .owner field from drivers using module_platform_driver, as this gets
> overridden anyway in __platform_driver_register.
> 
> 3) Remove OOM site specific failure messages. These are unecessary and make
> the kernel bigger.
> 
> 4) Add missing kzalloc error check, which could avoid NULL ptr dereference.

Thanks for doing this clean-up.
But I can queue this only for 3.18 (since these are cleanups) after -rc4 is tagged.

Thanks
Kishon

> 
> regards,
> 
> Peter.
> 
> Peter Griffin (9):
>   phy: phy-omap-control: Remove unncessary site specific OOM messages
>   phy: phy-mvebu-sata: Add missing error check for devm_kzalloc
>   phy: phy-omap-usb2: Remove unncessary site specific OOM messages
>   phy: phy-ti-pipe3: Remove unncessary site specific OOM messages
>   phy: phy-spear1310-miphy: Remove unncessary site specific OOM messages
>   phy: phy-spear1340-miphy: Remove unncessary site specific OOM messages
>   phy: remove .owner field for drivers using module_platform_driver
>   phy: phy-spear1310-miphy: Use module_platform_driver to register
>     driver.
>   phy: phy-spear1340-miphy: Use module_platform_driver to register
>     driver.
> 
>  drivers/phy/phy-bcm-kona-usb2.c     |  1 -
>  drivers/phy/phy-berlin-sata.c       |  1 -
>  drivers/phy/phy-exynos-dp-video.c   |  1 -
>  drivers/phy/phy-exynos-mipi-video.c |  1 -
>  drivers/phy/phy-exynos5-usbdrd.c    |  1 -
>  drivers/phy/phy-exynos5250-sata.c   |  1 -
>  drivers/phy/phy-hix5hd2-sata.c      |  1 -
>  drivers/phy/phy-miphy365x.c         |  1 -
>  drivers/phy/phy-mvebu-sata.c        |  3 ++-
>  drivers/phy/phy-omap-control.c      |  5 +----
>  drivers/phy/phy-omap-usb2.c         |  9 ++-------
>  drivers/phy/phy-qcom-apq8064-sata.c |  1 -
>  drivers/phy/phy-qcom-ipq806x-sata.c |  1 -
>  drivers/phy/phy-samsung-usb2.c      |  1 -
>  drivers/phy/phy-spear1310-miphy.c   | 17 ++---------------
>  drivers/phy/phy-spear1340-miphy.c   | 17 ++---------------
>  drivers/phy/phy-sun4i-usb.c         |  1 -
>  drivers/phy/phy-ti-pipe3.c          |  6 ++----
>  drivers/phy/phy-twl4030-usb.c       |  1 -
>  drivers/phy/phy-xgene.c             |  1 -
>  20 files changed, 11 insertions(+), 60 deletions(-)
> 

  parent reply	other threads:[~2014-08-20 15:04 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15 12:40 [PATCH 0/9] phy: various misc cleanups to phy drivers Peter Griffin
2014-08-15 12:40 ` Peter Griffin
2014-08-15 12:40 ` [PATCH 1/9] phy: phy-omap-control: Remove unncessary site specific OOM messages Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 2/9] phy: phy-mvebu-sata: Add missing error check for devm_kzalloc Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 13:10   ` Andrew Lunn
2014-08-15 13:10     ` Andrew Lunn
2014-08-15 12:40 ` [PATCH 3/9] phy: phy-omap-usb2: Remove unncessary site specific OOM messages Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 4/9] phy: phy-ti-pipe3: " Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 5/9] phy: phy-spear1310-miphy: " Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 6/9] phy: phy-spear1340-miphy: " Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-09-17 16:19   ` Kishon Vijay Abraham I
2014-09-17 16:19     ` Kishon Vijay Abraham I
2014-09-17 16:19     ` Kishon Vijay Abraham I
2014-09-17 19:04     ` Peter Griffin
2014-09-17 19:04       ` Peter Griffin
2014-09-18  5:32       ` Kishon Vijay Abraham I
2014-09-18  5:32         ` Kishon Vijay Abraham I
2014-09-18  5:32         ` Kishon Vijay Abraham I
2014-08-15 12:40 ` [PATCH 8/9] phy: phy-spear1310-miphy: Use module_platform_driver to register driver Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-15 12:40 ` [PATCH 9/9] phy: phy-spear1340-miphy: " Peter Griffin
2014-08-15 12:40   ` Peter Griffin
2014-08-20 15:03 ` Kishon Vijay Abraham I [this message]
2014-08-20 15:03   ` [PATCH 0/9] phy: various misc cleanups to phy drivers Kishon Vijay Abraham I
2014-08-20 15:03   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F4B8CE.50300@ti.com \
    --to=kishon@ti.com \
    --cc=kgene.kim@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=patches@linaro.org \
    --cc=peter.griffin@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.