From: Brian Norris <computersforpeace@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: Boris BREZILLON <boris.brezillon@free-electrons.com>,
Huang Shijie <shijie.huang@intel.com>,
Mike Voytovich <mvoytovich@paypal.com>,
linux-kernel@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org, Roy Lee <roylee@paypal.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: gpmi: add proper raw access support
Date: Sat, 13 Sep 2014 10:38:41 -0700 [thread overview]
Message-ID: <20140913173841.GA18093@brian-ubuntu> (raw)
In-Reply-To: <20140913153622.GA10132@localhost.localdomain>
On Sat, Sep 13, 2014 at 11:36:24PM +0800, Huang Shijie wrote:
> On Fri, Sep 12, 2014 at 02:30:50PM +0200, Boris BREZILLON wrote:
> > This test validates what's returned by ecc_strength file in sysfs
> > (which in turn is specified by the NAND controller when initializing
> > the NAND chip).
> >
> > Doing this should not imply knowing the ECC algorithm in use in the
> > NAND controller or the layout used to store data on NAND.
> the difficulty is that the ECC parity area can be not byte aligned.
Is there a problem with just rounding up to the nearest byte alignment
and ignoring the few bits that are wasted?
> As I ever said, it is hard to implement the two hooks.
"Hard" doesn't mean we shouldn't. I really would like to encourage more
NAND drivers to be programmed against the expected MTD behavior -- that
(if possible with the given hardware) they can pass the MTD tests
(drivers/mtd/tests/*).
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: Boris BREZILLON <boris.brezillon@free-electrons.com>,
Mike Voytovich <mvoytovich@paypal.com>,
linux-kernel@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org, Roy Lee <roylee@paypal.com>,
Huang Shijie <shijie.huang@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: gpmi: add proper raw access support
Date: Sat, 13 Sep 2014 10:38:41 -0700 [thread overview]
Message-ID: <20140913173841.GA18093@brian-ubuntu> (raw)
In-Reply-To: <20140913153622.GA10132@localhost.localdomain>
On Sat, Sep 13, 2014 at 11:36:24PM +0800, Huang Shijie wrote:
> On Fri, Sep 12, 2014 at 02:30:50PM +0200, Boris BREZILLON wrote:
> > This test validates what's returned by ecc_strength file in sysfs
> > (which in turn is specified by the NAND controller when initializing
> > the NAND chip).
> >
> > Doing this should not imply knowing the ECC algorithm in use in the
> > NAND controller or the layout used to store data on NAND.
> the difficulty is that the ECC parity area can be not byte aligned.
Is there a problem with just rounding up to the nearest byte alignment
and ignoring the few bits that are wasted?
> As I ever said, it is hard to implement the two hooks.
"Hard" doesn't mean we shouldn't. I really would like to encourage more
NAND drivers to be programmed against the expected MTD behavior -- that
(if possible with the given hardware) they can pass the MTD tests
(drivers/mtd/tests/*).
Brian
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: gpmi: add proper raw access support
Date: Sat, 13 Sep 2014 10:38:41 -0700 [thread overview]
Message-ID: <20140913173841.GA18093@brian-ubuntu> (raw)
In-Reply-To: <20140913153622.GA10132@localhost.localdomain>
On Sat, Sep 13, 2014 at 11:36:24PM +0800, Huang Shijie wrote:
> On Fri, Sep 12, 2014 at 02:30:50PM +0200, Boris BREZILLON wrote:
> > This test validates what's returned by ecc_strength file in sysfs
> > (which in turn is specified by the NAND controller when initializing
> > the NAND chip).
> >
> > Doing this should not imply knowing the ECC algorithm in use in the
> > NAND controller or the layout used to store data on NAND.
> the difficulty is that the ECC parity area can be not byte aligned.
Is there a problem with just rounding up to the nearest byte alignment
and ignoring the few bits that are wasted?
> As I ever said, it is hard to implement the two hooks.
"Hard" doesn't mean we shouldn't. I really would like to encourage more
NAND drivers to be programmed against the expected MTD behavior -- that
(if possible with the given hardware) they can pass the MTD tests
(drivers/mtd/tests/*).
Brian
next prev parent reply other threads:[~2014-09-13 17:38 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 8:55 [PATCH] mtd: nand: gpmi: add proper raw access support Boris BREZILLON
2014-09-10 8:55 ` Boris BREZILLON
2014-09-10 8:55 ` Boris BREZILLON
2014-09-11 12:09 ` Huang Shijie
2014-09-11 12:09 ` Huang Shijie
2014-09-11 12:09 ` Huang Shijie
2014-09-11 12:36 ` Boris BREZILLON
2014-09-11 12:36 ` Boris BREZILLON
2014-09-11 12:36 ` Boris BREZILLON
2014-09-11 14:25 ` Huang Shijie
2014-09-11 14:25 ` Huang Shijie
2014-09-11 14:25 ` Huang Shijie
2014-09-11 14:38 ` Boris BREZILLON
2014-09-11 14:38 ` Boris BREZILLON
2014-09-11 14:38 ` Boris BREZILLON
2014-09-12 0:45 ` Huang Shijie
2014-09-12 0:45 ` Huang Shijie
2014-09-12 0:45 ` Huang Shijie
2014-09-12 12:30 ` Boris BREZILLON
2014-09-12 12:30 ` Boris BREZILLON
2014-09-12 12:30 ` Boris BREZILLON
2014-09-13 15:36 ` Huang Shijie
2014-09-13 15:36 ` Huang Shijie
2014-09-13 15:36 ` Huang Shijie
2014-09-13 17:38 ` Brian Norris [this message]
2014-09-13 17:38 ` Brian Norris
2014-09-13 17:38 ` Brian Norris
2014-09-14 14:07 ` Boris BREZILLON
2014-09-14 14:07 ` Boris BREZILLON
2014-09-14 14:07 ` Boris BREZILLON
2014-09-15 14:43 ` Huang Shijie
2014-09-15 14:43 ` Huang Shijie
2014-09-15 14:43 ` Huang Shijie
2014-09-15 20:12 ` Boris BREZILLON
2014-09-15 20:12 ` Boris BREZILLON
2014-09-15 20:12 ` Boris BREZILLON
2014-09-17 15:26 ` Huang Shijie
2014-09-17 15:26 ` Huang Shijie
2014-09-17 15:26 ` Huang Shijie
2014-09-17 18:16 ` Boris BREZILLON
2014-09-17 18:16 ` Boris BREZILLON
2014-09-17 18:16 ` Boris BREZILLON
2014-09-29 1:22 ` Iwo Mergler
2014-09-29 1:22 ` Iwo Mergler
2014-09-29 1:22 ` Iwo Mergler
2014-09-30 8:04 ` Boris Brezillon
2014-09-30 8:04 ` Boris Brezillon
2014-09-30 8:04 ` Boris Brezillon
2014-10-02 6:52 ` Iwo Mergler
2014-10-02 6:52 ` Iwo Mergler
2014-10-02 6:52 ` Iwo Mergler
2014-09-11 14:29 ` Huang Shijie
2014-09-11 14:29 ` Huang Shijie
2014-09-11 14:29 ` Huang Shijie
2014-09-11 14:45 ` Boris BREZILLON
2014-09-11 14:45 ` Boris BREZILLON
2014-09-11 14:45 ` Boris BREZILLON
2014-09-12 0:40 ` Huang Shijie
2014-09-12 0:40 ` Huang Shijie
2014-09-12 0:40 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140913173841.GA18093@brian-ubuntu \
--to=computersforpeace@gmail.com \
--cc=b32955@freescale.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mvoytovich@paypal.com \
--cc=roylee@paypal.com \
--cc=shijie.huang@intel.com \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.