All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<sebastian.hesselbarth@gmail.com>, <Peter.Chen@freescale.com>,
	<balbi@ti.com>, <p.zabel@pengutronix.de>,
	<thomas.petazzoni@free-electrons.com>, <zmxu@marvell.com>,
	<devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<alexandre.belloni@free-electrons.com>, <jszhang@marvell.com>
Subject: Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Tue, 23 Sep 2014 11:55:15 -0500	[thread overview]
Message-ID: <20140923165515.GA26604@saruman> (raw)
In-Reply-To: <5140494.LzvyOiyY3U@wuerfel>

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

HI,

On Tue, Sep 23, 2014 at 06:44:40PM +0200, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 15:36:45 Antoine Tenart wrote:
> > On Tue, Sep 23, 2014 at 12:39:04PM +0200, Arnd Bergmann wrote:
> > > On Tuesday 23 September 2014 12:28:03 Antoine Tenart wrote:
> > > > +       if (dev->of_node) {
> > > > +               ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata);
> > > > +               if (ret)
> > > > +                       goto clk_err;
> > > > +       } else {
> > > > +               ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> > > > +               if (ret)
> > > > +                       goto clk_err;
> > > > +       }
> > > > 
> > > 
> > > Why do you care about the non-DT case here? I think it would be nicer to
> > > open-code the ci_hdrc_usb2_dt_probe() function in here and remove
> > > the dma_set_mask_and_coherent(), which should not even be necessary for
> > > the case where you have a hardwired platform device.
> > > 
> > 
> > I thought we agreed to call dma_set_mask_and_coherent():
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/273335.html
> > 
> > I do not have a strong opinion on this as I only use the dt case for my
> > usage.
> 
> The question is more about who actually wants the non-DT case.
> 
> Since this is a new driver, I suspect that the answer is "nobody",
> as the existing board files are all for legacy platforms that we
> are not going to adapt for this driver.

wait a minute... will the legacy platforms be adapted to DT and, thus,
to this driver in the future ? I really don't want to keep several
copies of chipidea driver just because there are still some legacy
platforms still using them. I have said in the past and will say again,
everybody should move to the generic chipidea driver at the earliest
opportunity so we avoid duplication of work.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Antoine Tenart
	<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Peter.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Tue, 23 Sep 2014 11:55:15 -0500	[thread overview]
Message-ID: <20140923165515.GA26604@saruman> (raw)
In-Reply-To: <5140494.LzvyOiyY3U@wuerfel>

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

HI,

On Tue, Sep 23, 2014 at 06:44:40PM +0200, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 15:36:45 Antoine Tenart wrote:
> > On Tue, Sep 23, 2014 at 12:39:04PM +0200, Arnd Bergmann wrote:
> > > On Tuesday 23 September 2014 12:28:03 Antoine Tenart wrote:
> > > > +       if (dev->of_node) {
> > > > +               ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata);
> > > > +               if (ret)
> > > > +                       goto clk_err;
> > > > +       } else {
> > > > +               ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> > > > +               if (ret)
> > > > +                       goto clk_err;
> > > > +       }
> > > > 
> > > 
> > > Why do you care about the non-DT case here? I think it would be nicer to
> > > open-code the ci_hdrc_usb2_dt_probe() function in here and remove
> > > the dma_set_mask_and_coherent(), which should not even be necessary for
> > > the case where you have a hardwired platform device.
> > > 
> > 
> > I thought we agreed to call dma_set_mask_and_coherent():
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/273335.html
> > 
> > I do not have a strong opinion on this as I only use the dt case for my
> > usage.
> 
> The question is more about who actually wants the non-DT case.
> 
> Since this is a new driver, I suspect that the answer is "nobody",
> as the existing board files are all for legacy platforms that we
> are not going to adapt for this driver.

wait a minute... will the legacy platforms be adapted to DT and, thus,
to this driver in the future ? I really don't want to keep several
copies of chipidea driver just because there are still some legacy
platforms still using them. I have said in the past and will say again,
everybody should move to the generic chipidea driver at the earliest
opportunity so we avoid duplication of work.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Tue, 23 Sep 2014 11:55:15 -0500	[thread overview]
Message-ID: <20140923165515.GA26604@saruman> (raw)
In-Reply-To: <5140494.LzvyOiyY3U@wuerfel>

HI,

On Tue, Sep 23, 2014 at 06:44:40PM +0200, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 15:36:45 Antoine Tenart wrote:
> > On Tue, Sep 23, 2014 at 12:39:04PM +0200, Arnd Bergmann wrote:
> > > On Tuesday 23 September 2014 12:28:03 Antoine Tenart wrote:
> > > > +       if (dev->of_node) {
> > > > +               ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata);
> > > > +               if (ret)
> > > > +                       goto clk_err;
> > > > +       } else {
> > > > +               ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> > > > +               if (ret)
> > > > +                       goto clk_err;
> > > > +       }
> > > > 
> > > 
> > > Why do you care about the non-DT case here? I think it would be nicer to
> > > open-code the ci_hdrc_usb2_dt_probe() function in here and remove
> > > the dma_set_mask_and_coherent(), which should not even be necessary for
> > > the case where you have a hardwired platform device.
> > > 
> > 
> > I thought we agreed to call dma_set_mask_and_coherent():
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/273335.html
> > 
> > I do not have a strong opinion on this as I only use the dt case for my
> > usage.
> 
> The question is more about who actually wants the non-DT case.
> 
> Since this is a new driver, I suspect that the answer is "nobody",
> as the existing board files are all for legacy platforms that we
> are not going to adapt for this driver.

wait a minute... will the legacy platforms be adapted to DT and, thus,
to this driver in the future ? I really don't want to keep several
copies of chipidea driver just because there are still some legacy
platforms still using them. I have said in the past and will say again,
everybody should move to the generic chipidea driver at the earliest
opportunity so we avoid duplication of work.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140923/c517e821/attachment.sig>

  reply	other threads:[~2014-09-23 16:56 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 10:27 [PATCH v6 00/12] ARM: berlin: USB support Antoine Tenart
2014-09-23 10:27 ` Antoine Tenart
2014-09-23 10:27 ` Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 01/12] reset: add the Berlin reset controller driver Antoine Tenart
2014-09-23 10:27   ` Antoine Tenart
2014-09-23 10:27   ` Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Tenart
2014-09-23 10:27   ` Antoine Tenart
2014-09-23 10:27   ` Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 03/12] ARM: Berlin: select the reset controller Antoine Tenart
2014-09-23 10:27   ` Antoine Tenart
2014-09-23 10:27   ` Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 05/12] phy: add the Berlin USB PHY driver Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:39   ` Arnd Bergmann
2014-09-23 10:39     ` Arnd Bergmann
2014-09-23 10:39     ` Arnd Bergmann
2014-09-23 13:36     ` Antoine Tenart
2014-09-23 13:36       ` Antoine Tenart
2014-09-23 13:36       ` Antoine Tenart
2014-09-23 16:44       ` Arnd Bergmann
2014-09-23 16:44         ` Arnd Bergmann
2014-09-23 16:55         ` Felipe Balbi [this message]
2014-09-23 16:55           ` Felipe Balbi
2014-09-23 16:55           ` Felipe Balbi
2014-09-23 17:37           ` Arnd Bergmann
2014-09-23 17:37             ` Arnd Bergmann
2014-09-23 17:37             ` Arnd Bergmann
2014-09-23 17:43             ` Felipe Balbi
2014-09-23 17:43               ` Felipe Balbi
2014-09-23 17:43               ` Felipe Balbi
2014-09-24  2:27             ` Peter Chen
2014-09-24  2:27               ` Peter Chen
2014-09-24  2:27               ` Peter Chen
2014-09-24  7:44               ` Arnd Bergmann
2014-09-24  7:44                 ` Arnd Bergmann
2014-09-24  7:44                 ` Arnd Bergmann
2014-09-24  8:30                 ` Arnd Bergmann
2014-09-24  8:30                   ` Arnd Bergmann
2014-09-24 11:29                   ` Peter Chen
2014-09-24 11:29                     ` Peter Chen
2014-09-24 11:29                     ` Peter Chen
2014-09-24 12:23                     ` Arnd Bergmann
2014-09-24 12:23                       ` Arnd Bergmann
2014-09-25  0:56                       ` Peter Chen
2014-09-25  0:56                         ` Peter Chen
2014-09-25  0:56                         ` Peter Chen
2014-09-25 14:15                       ` Felipe Balbi
2014-09-25 14:15                         ` Felipe Balbi
2014-09-25 14:15                         ` Felipe Balbi
2014-09-25 23:39                         ` Peter Chen
2014-09-25 23:39                           ` Peter Chen
2014-09-25 23:39                           ` Peter Chen
2014-09-26  0:37                           ` Felipe Balbi
2014-09-26  0:37                             ` Felipe Balbi
2014-09-26  0:37                             ` Felipe Balbi
2014-09-26  0:39                             ` Felipe Balbi
2014-09-26  0:39                               ` Felipe Balbi
2014-09-26  0:39                               ` Felipe Balbi
2014-09-26  7:20                               ` Arnd Bergmann
2014-09-26  7:20                                 ` Arnd Bergmann
2014-09-26 15:43                                 ` Felipe Balbi
2014-09-26 15:43                                   ` Felipe Balbi
2014-09-26 15:43                                   ` Felipe Balbi
2014-09-28  0:40                             ` Peter Chen
2014-09-28  0:40                               ` Peter Chen
2014-09-28  0:40                               ` Peter Chen
2014-10-13  8:47                             ` Peter Chen
2014-10-13  8:47                               ` Peter Chen
2014-10-13  8:47                               ` Peter Chen
2014-09-25 14:09                 ` Felipe Balbi
2014-09-25 14:09                   ` Felipe Balbi
2014-09-25 14:09                   ` Felipe Balbi
2014-09-24 23:58   ` Sören Brinkmann
2014-09-24 23:58     ` Sören Brinkmann
2014-09-24 23:58     ` Sören Brinkmann
2014-09-29 14:57     ` Antoine Tenart
2014-09-29 14:57       ` Antoine Tenart
2014-09-29 14:57       ` Antoine Tenart
2014-09-25  1:16   ` Peter Chen
2014-09-25  1:16     ` Peter Chen
2014-09-25  1:16     ` Peter Chen
2014-09-25  7:11     ` Arnd Bergmann
2014-09-25  7:11       ` Arnd Bergmann
2014-09-25  7:11       ` Arnd Bergmann
2014-09-26  0:23       ` Peter Chen
2014-09-26  0:23         ` Peter Chen
2014-09-26  0:23         ` Peter Chen
2014-09-26  7:01         ` Arnd Bergmann
2014-09-26  7:01           ` Arnd Bergmann
2014-09-25 19:12   ` Arnd Bergmann
2014-09-25 19:12     ` Arnd Bergmann
2014-09-25 19:54     ` Antoine Tenart
2014-09-25 19:54       ` Antoine Tenart
2014-09-25 19:54       ` Antoine Tenart
2014-09-29 15:08   ` Antoine Tenart
2014-09-29 15:08     ` Antoine Tenart
2014-09-29 15:08     ` Antoine Tenart
2014-10-01 12:39     ` Antoine Tenart
2014-10-01 12:39       ` Antoine Tenart
2014-09-30  0:12   ` Peter Chen
2014-09-30  0:12     ` Peter Chen
2014-09-30  0:12     ` Peter Chen
2014-09-30 10:03     ` Arnd Bergmann
2014-09-30 10:03       ` Arnd Bergmann
2014-09-30 10:03       ` Arnd Bergmann
2014-09-30 12:39       ` Peter Chen
2014-09-30 12:39         ` Peter Chen
2014-09-30 12:39         ` Peter Chen
2014-09-30 13:43         ` Arnd Bergmann
2014-09-30 13:43           ` Arnd Bergmann
2014-09-30 13:43           ` Arnd Bergmann
2014-10-01  6:35           ` Peter Chen
2014-10-01  6:35             ` Peter Chen
2014-10-01  6:35             ` Peter Chen
2014-10-01  8:41             ` Arnd Bergmann
2014-10-01  8:41               ` Arnd Bergmann
2014-10-01  8:41               ` Arnd Bergmann
2014-10-01 12:25               ` Peter Chen
2014-10-01 12:25                 ` Peter Chen
2014-10-01 12:25                 ` Peter Chen
2014-10-01 23:40     ` Peter Chen
2014-10-01 23:40       ` Peter Chen
2014-10-01 23:40       ` Peter Chen
2014-09-23 10:28 ` [PATCH v6 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart
2014-09-23 10:28   ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140923165515.GA26604@saruman \
    --to=balbi@ti.com \
    --cc=Peter.Chen@freescale.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=zmxu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.