* makedumpfile-1.5.7: Compile warnings on archs without get_versiondep_info()
@ 2014-09-26 8:16 Michael Holzheu
2014-10-21 5:13 ` Atsushi Kumagai
0 siblings, 1 reply; 5+ messages in thread
From: Michael Holzheu @ 2014-09-26 8:16 UTC (permalink / raw)
To: kexec, kumagai-atsushi
I just noticed that makedumpfile-1.5.7 produces warnings
on s390x and probably all other archs that have not defined
get_versiondep_info():
elf_info.c: In function 'get_kcore_dump_loads':
elf_info.c:856:27: warning: unused variable 'p' [-Wunused-variable]
struct pt_load_segment *p = &pt_loads[i];
^
In file included from makedumpfile.h:41:0,
from makedumpfile.c:16:
makedumpfile.c: In function 'get_page_offset':
common.h:19:15: warning: statement with no effect [-Wunused-value]
#define TRUE (1)
^
makedumpfile.h:821:31: note: in expansion of macro 'TRUE'
#define get_versiondep_info() TRUE
^
makedumpfile.c:9240:2: note: in expansion of macro 'get_versiondep_info'
get_versiondep_info();
Best Regards
Michael
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: makedumpfile-1.5.7: Compile warnings on archs without get_versiondep_info()
2014-09-26 8:16 makedumpfile-1.5.7: Compile warnings on archs without get_versiondep_info() Michael Holzheu
@ 2014-10-21 5:13 ` Atsushi Kumagai
2014-10-21 11:28 ` Michael Holzheu
2014-10-21 11:35 ` Michael Holzheu
0 siblings, 2 replies; 5+ messages in thread
From: Atsushi Kumagai @ 2014-10-21 5:13 UTC (permalink / raw)
To: holzheu; +Cc: kexec
Hello Michael,
>I just noticed that makedumpfile-1.5.7 produces warnings
>on s390x and probably all other archs that have not defined
>get_versiondep_info():
Thanks for your reporting, does this patch help you ?
Thanks,
Atsushi Kumagai
From: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Date: Tue, 21 Oct 2014 11:11:46 +0900
Subject: [PATCH] Introduce stub method for machine dependent parts.
Some machine dependent methods are implemented as the literal "1"
since there is no need to do anything in their architectures.
It's polite to replace them into an empty method, this will solve
some compile warnings.
Reported-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Signed-off-by: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
---
makedumpfile.h | 29 +++++++++++++++--------------
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/makedumpfile.h b/makedumpfile.h
index a3342b5..5fda575 100644
--- a/makedumpfile.h
+++ b/makedumpfile.h
@@ -759,26 +759,27 @@ do { \
/*
* The function of dependence on machine
*/
+static inline int stub_true() { return TRUE; }
#ifdef __arm__
int get_phys_base_arm(void);
int get_machdep_info_arm(void);
unsigned long long vaddr_to_paddr_arm(unsigned long vaddr);
#define get_phys_base() get_phys_base_arm()
#define get_machdep_info() get_machdep_info_arm()
-#define get_versiondep_info() TRUE
+#define get_versiondep_info() stub_true()
#define vaddr_to_paddr(X) vaddr_to_paddr_arm(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true(X)
#endif /* arm */
#ifdef __x86__
int get_machdep_info_x86(void);
int get_versiondep_info_x86(void);
unsigned long long vaddr_to_paddr_x86(unsigned long vaddr);
-#define get_phys_base() TRUE
+#define get_phys_base() stub_true()
#define get_machdep_info() get_machdep_info_x86()
#define get_versiondep_info() get_versiondep_info_x86()
#define vaddr_to_paddr(X) vaddr_to_paddr_x86(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true(X)
#endif /* x86 */
#ifdef __x86_64__
@@ -798,31 +799,31 @@ unsigned long long vaddr_to_paddr_x86_64(unsigned long vaddr);
int get_machdep_info_ppc64(void);
int get_versiondep_info_ppc64(void);
unsigned long long vaddr_to_paddr_ppc64(unsigned long vaddr);
-#define get_phys_base() TRUE
+#define get_phys_base() stub_true()
#define get_machdep_info() get_machdep_info_ppc64()
#define get_versiondep_info() get_versiondep_info_ppc64()
#define vaddr_to_paddr(X) vaddr_to_paddr_ppc64(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true(X)
#endif /* powerpc64 */
#ifdef __powerpc32__ /* powerpc32 */
int get_machdep_info_ppc(void);
unsigned long long vaddr_to_paddr_ppc(unsigned long vaddr);
-#define get_phys_base() TRUE
+#define get_phys_base() stub_true()
#define get_machdep_info() get_machdep_info_ppc()
-#define get_versiondep_info() TRUE
+#define get_versiondep_info() stub_true()
#define vaddr_to_paddr(X) vaddr_to_paddr_ppc(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true(X)
#endif /* powerpc32 */
#ifdef __s390x__ /* s390x */
int get_machdep_info_s390x(void);
unsigned long long vaddr_to_paddr_s390x(unsigned long vaddr);
-#define get_phys_base() TRUE
+#define get_phys_base() stub_true()
#define get_machdep_info() get_machdep_info_s390x()
-#define get_versiondep_info() TRUE
+#define get_versiondep_info() stub_true()
#define vaddr_to_paddr(X) vaddr_to_paddr_s390x(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true(X)
#endif /* s390x */
#ifdef __ia64__ /* ia64 */
@@ -831,10 +832,10 @@ int get_machdep_info_ia64(void);
unsigned long long vaddr_to_paddr_ia64(unsigned long vaddr);
#define get_machdep_info() get_machdep_info_ia64()
#define get_phys_base() get_phys_base_ia64()
-#define get_versiondep_info() TRUE
+#define get_versiondep_info() stub_true()
#define vaddr_to_paddr(X) vaddr_to_paddr_ia64(X)
#define VADDR_REGION(X) (((unsigned long)(X)) >> REGION_SHIFT)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true(X)
#endif /* ia64 */
typedef unsigned long long mdf_pfn_t;
--
1.9.0
>elf_info.c: In function 'get_kcore_dump_loads':
>elf_info.c:856:27: warning: unused variable 'p' [-Wunused-variable]
> struct pt_load_segment *p = &pt_loads[i];
>
> ^
>In file included from makedumpfile.h:41:0,
> from makedumpfile.c:16:
>makedumpfile.c: In function 'get_page_offset':
>common.h:19:15: warning: statement with no effect [-Wunused-value]
> #define TRUE (1)
> ^
>makedumpfile.h:821:31: note: in expansion of macro 'TRUE'
> #define get_versiondep_info() TRUE
> ^
>makedumpfile.c:9240:2: note: in expansion of macro 'get_versiondep_info'
> get_versiondep_info();
>
>Best Regards
>Michael
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: makedumpfile-1.5.7: Compile warnings on archs without get_versiondep_info()
2014-10-21 5:13 ` Atsushi Kumagai
@ 2014-10-21 11:28 ` Michael Holzheu
2014-10-21 11:35 ` Michael Holzheu
1 sibling, 0 replies; 5+ messages in thread
From: Michael Holzheu @ 2014-10-21 11:28 UTC (permalink / raw)
To: Atsushi Kumagai; +Cc: kexec
On Tue, 21 Oct 2014 05:13:37 +0000
Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp> wrote:
> Hello Michael,
>
> >I just noticed that makedumpfile-1.5.7 produces warnings
> >on s390x and probably all other archs that have not defined
> >get_versiondep_info():
>
> Thanks for your reporting, does this patch help you ?
Hello Atsushi,
I had problems applying the patch but after manually adding
the changes I still get the following warning:
>
> Thanks,
> Atsushi Kumagai
>
>
> From: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
> Date: Tue, 21 Oct 2014 11:11:46 +0900
> Subject: [PATCH] Introduce stub method for machine dependent parts.
>
> Some machine dependent methods are implemented as the literal "1"
> since there is no need to do anything in their architectures.
>
> It's polite to replace them into an empty method, this will solve
> some compile warnings.
>
> Reported-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> Signed-off-by: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
> ---
> makedumpfile.h | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/makedumpfile.h b/makedumpfile.h
> index a3342b5..5fda575 100644
> --- a/makedumpfile.h
> +++ b/makedumpfile.h
> @@ -759,26 +759,27 @@ do { \
> /*
> * The function of dependence on machine
> */
> +static inline int stub_true() { return TRUE; }
> #ifdef __arm__
> int get_phys_base_arm(void);
> int get_machdep_info_arm(void);
> unsigned long long vaddr_to_paddr_arm(unsigned long vaddr);
> #define get_phys_base() get_phys_base_arm()
> #define get_machdep_info() get_machdep_info_arm()
> -#define get_versiondep_info() TRUE
> +#define get_versiondep_info() stub_true()
> #define vaddr_to_paddr(X) vaddr_to_paddr_arm(X)
> -#define is_vmalloc_addr(X) TRUE
> +#define is_vmalloc_addr(X) stub_true(X)
> #endif /* arm */
>
> #ifdef __x86__
> int get_machdep_info_x86(void);
> int get_versiondep_info_x86(void);
> unsigned long long vaddr_to_paddr_x86(unsigned long vaddr);
> -#define get_phys_base() TRUE
> +#define get_phys_base() stub_true()
> #define get_machdep_info() get_machdep_info_x86()
> #define get_versiondep_info() get_versiondep_info_x86()
> #define vaddr_to_paddr(X) vaddr_to_paddr_x86(X)
> -#define is_vmalloc_addr(X) TRUE
> +#define is_vmalloc_addr(X) stub_true(X)
> #endif /* x86 */
>
> #ifdef __x86_64__
> @@ -798,31 +799,31 @@ unsigned long long vaddr_to_paddr_x86_64(unsigned long vaddr);
> int get_machdep_info_ppc64(void);
> int get_versiondep_info_ppc64(void);
> unsigned long long vaddr_to_paddr_ppc64(unsigned long vaddr);
> -#define get_phys_base() TRUE
> +#define get_phys_base() stub_true()
> #define get_machdep_info() get_machdep_info_ppc64()
> #define get_versiondep_info() get_versiondep_info_ppc64()
> #define vaddr_to_paddr(X) vaddr_to_paddr_ppc64(X)
> -#define is_vmalloc_addr(X) TRUE
> +#define is_vmalloc_addr(X) stub_true(X)
> #endif /* powerpc64 */
>
> #ifdef __powerpc32__ /* powerpc32 */
> int get_machdep_info_ppc(void);
> unsigned long long vaddr_to_paddr_ppc(unsigned long vaddr);
> -#define get_phys_base() TRUE
> +#define get_phys_base() stub_true()
> #define get_machdep_info() get_machdep_info_ppc()
> -#define get_versiondep_info() TRUE
> +#define get_versiondep_info() stub_true()
> #define vaddr_to_paddr(X) vaddr_to_paddr_ppc(X)
> -#define is_vmalloc_addr(X) TRUE
> +#define is_vmalloc_addr(X) stub_true(X)
> #endif /* powerpc32 */
>
> #ifdef __s390x__ /* s390x */
> int get_machdep_info_s390x(void);
> unsigned long long vaddr_to_paddr_s390x(unsigned long vaddr);
> -#define get_phys_base() TRUE
> +#define get_phys_base() stub_true()
> #define get_machdep_info() get_machdep_info_s390x()
> -#define get_versiondep_info() TRUE
> +#define get_versiondep_info() stub_true()
> #define vaddr_to_paddr(X) vaddr_to_paddr_s390x(X)
> -#define is_vmalloc_addr(X) TRUE
> +#define is_vmalloc_addr(X) stub_true(X)
> #endif /* s390x */
>
> #ifdef __ia64__ /* ia64 */
> @@ -831,10 +832,10 @@ int get_machdep_info_ia64(void);
> unsigned long long vaddr_to_paddr_ia64(unsigned long vaddr);
> #define get_machdep_info() get_machdep_info_ia64()
> #define get_phys_base() get_phys_base_ia64()
> -#define get_versiondep_info() TRUE
> +#define get_versiondep_info() stub_true()
> #define vaddr_to_paddr(X) vaddr_to_paddr_ia64(X)
> #define VADDR_REGION(X) (((unsigned long)(X)) >> REGION_SHIFT)
> -#define is_vmalloc_addr(X) TRUE
> +#define is_vmalloc_addr(X) stub_true(X)
> #endif /* ia64 */
>
> typedef unsigned long long mdf_pfn_t;
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: makedumpfile-1.5.7: Compile warnings on archs without get_versiondep_info()
2014-10-21 5:13 ` Atsushi Kumagai
2014-10-21 11:28 ` Michael Holzheu
@ 2014-10-21 11:35 ` Michael Holzheu
2014-10-22 0:43 ` Atsushi Kumagai
1 sibling, 1 reply; 5+ messages in thread
From: Michael Holzheu @ 2014-10-21 11:35 UTC (permalink / raw)
To: Atsushi Kumagai; +Cc: kexec
On Tue, 21 Oct 2014 05:13:37 +0000
Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp> wrote:
> Hello Michael,
>
> >I just noticed that makedumpfile-1.5.7 produces warnings
> >on s390x and probably all other archs that have not defined
> >get_versiondep_info():
>
> Thanks for your reporting, does this patch help you ?
Hello Atsushi,
Sorry, the first note was sent by accident...
I had problems applying the patch but after manually adding
the changes I still get the following warning:
elf_info.c: In function 'get_kcore_dump_loads':
elf_info.c:855:27: warning: unused variable 'p' [-Wunused-variable]
struct pt_load_segment *p = &pt_loads[i];
What about the following patch:
---
makedumpfile.h | 30 ++++++++++++++++--------------
1 file changed, 16 insertions(+), 14 deletions(-)
--- a/makedumpfile.h
+++ b/makedumpfile.h
@@ -759,26 +759,28 @@ do { \
/*
* The function of dependence on machine
*/
+static inline int stub_true() { return TRUE; }
+static inline int stub_true_ul(unsigned long x) { return TRUE; }
#ifdef __arm__
int get_phys_base_arm(void);
int get_machdep_info_arm(void);
unsigned long long vaddr_to_paddr_arm(unsigned long vaddr);
#define get_phys_base() get_phys_base_arm()
#define get_machdep_info() get_machdep_info_arm()
-#define get_versiondep_info() TRUE
+#define get_versiondep_info() stub_true()
#define vaddr_to_paddr(X) vaddr_to_paddr_arm(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true_ul(X)
#endif /* arm */
#ifdef __x86__
int get_machdep_info_x86(void);
int get_versiondep_info_x86(void);
unsigned long long vaddr_to_paddr_x86(unsigned long vaddr);
-#define get_phys_base() TRUE
+#define get_phys_base() stub_true()
#define get_machdep_info() get_machdep_info_x86()
#define get_versiondep_info() get_versiondep_info_x86()
#define vaddr_to_paddr(X) vaddr_to_paddr_x86(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true_ul(X)
#endif /* x86 */
#ifdef __x86_64__
@@ -798,31 +800,31 @@ unsigned long long vaddr_to_paddr_x86_64
int get_machdep_info_ppc64(void);
int get_versiondep_info_ppc64(void);
unsigned long long vaddr_to_paddr_ppc64(unsigned long vaddr);
-#define get_phys_base() TRUE
+#define get_phys_base() stub_true()
#define get_machdep_info() get_machdep_info_ppc64()
#define get_versiondep_info() get_versiondep_info_ppc64()
#define vaddr_to_paddr(X) vaddr_to_paddr_ppc64(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true_ul(X)
#endif /* powerpc64 */
#ifdef __powerpc32__ /* powerpc32 */
int get_machdep_info_ppc(void);
unsigned long long vaddr_to_paddr_ppc(unsigned long vaddr);
-#define get_phys_base() TRUE
+#define get_phys_base() stub_true()
#define get_machdep_info() get_machdep_info_ppc()
-#define get_versiondep_info() TRUE
+#define get_versiondep_info() stub_true()
#define vaddr_to_paddr(X) vaddr_to_paddr_ppc(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true_ul(X)
#endif /* powerpc32 */
#ifdef __s390x__ /* s390x */
int get_machdep_info_s390x(void);
unsigned long long vaddr_to_paddr_s390x(unsigned long vaddr);
-#define get_phys_base() TRUE
+#define get_phys_base() stub_true()
#define get_machdep_info() get_machdep_info_s390x()
-#define get_versiondep_info() TRUE
+#define get_versiondep_info() stub_true()
#define vaddr_to_paddr(X) vaddr_to_paddr_s390x(X)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true_ul(X)
#endif /* s390x */
#ifdef __ia64__ /* ia64 */
@@ -831,10 +833,10 @@ int get_machdep_info_ia64(void);
unsigned long long vaddr_to_paddr_ia64(unsigned long vaddr);
#define get_machdep_info() get_machdep_info_ia64()
#define get_phys_base() get_phys_base_ia64()
-#define get_versiondep_info() TRUE
+#define get_versiondep_info() stub_true()
#define vaddr_to_paddr(X) vaddr_to_paddr_ia64(X)
#define VADDR_REGION(X) (((unsigned long)(X)) >> REGION_SHIFT)
-#define is_vmalloc_addr(X) TRUE
+#define is_vmalloc_addr(X) stub_true_ul(X)
#endif /* ia64 */
typedef unsigned long long mdf_pfn_t;
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: makedumpfile-1.5.7: Compile warnings on archs without get_versiondep_info()
2014-10-21 11:35 ` Michael Holzheu
@ 2014-10-22 0:43 ` Atsushi Kumagai
0 siblings, 0 replies; 5+ messages in thread
From: Atsushi Kumagai @ 2014-10-22 0:43 UTC (permalink / raw)
To: holzheu; +Cc: kexec
>On Tue, 21 Oct 2014 05:13:37 +0000
>Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp> wrote:
>
>> Hello Michael,
>>
>> >I just noticed that makedumpfile-1.5.7 produces warnings
>> >on s390x and probably all other archs that have not defined
>> >get_versiondep_info():
>>
>> Thanks for your reporting, does this patch help you ?
>
>Hello Atsushi,
>
>Sorry, the first note was sent by accident...
>
>I had problems applying the patch but after manually adding
>the changes I still get the following warning:
>
>elf_info.c: In function 'get_kcore_dump_loads':
>elf_info.c:855:27: warning: unused variable 'p' [-Wunused-variable]
> struct pt_load_segment *p = &pt_loads[i];
>
>What about the following patch:
Good fix! I'll merge this into v1.5.8.
Thanks,
Atsushi Kumagai
>---
> makedumpfile.h | 30 ++++++++++++++++--------------
> 1 file changed, 16 insertions(+), 14 deletions(-)
>
>--- a/makedumpfile.h
>+++ b/makedumpfile.h
>@@ -759,26 +759,28 @@ do { \
> /*
> * The function of dependence on machine
> */
>+static inline int stub_true() { return TRUE; }
>+static inline int stub_true_ul(unsigned long x) { return TRUE; }
> #ifdef __arm__
> int get_phys_base_arm(void);
> int get_machdep_info_arm(void);
> unsigned long long vaddr_to_paddr_arm(unsigned long vaddr);
> #define get_phys_base() get_phys_base_arm()
> #define get_machdep_info() get_machdep_info_arm()
>-#define get_versiondep_info() TRUE
>+#define get_versiondep_info() stub_true()
> #define vaddr_to_paddr(X) vaddr_to_paddr_arm(X)
>-#define is_vmalloc_addr(X) TRUE
>+#define is_vmalloc_addr(X) stub_true_ul(X)
> #endif /* arm */
>
> #ifdef __x86__
> int get_machdep_info_x86(void);
> int get_versiondep_info_x86(void);
> unsigned long long vaddr_to_paddr_x86(unsigned long vaddr);
>-#define get_phys_base() TRUE
>+#define get_phys_base() stub_true()
> #define get_machdep_info() get_machdep_info_x86()
> #define get_versiondep_info() get_versiondep_info_x86()
> #define vaddr_to_paddr(X) vaddr_to_paddr_x86(X)
>-#define is_vmalloc_addr(X) TRUE
>+#define is_vmalloc_addr(X) stub_true_ul(X)
> #endif /* x86 */
>
> #ifdef __x86_64__
>@@ -798,31 +800,31 @@ unsigned long long vaddr_to_paddr_x86_64
> int get_machdep_info_ppc64(void);
> int get_versiondep_info_ppc64(void);
> unsigned long long vaddr_to_paddr_ppc64(unsigned long vaddr);
>-#define get_phys_base() TRUE
>+#define get_phys_base() stub_true()
> #define get_machdep_info() get_machdep_info_ppc64()
> #define get_versiondep_info() get_versiondep_info_ppc64()
> #define vaddr_to_paddr(X) vaddr_to_paddr_ppc64(X)
>-#define is_vmalloc_addr(X) TRUE
>+#define is_vmalloc_addr(X) stub_true_ul(X)
> #endif /* powerpc64 */
>
> #ifdef __powerpc32__ /* powerpc32 */
> int get_machdep_info_ppc(void);
> unsigned long long vaddr_to_paddr_ppc(unsigned long vaddr);
>-#define get_phys_base() TRUE
>+#define get_phys_base() stub_true()
> #define get_machdep_info() get_machdep_info_ppc()
>-#define get_versiondep_info() TRUE
>+#define get_versiondep_info() stub_true()
> #define vaddr_to_paddr(X) vaddr_to_paddr_ppc(X)
>-#define is_vmalloc_addr(X) TRUE
>+#define is_vmalloc_addr(X) stub_true_ul(X)
> #endif /* powerpc32 */
>
> #ifdef __s390x__ /* s390x */
> int get_machdep_info_s390x(void);
> unsigned long long vaddr_to_paddr_s390x(unsigned long vaddr);
>-#define get_phys_base() TRUE
>+#define get_phys_base() stub_true()
> #define get_machdep_info() get_machdep_info_s390x()
>-#define get_versiondep_info() TRUE
>+#define get_versiondep_info() stub_true()
> #define vaddr_to_paddr(X) vaddr_to_paddr_s390x(X)
>-#define is_vmalloc_addr(X) TRUE
>+#define is_vmalloc_addr(X) stub_true_ul(X)
> #endif /* s390x */
>
> #ifdef __ia64__ /* ia64 */
>@@ -831,10 +833,10 @@ int get_machdep_info_ia64(void);
> unsigned long long vaddr_to_paddr_ia64(unsigned long vaddr);
> #define get_machdep_info() get_machdep_info_ia64()
> #define get_phys_base() get_phys_base_ia64()
>-#define get_versiondep_info() TRUE
>+#define get_versiondep_info() stub_true()
> #define vaddr_to_paddr(X) vaddr_to_paddr_ia64(X)
> #define VADDR_REGION(X) (((unsigned long)(X)) >> REGION_SHIFT)
>-#define is_vmalloc_addr(X) TRUE
>+#define is_vmalloc_addr(X) stub_true_ul(X)
> #endif /* ia64 */
>
> typedef unsigned long long mdf_pfn_t;
>
>
>_______________________________________________
>kexec mailing list
>kexec@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-22 0:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-26 8:16 makedumpfile-1.5.7: Compile warnings on archs without get_versiondep_info() Michael Holzheu
2014-10-21 5:13 ` Atsushi Kumagai
2014-10-21 11:28 ` Michael Holzheu
2014-10-21 11:35 ` Michael Holzheu
2014-10-22 0:43 ` Atsushi Kumagai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.