All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Griffin <peter.griffin@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
	kernel@stlinux.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional
Date: Fri, 24 Oct 2014 09:11:10 +0100	[thread overview]
Message-ID: <20141024081110.GA22250@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <54227CD2.5020705@linaro.org>

Hi Srini,

Sorry seems I never replied to this.

> >>drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer
> >>from integer without a cast [enabled by default]
> >>   rc_dev->rstc = reset_control_get(dev, NULL);
> >
> >Is managing the reset line actually optional though? I can't test atm as I don't have
> >access to my board, but quite often if the IP's aren't taken out of reset reads / writes
> >to the perhpiheral will hang the SoC.
> >
> Yes and No.
> AFAIK reset line is optional on SOCs like 7108, 7141.
> I think having the driver function without reset might is a value
> add in case we plan to reuse the mainline driver for these SOCs.

Yes that is a good point, for the series: -

Acked-by: Peter Griffin <peter.griffin@linaro.org>

regards,

Peter.

WARNING: multiple messages have this Message-ID (diff)
From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional
Date: Fri, 24 Oct 2014 09:11:10 +0100	[thread overview]
Message-ID: <20141024081110.GA22250@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <54227CD2.5020705@linaro.org>

Hi Srini,

Sorry seems I never replied to this.

> >>drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer
> >>from integer without a cast [enabled by default]
> >>   rc_dev->rstc = reset_control_get(dev, NULL);
> >
> >Is managing the reset line actually optional though? I can't test atm as I don't have
> >access to my board, but quite often if the IP's aren't taken out of reset reads / writes
> >to the perhpiheral will hang the SoC.
> >
> Yes and No.
> AFAIK reset line is optional on SOCs like 7108, 7141.
> I think having the driver function without reset might is a value
> add in case we plan to reuse the mainline driver for these SOCs.

Yes that is a good point, for the series: -

Acked-by: Peter Griffin <peter.griffin@linaro.org>

regards,

Peter.

  parent reply	other threads:[~2014-10-24  8:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 22:21 [PATCH 0/3] media:st-rc: Misc fixes Srinivas Kandagatla
2014-09-22 22:21 ` Srinivas Kandagatla
2014-09-22 22:22 ` [PATCH 1/3] media: st-rc: move to using reset_control_get_optional Srinivas Kandagatla
2014-09-22 22:22   ` Srinivas Kandagatla
2014-09-23 18:02   ` [STLinux Kernel] " Peter Griffin
2014-09-23 18:02     ` Peter Griffin
2014-09-24  8:12     ` Srinivas Kandagatla
2014-09-24  8:12       ` Srinivas Kandagatla
2014-09-24  8:37       ` Maxime Coquelin
2014-09-24  8:37         ` Maxime Coquelin
2014-10-24  8:11       ` Peter Griffin [this message]
2014-10-24  8:11         ` Peter Griffin
2014-09-22 22:22 ` [PATCH 2/3] media: st-rc: move pm ops setup out of conditional compilation Srinivas Kandagatla
2014-09-22 22:22   ` Srinivas Kandagatla
2014-09-22 22:22 ` [PATCH 3/3] media: st-rc: Remove .owner field for driver Srinivas Kandagatla
2014-09-22 22:22   ` Srinivas Kandagatla
2014-09-23 18:05   ` [STLinux Kernel] " Peter Griffin
2014-09-23 18:05     ` Peter Griffin
2014-09-22 22:39 ` [PATCH 0/3] media:st-rc: Misc fixes Mauro Carvalho Chehab
2014-09-22 22:39   ` Mauro Carvalho Chehab
2014-09-23  7:27 ` Maxime Coquelin
2014-09-23  7:27   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141024081110.GA22250@griffinp-ThinkPad-X1-Carbon-2nd \
    --to=peter.griffin@linaro.org \
    --cc=kernel@stlinux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.