From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> To: Peter Griffin <peter.griffin@linaro.org> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>, kernel@stlinux.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional Date: Wed, 24 Sep 2014 09:12:02 +0100 [thread overview] Message-ID: <54227CD2.5020705@linaro.org> (raw) In-Reply-To: <20140923180255.GA3430@griffinp-ThinkPad-X1-Carbon-2nd> Hi Pete, On 23/09/14 19:02, Peter Griffin wrote: > Hi Srini, > > On Mon, 22 Sep 2014, Srinivas Kandagatla wrote: > >> This patch fixes a compilation error while building with the >> random kernel configuration. >> >> drivers/media/rc/st_rc.c: In function 'st_rc_probe': >> drivers/media/rc/st_rc.c:281:2: error: implicit declaration of >> function 'reset_control_get' [-Werror=implicit-function-declaration] >> rc_dev->rstc = reset_control_get(dev, NULL); >> >> drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer >> from integer without a cast [enabled by default] >> rc_dev->rstc = reset_control_get(dev, NULL); > > Is managing the reset line actually optional though? I can't test atm as I don't have > access to my board, but quite often if the IP's aren't taken out of reset reads / writes > to the perhpiheral will hang the SoC. > Yes and No. AFAIK reset line is optional on SOCs like 7108, 7141. I think having the driver function without reset might is a value add in case we plan to reuse the mainline driver for these SOCs. On latest ARM SOCs with SBC the IRB IP is moved to SBC and held in reset. Am not sure, if the reset line is optional in next generation SOCs? > If managing the reset line isn't optional then I think the correct fix is to add > depends on RESET_CONTROLLER in the kconfig. I agree. This would make the COMPILE_TEST less useful though. thanks, srini > > This will then do the right thing for randconfig builds as well. > > regards, > > Peter. >
WARNING: multiple messages have this Message-ID (diff)
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla) To: linux-arm-kernel@lists.infradead.org Subject: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional Date: Wed, 24 Sep 2014 09:12:02 +0100 [thread overview] Message-ID: <54227CD2.5020705@linaro.org> (raw) In-Reply-To: <20140923180255.GA3430@griffinp-ThinkPad-X1-Carbon-2nd> Hi Pete, On 23/09/14 19:02, Peter Griffin wrote: > Hi Srini, > > On Mon, 22 Sep 2014, Srinivas Kandagatla wrote: > >> This patch fixes a compilation error while building with the >> random kernel configuration. >> >> drivers/media/rc/st_rc.c: In function 'st_rc_probe': >> drivers/media/rc/st_rc.c:281:2: error: implicit declaration of >> function 'reset_control_get' [-Werror=implicit-function-declaration] >> rc_dev->rstc = reset_control_get(dev, NULL); >> >> drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer >> from integer without a cast [enabled by default] >> rc_dev->rstc = reset_control_get(dev, NULL); > > Is managing the reset line actually optional though? I can't test atm as I don't have > access to my board, but quite often if the IP's aren't taken out of reset reads / writes > to the perhpiheral will hang the SoC. > Yes and No. AFAIK reset line is optional on SOCs like 7108, 7141. I think having the driver function without reset might is a value add in case we plan to reuse the mainline driver for these SOCs. On latest ARM SOCs with SBC the IRB IP is moved to SBC and held in reset. Am not sure, if the reset line is optional in next generation SOCs? > If managing the reset line isn't optional then I think the correct fix is to add > depends on RESET_CONTROLLER in the kconfig. I agree. This would make the COMPILE_TEST less useful though. thanks, srini > > This will then do the right thing for randconfig builds as well. > > regards, > > Peter. >
next prev parent reply other threads:[~2014-09-24 8:13 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-22 22:21 [PATCH 0/3] media:st-rc: Misc fixes Srinivas Kandagatla 2014-09-22 22:21 ` Srinivas Kandagatla 2014-09-22 22:22 ` [PATCH 1/3] media: st-rc: move to using reset_control_get_optional Srinivas Kandagatla 2014-09-22 22:22 ` Srinivas Kandagatla 2014-09-23 18:02 ` [STLinux Kernel] " Peter Griffin 2014-09-23 18:02 ` Peter Griffin 2014-09-24 8:12 ` Srinivas Kandagatla [this message] 2014-09-24 8:12 ` Srinivas Kandagatla 2014-09-24 8:37 ` Maxime Coquelin 2014-09-24 8:37 ` Maxime Coquelin 2014-10-24 8:11 ` Peter Griffin 2014-10-24 8:11 ` Peter Griffin 2014-09-22 22:22 ` [PATCH 2/3] media: st-rc: move pm ops setup out of conditional compilation Srinivas Kandagatla 2014-09-22 22:22 ` Srinivas Kandagatla 2014-09-22 22:22 ` [PATCH 3/3] media: st-rc: Remove .owner field for driver Srinivas Kandagatla 2014-09-22 22:22 ` Srinivas Kandagatla 2014-09-23 18:05 ` [STLinux Kernel] " Peter Griffin 2014-09-23 18:05 ` Peter Griffin 2014-09-22 22:39 ` [PATCH 0/3] media:st-rc: Misc fixes Mauro Carvalho Chehab 2014-09-22 22:39 ` Mauro Carvalho Chehab 2014-09-23 7:27 ` Maxime Coquelin 2014-09-23 7:27 ` Maxime Coquelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54227CD2.5020705@linaro.org \ --to=srinivas.kandagatla@linaro.org \ --cc=kernel@stlinux.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=m.chehab@samsung.com \ --cc=peter.griffin@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.