* [Buildroot] [PATCH] mpdecimal: disable static build
@ 2014-11-23 9:08 Baruch Siach
2014-11-23 9:47 ` Thomas Petazzoni
2014-11-23 22:15 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2014-11-23 9:08 UTC (permalink / raw)
To: buildroot
mpdecimal always tries to build its shared library.
Fixes:
http://autobuild.buildroot.net/results/276/2764bd8c42ba659682760ffc6afa933b7530d06c/
http://autobuild.buildroot.net/results/3cc/3cca0aacc4d66c49b21d23681813abea5a1b32e0/
http://autobuild.buildroot.net/results/207/20783d1448464d957862e1c70585844f86aed237/
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/mpdecimal/Config.in | 4 ++++
package/python3/Config.in | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/package/mpdecimal/Config.in b/package/mpdecimal/Config.in
index 929d41514399..2aae520c15d9 100644
--- a/package/mpdecimal/Config.in
+++ b/package/mpdecimal/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_MPDECIMAL
bool "mpdecimal"
help
+ depends on !BR2_PREFER_STATIC_LIB
mpdecimal is a package for correctly-rounded arbitrary
precision decimal floating point arithmetic. Starting from
version 2.4, mpdecimal includes only the libmpdec
@@ -8,3 +9,6 @@ config BR2_PACKAGE_MPDECIMAL
exclusively on libmpdec.
http://www.bytereef.org/mpdecimal/
+
+comment "mpdecimal needs a toolchain w/ dynamic library"
+ depends on BR2_PREFER_STATIC_LIB
diff --git a/package/python3/Config.in b/package/python3/Config.in
index 375390fcf69d..afcb74229474 100644
--- a/package/python3/Config.in
+++ b/package/python3/Config.in
@@ -57,10 +57,14 @@ config BR2_PACKAGE_PYTHON3_CURSES
config BR2_PACKAGE_PYTHON3_DECIMAL
select BR2_PACKAGE_MPDECIMAL
+ depends on !BR2_PREFER_STATIC_LIB # mpdecimal
bool "decimal module"
help
decimal module for Python3.
+comment "decimal module needs a toolchain w/ dynamic library"
+ depends on BR2_PREFER_STATIC_LIB
+
config BR2_PACKAGE_PYTHON3_PYEXPAT
select BR2_PACKAGE_EXPAT
bool "pyexpat"
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mpdecimal: disable static build
2014-11-23 9:08 [Buildroot] [PATCH] mpdecimal: disable static build Baruch Siach
@ 2014-11-23 9:47 ` Thomas Petazzoni
2014-11-23 22:15 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2014-11-23 9:47 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Sun, 23 Nov 2014 11:08:46 +0200, Baruch Siach wrote:
> mpdecimal always tries to build its shared library.
>
> Fixes:
> http://autobuild.buildroot.net/results/276/2764bd8c42ba659682760ffc6afa933b7530d06c/
> http://autobuild.buildroot.net/results/3cc/3cca0aacc4d66c49b21d23681813abea5a1b32e0/
> http://autobuild.buildroot.net/results/207/20783d1448464d957862e1c70585844f86aed237/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
While in flight, I have just cooked a patch that allows to build
mpdecimal only as a static library. I'll send it later today.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mpdecimal: disable static build
2014-11-23 9:08 [Buildroot] [PATCH] mpdecimal: disable static build Baruch Siach
2014-11-23 9:47 ` Thomas Petazzoni
@ 2014-11-23 22:15 ` Yann E. MORIN
2014-11-24 4:33 ` Baruch Siach
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2014-11-23 22:15 UTC (permalink / raw)
To: buildroot
Baruch, All,
On 2014-11-23 11:08 +0200, Baruch Siach spake thusly:
> mpdecimal always tries to build its shared library.
>
> Fixes:
> http://autobuild.buildroot.net/results/276/2764bd8c42ba659682760ffc6afa933b7530d06c/
> http://autobuild.buildroot.net/results/3cc/3cca0aacc4d66c49b21d23681813abea5a1b32e0/
> http://autobuild.buildroot.net/results/207/20783d1448464d957862e1c70585844f86aed237/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Beside the fact that Thomas P. has a fix for building static, I have a
comment on that patch of yours...
> ---
> package/mpdecimal/Config.in | 4 ++++
> package/python3/Config.in | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/package/mpdecimal/Config.in b/package/mpdecimal/Config.in
> index 929d41514399..2aae520c15d9 100644
> --- a/package/mpdecimal/Config.in
> +++ b/package/mpdecimal/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_MPDECIMAL
> bool "mpdecimal"
> help
> + depends on !BR2_PREFER_STATIC_LIB
> mpdecimal is a package for correctly-rounded arbitrary
> precision decimal floating point arithmetic. Starting from
> version 2.4, mpdecimal includes only the libmpdec
Really? This makes the "depends on" part of the help text...
Regards,
Yann E. MORIN.
> @@ -8,3 +9,6 @@ config BR2_PACKAGE_MPDECIMAL
> exclusively on libmpdec.
>
> http://www.bytereef.org/mpdecimal/
> +
> +comment "mpdecimal needs a toolchain w/ dynamic library"
> + depends on BR2_PREFER_STATIC_LIB
> diff --git a/package/python3/Config.in b/package/python3/Config.in
> index 375390fcf69d..afcb74229474 100644
> --- a/package/python3/Config.in
> +++ b/package/python3/Config.in
> @@ -57,10 +57,14 @@ config BR2_PACKAGE_PYTHON3_CURSES
>
> config BR2_PACKAGE_PYTHON3_DECIMAL
> select BR2_PACKAGE_MPDECIMAL
> + depends on !BR2_PREFER_STATIC_LIB # mpdecimal
> bool "decimal module"
> help
> decimal module for Python3.
>
> +comment "decimal module needs a toolchain w/ dynamic library"
> + depends on BR2_PREFER_STATIC_LIB
> +
> config BR2_PACKAGE_PYTHON3_PYEXPAT
> select BR2_PACKAGE_EXPAT
> bool "pyexpat"
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mpdecimal: disable static build
2014-11-23 22:15 ` Yann E. MORIN
@ 2014-11-24 4:33 ` Baruch Siach
0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2014-11-24 4:33 UTC (permalink / raw)
To: buildroot
Hi Yann,
On Sun, Nov 23, 2014 at 11:15:18PM +0100, Yann E. MORIN wrote:
> On 2014-11-23 11:08 +0200, Baruch Siach spake thusly:
> > diff --git a/package/mpdecimal/Config.in b/package/mpdecimal/Config.in
> > index 929d41514399..2aae520c15d9 100644
> > --- a/package/mpdecimal/Config.in
> > +++ b/package/mpdecimal/Config.in
> > @@ -1,6 +1,7 @@
> > config BR2_PACKAGE_MPDECIMAL
> > bool "mpdecimal"
> > help
> > + depends on !BR2_PREFER_STATIC_LIB
> > mpdecimal is a package for correctly-rounded arbitrary
> > precision decimal floating point arithmetic. Starting from
> > version 2.4, mpdecimal includes only the libmpdec
>
> Really? This makes the "depends on" part of the help text...
Ah, my bad. I already marked this patch as Superseded in patchwork, as Thomas'
patch will hopefully actually fix static build.
Thanks for reviewing, anyway.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-24 4:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-23 9:08 [Buildroot] [PATCH] mpdecimal: disable static build Baruch Siach
2014-11-23 9:47 ` Thomas Petazzoni
2014-11-23 22:15 ` Yann E. MORIN
2014-11-24 4:33 ` Baruch Siach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.