From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Murali Karicheri <m-karicheri2@ti.com>,
Ben Gardiner <bengardiner@nanometrics.ca>,
Mike Looijmans <milo-software@users.sourceforge.net>
Subject: Re: [5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery
Date: Mon, 24 Nov 2014 20:45:33 +0100 [thread overview]
Message-ID: <20141124194533.GU4431@pengutronix.de> (raw)
In-Reply-To: <54732F8E.4080105@ti.com>
Hi Grygorii,
On Mon, Nov 24, 2014 at 03:15:58PM +0200, Grygorii Strashko wrote:
> On 11/23/2014 07:04 PM, Uwe Kleine-König wrote:
> > On Thu, Nov 20, 2014 at 12:03:08PM +0200, Grygorii Strashko wrote:
> >> @@ -664,6 +759,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> >> if (!of_property_read_u32(pdev->dev.of_node, "clock-frequency",
> >> &prop))
> >> dev->pdata->bus_freq = prop / 1000;
> >> + dev->pdata->has_pfunc = true;
> > I don't understand this. Why does this ICPFUNC recovery work if the bus
> > is probed by oftree, but doesn't if not?
>
> I've mentioned this in commit message:
> Allow platforms to indicate the presence of the ICPFUNC registers with a has_pfunc
> platform data flag and enable this mode for platforms which supports DT (da850 and
> Keystone 2 are two SoCs which support DT now and they also support ICPFUNC registers).
Ah, so you assume that in the dt case the pfunc functionality is
available. I didn't understand if it's bad or not if this assumption is
wrong, but I suggest to only use the pfunc stuff if the device node has
a given property (e.g. ti,has_pfunc).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
Kevin Hilman
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>,
Santosh Shilimkar
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>,
Ben Gardiner
<bengardiner-ScDXFp4xN3PN+rMO2ozGnw@public.gmane.org>,
Mike Looijmans
<milo-software-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery
Date: Mon, 24 Nov 2014 20:45:33 +0100 [thread overview]
Message-ID: <20141124194533.GU4431@pengutronix.de> (raw)
In-Reply-To: <54732F8E.4080105-l0cyMroinI0@public.gmane.org>
Hi Grygorii,
On Mon, Nov 24, 2014 at 03:15:58PM +0200, Grygorii Strashko wrote:
> On 11/23/2014 07:04 PM, Uwe Kleine-König wrote:
> > On Thu, Nov 20, 2014 at 12:03:08PM +0200, Grygorii Strashko wrote:
> >> @@ -664,6 +759,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> >> if (!of_property_read_u32(pdev->dev.of_node, "clock-frequency",
> >> &prop))
> >> dev->pdata->bus_freq = prop / 1000;
> >> + dev->pdata->has_pfunc = true;
> > I don't understand this. Why does this ICPFUNC recovery work if the bus
> > is probed by oftree, but doesn't if not?
>
> I've mentioned this in commit message:
> Allow platforms to indicate the presence of the ICPFUNC registers with a has_pfunc
> platform data flag and enable this mode for platforms which supports DT (da850 and
> Keystone 2 are two SoCs which support DT now and they also support ICPFUNC registers).
Ah, so you assume that in the dt case the pfunc functionality is
available. I didn't understand if it's bad or not if this assumption is
wrong, but I suggest to only use the pfunc stuff if the device node has
a given property (e.g. ti,has_pfunc).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-11-24 19:45 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 10:03 [PATCH 0/5] i2c: davinci improvements and fixes Grygorii Strashko
2014-11-20 10:03 ` Grygorii Strashko
2014-11-20 10:03 ` [PATCH 1/5] i2c: i2c-davinci: switch to use platform_get_irq Grygorii Strashko
2014-11-20 10:03 ` Grygorii Strashko
2014-11-20 21:48 ` [1/5] " Uwe Kleine-König
2014-11-21 11:01 ` Grygorii Strashko
2014-11-21 11:01 ` Grygorii Strashko
2014-11-21 14:03 ` Rob Herring
2014-11-21 14:03 ` Rob Herring
2014-11-21 14:59 ` Grygorii Strashko
2014-11-20 10:03 ` [PATCH 2/5] i2c: davinci: query STP always when NACK is received Grygorii Strashko
2014-11-20 10:03 ` Grygorii Strashko
2014-11-20 22:19 ` [2/5] " Uwe Kleine-König
2014-11-20 22:19 ` Uwe Kleine-König
2014-11-21 12:48 ` Grygorii Strashko
2014-11-21 12:48 ` Grygorii Strashko
2014-11-21 13:10 ` Uwe Kleine-König
2014-11-21 13:10 ` Uwe Kleine-König
2014-11-21 15:33 ` Grygorii Strashko
2014-11-21 15:33 ` Grygorii Strashko
2014-11-23 20:33 ` Uwe Kleine-König
2014-11-23 20:33 ` Uwe Kleine-König
2014-11-24 13:34 ` Grygorii Strashko
2014-11-24 13:34 ` Grygorii Strashko
2014-11-24 20:02 ` Uwe Kleine-König
2014-11-24 20:02 ` Uwe Kleine-König
2014-11-20 10:03 ` [PATCH 3/5] i2c: recovery: change input parameter to i2c_adapter for prepare/unprepare_recovery Grygorii Strashko
2014-11-20 10:03 ` Grygorii Strashko
2014-11-21 18:49 ` [3/5] " Uwe Kleine-König
2014-11-21 18:49 ` Uwe Kleine-König
2014-11-20 10:03 ` [PATCH 4/5] i2c: davinci: use bus recovery infrastructure Grygorii Strashko
2014-11-20 10:03 ` Grygorii Strashko
2014-11-21 19:07 ` [4/5] " Uwe Kleine-König
2014-11-21 19:07 ` Uwe Kleine-König
2014-11-21 19:33 ` Grygorii Strashko
2014-11-21 19:33 ` Grygorii Strashko
2014-11-23 20:36 ` Uwe Kleine-König
2014-11-23 20:36 ` Uwe Kleine-König
2014-11-24 13:26 ` Grygorii Strashko
2014-11-24 13:26 ` Grygorii Strashko
2014-11-24 20:07 ` Uwe Kleine-König
2014-11-24 20:07 ` Uwe Kleine-König
2014-11-20 10:03 ` [PATCH 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery Grygorii Strashko
2014-11-20 10:03 ` Grygorii Strashko
2014-11-23 17:04 ` [5/5] " Uwe Kleine-König
2014-11-23 17:04 ` Uwe Kleine-König
2014-11-24 13:15 ` Grygorii Strashko
2014-11-24 13:15 ` Grygorii Strashko
2014-11-24 18:13 ` Mike Looijmans
2014-11-24 18:13 ` Mike Looijmans
2014-11-24 19:22 ` Grygorii Strashko
2014-11-24 19:22 ` Grygorii Strashko
2014-11-24 19:45 ` Uwe Kleine-König [this message]
2014-11-24 19:45 ` Uwe Kleine-König
2014-11-25 13:04 ` Grygorii Strashko
2014-11-25 13:04 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124194533.GU4431@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bengardiner@nanometrics.ca \
--cc=grygorii.strashko@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=milo-software@users.sourceforge.net \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.