From: Peter Griffin <peter.griffin@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
broonie@kernel.org, kernel@stlinux.com,
linux-spi@vger.kernel.org
Subject: Re: [STLinux Kernel] [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller
Date: Thu, 27 Nov 2014 12:33:34 +0000 [thread overview]
Message-ID: <20141127123334.GA20048@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <1417088636-11994-2-git-send-email-lee.jones@linaro.org>
Hi Lee,
<snip>
> +static int spi_st_probe(struct platform_device *pdev)
> +{
> + struct device_node *np = pdev->dev.of_node;
> + struct device *dev = &pdev->dev;
> + struct spi_master *master;
> + struct resource *res;
> + struct spi_st *spi_st;
> + int num_cs, cs_gpio, i, ret = 0;
> + u32 var;
> +
> + printk("LEE: %s: %s()[%d]: Probing\n", __FILE__, __func__, __LINE__);
You've left a debug print in here.
regards,
Peter.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Griffin <peter.griffin@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: devicetree@vger.kernel.org, kernel@stlinux.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
broonie@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [STLinux Kernel] [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller
Date: Thu, 27 Nov 2014 12:33:34 +0000 [thread overview]
Message-ID: <20141127123334.GA20048@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <1417088636-11994-2-git-send-email-lee.jones@linaro.org>
Hi Lee,
<snip>
> +static int spi_st_probe(struct platform_device *pdev)
> +{
> + struct device_node *np = pdev->dev.of_node;
> + struct device *dev = &pdev->dev;
> + struct spi_master *master;
> + struct resource *res;
> + struct spi_st *spi_st;
> + int num_cs, cs_gpio, i, ret = 0;
> + u32 var;
> +
> + printk("LEE: %s: %s()[%d]: Probing\n", __FILE__, __func__, __LINE__);
You've left a debug print in here.
regards,
Peter.
WARNING: multiple messages have this Message-ID (diff)
From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [STLinux Kernel] [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller
Date: Thu, 27 Nov 2014 12:33:34 +0000 [thread overview]
Message-ID: <20141127123334.GA20048@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <1417088636-11994-2-git-send-email-lee.jones@linaro.org>
Hi Lee,
<snip>
> +static int spi_st_probe(struct platform_device *pdev)
> +{
> + struct device_node *np = pdev->dev.of_node;
> + struct device *dev = &pdev->dev;
> + struct spi_master *master;
> + struct resource *res;
> + struct spi_st *spi_st;
> + int num_cs, cs_gpio, i, ret = 0;
> + u32 var;
> +
> + printk("LEE: %s: %s()[%d]: Probing\n", __FILE__, __func__, __LINE__);
You've left a debug print in here.
regards,
Peter.
next prev parent reply other threads:[~2014-11-27 12:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 11:43 [PATCH 0/4] spi: st: New driver for ST's SPI Controller Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` [PATCH 1/4] spi: Add new driver for STMicroelectronics' " Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 12:33 ` Peter Griffin [this message]
2014-11-27 12:33 ` [STLinux Kernel] " Peter Griffin
2014-11-27 12:33 ` Peter Griffin
2014-11-27 12:59 ` Mark Brown
2014-11-27 12:59 ` Mark Brown
2014-11-27 12:59 ` Mark Brown
2014-11-27 15:05 ` Lee Jones
2014-11-27 15:05 ` Lee Jones
2014-11-27 15:05 ` Lee Jones
2014-11-27 16:24 ` Mark Brown
2014-11-27 16:24 ` Mark Brown
2014-11-27 16:24 ` Mark Brown
2014-11-27 13:24 ` Maxime Coquelin
2014-11-27 13:24 ` Maxime Coquelin
2014-11-27 13:24 ` Maxime Coquelin
2014-11-27 13:24 ` Maxime Coquelin
2014-11-27 11:43 ` [PATCH 2/4] spi: st: Provide Device Tree binding documentation Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 13:00 ` Mark Brown
2014-11-27 13:00 ` Mark Brown
2014-11-27 13:00 ` Mark Brown
2014-11-27 14:55 ` Lee Jones
2014-11-27 14:55 ` Lee Jones
2014-11-27 14:55 ` Lee Jones
2014-11-27 16:30 ` Mark Brown
2014-11-27 16:30 ` Mark Brown
2014-11-27 16:30 ` Mark Brown
2014-11-27 11:43 ` [PATCH 3/4] ARM: sti: Provide DT nodes for SSC[0..4] Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` [PATCH 4/4] ARM: sti: Provide DT nodes for SBC SSC[0..2] Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127123334.GA20048@griffinp-ThinkPad-X1-Carbon-2nd \
--to=peter.griffin@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.