From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller
Date: Thu, 27 Nov 2014 16:24:59 +0000 [thread overview]
Message-ID: <20141127162459.GY7712@sirena.org.uk> (raw)
In-Reply-To: <20141127150508.GI4628@x1>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Thu, Nov 27, 2014 at 03:05:08PM +0000, Lee Jones wrote:
> > > + /* Set SSC_CTL to 16 bits-per-word */
> > > + ctl = readl_relaxed(spi_st->base + SSC_CTL);
> > > + writel_relaxed((ctl | 0xf), spi_st->base + SSC_CTL);
> > > + readl_relaxed(spi_st->base + SSC_RBUF);
> > No byte swapping issues here?
> I think this implementation has been pretty heavily tested. What
> should I be looking out for?
The bytes on the bus should be in exactly the same order as in memory if
the word size is 8, SPI words should be big endian normally.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller
Date: Thu, 27 Nov 2014 16:24:59 +0000 [thread overview]
Message-ID: <20141127162459.GY7712@sirena.org.uk> (raw)
In-Reply-To: <20141127150508.GI4628@x1>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Thu, Nov 27, 2014 at 03:05:08PM +0000, Lee Jones wrote:
> > > + /* Set SSC_CTL to 16 bits-per-word */
> > > + ctl = readl_relaxed(spi_st->base + SSC_CTL);
> > > + writel_relaxed((ctl | 0xf), spi_st->base + SSC_CTL);
> > > + readl_relaxed(spi_st->base + SSC_RBUF);
> > No byte swapping issues here?
> I think this implementation has been pretty heavily tested. What
> should I be looking out for?
The bytes on the bus should be in exactly the same order as in memory if
the word size is 8, SPI words should be big endian normally.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller
Date: Thu, 27 Nov 2014 16:24:59 +0000 [thread overview]
Message-ID: <20141127162459.GY7712@sirena.org.uk> (raw)
In-Reply-To: <20141127150508.GI4628@x1>
On Thu, Nov 27, 2014 at 03:05:08PM +0000, Lee Jones wrote:
> > > + /* Set SSC_CTL to 16 bits-per-word */
> > > + ctl = readl_relaxed(spi_st->base + SSC_CTL);
> > > + writel_relaxed((ctl | 0xf), spi_st->base + SSC_CTL);
> > > + readl_relaxed(spi_st->base + SSC_RBUF);
> > No byte swapping issues here?
> I think this implementation has been pretty heavily tested. What
> should I be looking out for?
The bytes on the bus should be in exactly the same order as in memory if
the word size is 8, SPI words should be big endian normally.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141127/23236c2a/attachment.sig>
next prev parent reply other threads:[~2014-11-27 16:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 11:43 [PATCH 0/4] spi: st: New driver for ST's SPI Controller Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` [PATCH 1/4] spi: Add new driver for STMicroelectronics' " Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 12:33 ` [STLinux Kernel] " Peter Griffin
2014-11-27 12:33 ` Peter Griffin
2014-11-27 12:33 ` Peter Griffin
2014-11-27 12:59 ` Mark Brown
2014-11-27 12:59 ` Mark Brown
2014-11-27 12:59 ` Mark Brown
2014-11-27 15:05 ` Lee Jones
2014-11-27 15:05 ` Lee Jones
2014-11-27 15:05 ` Lee Jones
2014-11-27 16:24 ` Mark Brown [this message]
2014-11-27 16:24 ` Mark Brown
2014-11-27 16:24 ` Mark Brown
2014-11-27 13:24 ` Maxime Coquelin
2014-11-27 13:24 ` Maxime Coquelin
2014-11-27 13:24 ` Maxime Coquelin
2014-11-27 13:24 ` Maxime Coquelin
2014-11-27 11:43 ` [PATCH 2/4] spi: st: Provide Device Tree binding documentation Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 13:00 ` Mark Brown
2014-11-27 13:00 ` Mark Brown
2014-11-27 13:00 ` Mark Brown
2014-11-27 14:55 ` Lee Jones
2014-11-27 14:55 ` Lee Jones
2014-11-27 14:55 ` Lee Jones
2014-11-27 16:30 ` Mark Brown
2014-11-27 16:30 ` Mark Brown
2014-11-27 16:30 ` Mark Brown
2014-11-27 11:43 ` [PATCH 3/4] ARM: sti: Provide DT nodes for SSC[0..4] Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` [PATCH 4/4] ARM: sti: Provide DT nodes for SBC SSC[0..2] Lee Jones
2014-11-27 11:43 ` Lee Jones
2014-11-27 11:43 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127162459.GY7712@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.