All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Hui Zhu <zhuhui@xiaomi.com>
Cc: m.szyprowski@samsung.com, mina86@mina86.com,
	akpm@linux-foundation.org, aneesh.kumar@linux.vnet.ibm.com,
	pintu.k@samsung.com, weijie.yang@samsung.com, mgorman@suse.de,
	hannes@cmpxchg.org, riel@redhat.com, vbabka@suse.cz,
	laurent.pinchart+renesas@ideasonboard.com, rientjes@google.com,
	sasha.levin@oracle.com, liuweixing@xiaomi.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	teawater@gmail.com
Subject: Re: [PATCH 3/3] CMA: Add cma_alloc_counter to make cma_alloc work better if it meet busy range
Date: Tue, 30 Dec 2014 14:00:38 +0900	[thread overview]
Message-ID: <20141230050038.GD4588@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <1419500608-11656-4-git-send-email-zhuhui@xiaomi.com>

On Thu, Dec 25, 2014 at 05:43:28PM +0800, Hui Zhu wrote:
> In [1], Joonsoo said that cma_alloc_counter is useless because pageblock
> is isolated.
> But if alloc_contig_range meet a busy range, it will undo_isolate_page_range
> before goto try next range. At this time, __rmqueue_cma can begin allocd
> CMA memory from the range.

Is there any real issue from this?
When failed, we will quickly re-isolate pageblock for adjacent page
so there is no big problem I guess.

If there is real issue, how about doing start_isolation/undo_isolation
in cma_alloc()? It would reduce useless do/undo isolation due to
failed trial.

Thanks.


WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Hui Zhu <zhuhui@xiaomi.com>
Cc: m.szyprowski@samsung.com, mina86@mina86.com,
	akpm@linux-foundation.org, aneesh.kumar@linux.vnet.ibm.com,
	pintu.k@samsung.com, weijie.yang@samsung.com, mgorman@suse.de,
	hannes@cmpxchg.org, riel@redhat.com, vbabka@suse.cz,
	laurent.pinchart+renesas@ideasonboard.com, rientjes@google.com,
	sasha.levin@oracle.com, liuweixing@xiaomi.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	teawater@gmail.com
Subject: Re: [PATCH 3/3] CMA: Add cma_alloc_counter to make cma_alloc work better if it meet busy range
Date: Tue, 30 Dec 2014 14:00:38 +0900	[thread overview]
Message-ID: <20141230050038.GD4588@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <1419500608-11656-4-git-send-email-zhuhui@xiaomi.com>

On Thu, Dec 25, 2014 at 05:43:28PM +0800, Hui Zhu wrote:
> In [1], Joonsoo said that cma_alloc_counter is useless because pageblock
> is isolated.
> But if alloc_contig_range meet a busy range, it will undo_isolate_page_range
> before goto try next range. At this time, __rmqueue_cma can begin allocd
> CMA memory from the range.

Is there any real issue from this?
When failed, we will quickly re-isolate pageblock for adjacent page
so there is no big problem I guess.

If there is real issue, how about doing start_isolation/undo_isolation
in cma_alloc()? It would reduce useless do/undo isolation due to
failed trial.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-12-30  5:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-25  9:43 [PATCH 0/3] CMA: Handle the issues of aggressively allocate the Hui Zhu
2014-12-25  9:43 ` Hui Zhu
2014-12-25  9:43 ` [PATCH 1/3] CMA: Fix the bug that CMA's page number is substructed twice Hui Zhu
2014-12-25  9:43   ` Hui Zhu
2014-12-30  4:48   ` Joonsoo Kim
2014-12-30  4:48     ` Joonsoo Kim
2014-12-30 10:02     ` Hui Zhu
2014-12-30 10:02       ` Hui Zhu
2014-12-25  9:43 ` [PATCH 2/3] CMA: Fix the issue that nr_try_movable just count MIGRATE_MOVABLE memory Hui Zhu
2014-12-25  9:43   ` Hui Zhu
2014-12-25  9:43 ` [PATCH 3/3] CMA: Add cma_alloc_counter to make cma_alloc work better if it meet busy range Hui Zhu
2014-12-25  9:43   ` Hui Zhu
2014-12-30  5:00   ` Joonsoo Kim [this message]
2014-12-30  5:00     ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141230050038.GD4588@js1304-P5Q-DELUXE \
    --to=iamjoonsoo.kim@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=hannes@cmpxchg.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuweixing@xiaomi.com \
    --cc=m.szyprowski@samsung.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=pintu.k@samsung.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=sasha.levin@oracle.com \
    --cc=teawater@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=weijie.yang@samsung.com \
    --cc=zhuhui@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.