All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Hui Zhu <zhuhui@xiaomi.com>,
	m.szyprowski@samsung.com, mina86@mina86.com,
	Andrew Morton <akpm@linux-foundation.org>,
	aneesh.kumar@linux.vnet.ibm.com, pintu.k@samsung.com,
	weijie.yang@samsung.com, mgorman@suse.de, hannes@cmpxchg.org,
	Rik van Riel <riel@redhat.com>,
	vbabka@suse.cz, laurent.pinchart+renesas@ideasonboard.com,
	rientjes@google.com, sasha.levin@oracle.com,
	liuweixing@xiaomi.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH 1/3] CMA: Fix the bug that CMA's page number is substructed twice
Date: Tue, 30 Dec 2014 18:02:09 +0800	[thread overview]
Message-ID: <CANFwon3U+chGmvLG_HdMf5_0Mb5OEEJSOUr+oPB5+US3rnfguA@mail.gmail.com> (raw)
In-Reply-To: <20141230044826.GC4588@js1304-P5Q-DELUXE>

On Tue, Dec 30, 2014 at 12:48 PM, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> On Thu, Dec 25, 2014 at 05:43:26PM +0800, Hui Zhu wrote:
>> In Joonsoo's CMA patch "CMA: always treat free cma pages as non-free on
>> watermark checking" [1], it changes __zone_watermark_ok to substruct CMA
>> pages number from free_pages if system use CMA:
>>       if (IS_ENABLED(CONFIG_CMA) && z->managed_cma_pages)
>>               free_pages -= zone_page_state(z, NR_FREE_CMA_PAGES);
>
> Hello,
>
> In fact, without that patch, watermark checking has a problem in current kernel.
> If there is reserved CMA region, watermark check for high order
> allocation is done loosly. See following thread.
>
> https://lkml.org/lkml/2014/5/30/320
>
> Your patch can fix this situation, so, how about submitting this patch
> separately?
>
> Thanks.
>

Hi Joonsoo,

Thanks for your remind.  I will post a separate patch for current kernel.

Thanks,
Hui

WARNING: multiple messages have this Message-ID (diff)
From: Hui Zhu <teawater@gmail.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Hui Zhu <zhuhui@xiaomi.com>,
	m.szyprowski@samsung.com, mina86@mina86.com,
	Andrew Morton <akpm@linux-foundation.org>,
	aneesh.kumar@linux.vnet.ibm.com, pintu.k@samsung.com,
	weijie.yang@samsung.com, mgorman@suse.de, hannes@cmpxchg.org,
	Rik van Riel <riel@redhat.com>,
	vbabka@suse.cz, laurent.pinchart+renesas@ideasonboard.com,
	rientjes@google.com, sasha.levin@oracle.com,
	liuweixing@xiaomi.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH 1/3] CMA: Fix the bug that CMA's page number is substructed twice
Date: Tue, 30 Dec 2014 18:02:09 +0800	[thread overview]
Message-ID: <CANFwon3U+chGmvLG_HdMf5_0Mb5OEEJSOUr+oPB5+US3rnfguA@mail.gmail.com> (raw)
In-Reply-To: <20141230044826.GC4588@js1304-P5Q-DELUXE>

On Tue, Dec 30, 2014 at 12:48 PM, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> On Thu, Dec 25, 2014 at 05:43:26PM +0800, Hui Zhu wrote:
>> In Joonsoo's CMA patch "CMA: always treat free cma pages as non-free on
>> watermark checking" [1], it changes __zone_watermark_ok to substruct CMA
>> pages number from free_pages if system use CMA:
>>       if (IS_ENABLED(CONFIG_CMA) && z->managed_cma_pages)
>>               free_pages -= zone_page_state(z, NR_FREE_CMA_PAGES);
>
> Hello,
>
> In fact, without that patch, watermark checking has a problem in current kernel.
> If there is reserved CMA region, watermark check for high order
> allocation is done loosly. See following thread.
>
> https://lkml.org/lkml/2014/5/30/320
>
> Your patch can fix this situation, so, how about submitting this patch
> separately?
>
> Thanks.
>

Hi Joonsoo,

Thanks for your remind.  I will post a separate patch for current kernel.

Thanks,
Hui

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-12-30 10:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-25  9:43 [PATCH 0/3] CMA: Handle the issues of aggressively allocate the Hui Zhu
2014-12-25  9:43 ` Hui Zhu
2014-12-25  9:43 ` [PATCH 1/3] CMA: Fix the bug that CMA's page number is substructed twice Hui Zhu
2014-12-25  9:43   ` Hui Zhu
2014-12-30  4:48   ` Joonsoo Kim
2014-12-30  4:48     ` Joonsoo Kim
2014-12-30 10:02     ` Hui Zhu [this message]
2014-12-30 10:02       ` Hui Zhu
2014-12-25  9:43 ` [PATCH 2/3] CMA: Fix the issue that nr_try_movable just count MIGRATE_MOVABLE memory Hui Zhu
2014-12-25  9:43   ` Hui Zhu
2014-12-25  9:43 ` [PATCH 3/3] CMA: Add cma_alloc_counter to make cma_alloc work better if it meet busy range Hui Zhu
2014-12-25  9:43   ` Hui Zhu
2014-12-30  5:00   ` Joonsoo Kim
2014-12-30  5:00     ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANFwon3U+chGmvLG_HdMf5_0Mb5OEEJSOUr+oPB5+US3rnfguA@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuweixing@xiaomi.com \
    --cc=m.szyprowski@samsung.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=pintu.k@samsung.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=sasha.levin@oracle.com \
    --cc=vbabka@suse.cz \
    --cc=weijie.yang@samsung.com \
    --cc=zhuhui@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.