From: Lee Jones <lee.jones@linaro.org> To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: Linus Walleij <linus.walleij@linaro.org>, Russell King <linux@arm.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: ux500: Move struct Date: Thu, 22 Jan 2015 07:44:58 +0000 [thread overview] Message-ID: <20150122074458.GL22024@x1> (raw) In-Reply-To: <1421881782-23716-1-git-send-email-rickard_strandqvist@spectrumdigital.se> The subject line is not a good one. Please elaborate. > Move struct ab8500_ext_regulator_cfg to the only file that is now used in. Attention to detail --^ > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/regulator/ab8500-ext.c | 6 ++++++ > include/linux/regulator/ab8500.h | 5 ----- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/regulator/ab8500-ext.c b/drivers/regulator/ab8500-ext.c > index 84c1ee3..a40c701 100644 > --- a/drivers/regulator/ab8500-ext.c > +++ b/drivers/regulator/ab8500-ext.c > @@ -25,6 +25,12 @@ > #include <linux/mfd/abx500/ab8500.h> > #include <linux/regulator/ab8500.h> > > + Superfluous '\n'. > +/* AB8500 external regulators */ No need for this commit now. > +struct ab8500_ext_regulator_cfg { > + bool hwreq; /* requires hw mode or high power mode */ > +}; > + Are you sure a struct is required at all now? It only contains a single bool after all. > /** > * struct ab8500_ext_regulator_info - ab8500 regulator information > * @dev: device pointer > diff --git a/include/linux/regulator/ab8500.h b/include/linux/regulator/ab8500.h > index d8ecefa..802529b 100644 > --- a/include/linux/regulator/ab8500.h > +++ b/include/linux/regulator/ab8500.h > @@ -300,11 +300,6 @@ enum ab8540_regulator_reg { > AB8540_NUM_REGULATOR_REGISTERS, > }; > > -/* AB8500 external regulators */ > -struct ab8500_ext_regulator_cfg { > - bool hwreq; /* requires hw mode or high power mode */ > -}; > - > enum ab8500_ext_regulator_id { > AB8500_EXT_SUPPLY1, > AB8500_EXT_SUPPLY2, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] ARM: ux500: Move struct Date: Thu, 22 Jan 2015 07:44:58 +0000 [thread overview] Message-ID: <20150122074458.GL22024@x1> (raw) In-Reply-To: <1421881782-23716-1-git-send-email-rickard_strandqvist@spectrumdigital.se> The subject line is not a good one. Please elaborate. > Move struct ab8500_ext_regulator_cfg to the only file that is now used in. Attention to detail --^ > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/regulator/ab8500-ext.c | 6 ++++++ > include/linux/regulator/ab8500.h | 5 ----- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/regulator/ab8500-ext.c b/drivers/regulator/ab8500-ext.c > index 84c1ee3..a40c701 100644 > --- a/drivers/regulator/ab8500-ext.c > +++ b/drivers/regulator/ab8500-ext.c > @@ -25,6 +25,12 @@ > #include <linux/mfd/abx500/ab8500.h> > #include <linux/regulator/ab8500.h> > > + Superfluous '\n'. > +/* AB8500 external regulators */ No need for this commit now. > +struct ab8500_ext_regulator_cfg { > + bool hwreq; /* requires hw mode or high power mode */ > +}; > + Are you sure a struct is required at all now? It only contains a single bool after all. > /** > * struct ab8500_ext_regulator_info - ab8500 regulator information > * @dev: device pointer > diff --git a/include/linux/regulator/ab8500.h b/include/linux/regulator/ab8500.h > index d8ecefa..802529b 100644 > --- a/include/linux/regulator/ab8500.h > +++ b/include/linux/regulator/ab8500.h > @@ -300,11 +300,6 @@ enum ab8540_regulator_reg { > AB8540_NUM_REGULATOR_REGISTERS, > }; > > -/* AB8500 external regulators */ > -struct ab8500_ext_regulator_cfg { > - bool hwreq; /* requires hw mode or high power mode */ > -}; > - > enum ab8500_ext_regulator_id { > AB8500_EXT_SUPPLY1, > AB8500_EXT_SUPPLY2, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-01-22 7:45 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-21 23:09 [PATCH 1/2] ARM: ux500: Move struct Rickard Strandqvist 2015-01-21 23:09 ` Rickard Strandqvist 2015-01-21 23:09 ` [PATCH 2/2] ARM: ux500: Remove unused functions and structs Rickard Strandqvist 2015-01-21 23:09 ` Rickard Strandqvist 2015-01-22 7:49 ` Lee Jones 2015-01-22 7:49 ` Lee Jones 2015-01-22 7:44 ` Lee Jones [this message] 2015-01-22 7:44 ` [PATCH 1/2] ARM: ux500: Move struct Lee Jones 2015-01-24 17:33 ` Rickard Strandqvist 2015-01-24 17:33 ` Rickard Strandqvist 2015-01-24 21:40 ` Arnd Bergmann 2015-01-24 21:40 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150122074458.GL22024@x1 \ --to=lee.jones@linaro.org \ --cc=arnd@arndb.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=rickard_strandqvist@spectrumdigital.se \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.