All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Sebastian Reichel <sre@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Pavel Machek <pavel@ucw.cz>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 0/4] Drop legacy support for omap3517
Date: Sat, 24 Jan 2015 23:14:58 +0100	[thread overview]
Message-ID: <201501242314.58201@pali> (raw)
In-Reply-To: <2871852.qm0MoZvdlF@wuerfel>

[-- Attachment #1: Type: Text/Plain, Size: 1044 bytes --]

On Saturday 24 January 2015 23:08:00 Arnd Bergmann wrote:
> On Saturday 24 January 2015 13:00:00 Pali Rohár wrote:
> > Another regression for DT setup (which does not occur for
> > board code):
> > 
> > omap_hsmmc driver does not export slot_name sysfs entry
> > because it not supported by DT yet. Entry slot_name is used
> > by userspace application to determinate if mmc block device
> > is internal eMMC memory or external uSD card. So support
> > for this property also in DT is needed.
> 
> > Here is simple patch which fix this problem:
> The sysfs file only exists for the two OMAP drivers, and the
> naming is used only by board-n8x0, board-rx51 and
> board-omap3logic.
> 
> It may be better to add a board-specific hack for these to
> keep the existing user space working but not spread the use
> of this file anywhere else.
> 
> 	Arnd

Why? omap_hsmmc.c has already support for slot_name sysfs entry, 
just it is not filled from DT data (only from platform_data)...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Drop legacy support for omap3517
Date: Sat, 24 Jan 2015 23:14:58 +0100	[thread overview]
Message-ID: <201501242314.58201@pali> (raw)
In-Reply-To: <2871852.qm0MoZvdlF@wuerfel>

On Saturday 24 January 2015 23:08:00 Arnd Bergmann wrote:
> On Saturday 24 January 2015 13:00:00 Pali Roh?r wrote:
> > Another regression for DT setup (which does not occur for
> > board code):
> > 
> > omap_hsmmc driver does not export slot_name sysfs entry
> > because it not supported by DT yet. Entry slot_name is used
> > by userspace application to determinate if mmc block device
> > is internal eMMC memory or external uSD card. So support
> > for this property also in DT is needed.
> 
> > Here is simple patch which fix this problem:
> The sysfs file only exists for the two OMAP drivers, and the
> naming is used only by board-n8x0, board-rx51 and
> board-omap3logic.
> 
> It may be better to add a board-specific hack for these to
> keep the existing user space working but not spread the use
> of this file anywhere else.
> 
> 	Arnd

Why? omap_hsmmc.c has already support for slot_name sysfs entry, 
just it is not filled from DT data (only from platform_data)...

-- 
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150124/9901f95a/attachment.sig>

  reply	other threads:[~2015-01-24 22:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 17:57 [PATCH 0/4] Drop legacy support for omap3517 Tony Lindgren
2015-01-13 17:57 ` Tony Lindgren
2015-01-13 17:57 ` [PATCH 1/4] ARM: OMAP3: Remove legacy support for am3517-evm Tony Lindgren
2015-01-13 17:57   ` Tony Lindgren
2015-01-13 17:57 ` [PATCH 2/4] ARM: OMAP3: Remove legacy support for am3517crane Tony Lindgren
2015-01-13 17:57   ` Tony Lindgren
2015-01-13 17:57 ` [PATCH 3/4] ARM: OMAP3: Remove cm-t3517 legacy support Tony Lindgren
2015-01-13 17:57   ` Tony Lindgren
2015-01-13 17:57 ` [PATCH 4/4] ARM: OMAP3: Remove legacy support for am35xx-emac Tony Lindgren
2015-01-13 17:57   ` Tony Lindgren
2015-01-13 20:24 ` [PATCH 0/4] Drop legacy support for omap3517 Arnd Bergmann
2015-01-13 20:24   ` Arnd Bergmann
2015-01-13 20:42   ` Tony Lindgren
2015-01-13 20:42     ` Tony Lindgren
2015-01-13 20:50     ` Pali Rohár
2015-01-13 20:50       ` Pali Rohár
2015-01-18 21:02       ` Pavel Machek
2015-01-18 21:02         ` Pavel Machek
2015-01-18 22:29         ` Sebastian Reichel
2015-01-18 22:29           ` Sebastian Reichel
2015-01-15 14:25     ` Sebastian Reichel
2015-01-15 14:25       ` Sebastian Reichel
2015-01-24 12:00       ` Pali Rohár
2015-01-24 12:00         ` Pali Rohár
2015-01-24 22:08         ` Arnd Bergmann
2015-01-24 22:08           ` Arnd Bergmann
2015-01-24 22:14           ` Pali Rohár [this message]
2015-01-24 22:14             ` Pali Rohár
2015-01-26 10:16             ` Arnd Bergmann
2015-01-26 10:16               ` Arnd Bergmann
2015-01-25 21:23           ` Pavel Machek
2015-01-25 21:23             ` Pavel Machek
2015-01-25 15:18         ` Sebastian Reichel
2015-01-25 15:18           ` Sebastian Reichel
2015-01-25 21:22         ` Pavel Machek
2015-01-25 21:22           ` Pavel Machek
2015-01-25 21:49           ` Sebastian Reichel
2015-01-25 21:49             ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201501242314.58201@pali \
    --to=pali.rohar@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=arnd@arndb.de \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.