[PATCH] mm/zsmalloc: add log for module load/unload

[PATCH] mm/zsmalloc: add log for module load/unload

[Ganesh Mahendran]

Sometimes, we want to know whether a module is loaded or unloaded
from the log.

This patch adds some log.

Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Minchan Kim <minchan@kernel.org>
---
 mm/zsmalloc.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 2d5f5be..16617e9 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -72,6 +72,8 @@
  *
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #ifdef CONFIG_ZSMALLOC_DEBUG
 #define DEBUG
 #endif
@@ -1460,6 +1462,8 @@ static int __init zs_init(void)
 {
 	int ret = zs_register_cpu_notifier();
 
+	pr_info("loaded\n");
+
 	if (ret)
 		goto notifier_fail;
 
@@ -1474,6 +1478,7 @@ static int __init zs_init(void)
 		pr_err("zs stat initialization failed\n");
 		goto stat_fail;
 	}
+
 	return 0;
 
 stat_fail:
@@ -1483,6 +1488,8 @@ stat_fail:
 notifier_fail:
 	zs_unregister_cpu_notifier();
 
+	pr_info("unloaded\n");
+
 	return ret;
 }
 
-- 
1.7.9.5

[PATCH] mm/zsmalloc: add log for module load/unload

[Ganesh Mahendran]

Sometimes, we want to know whether a module is loaded or unloaded
from the log.

This patch adds some log.

Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Minchan Kim <minchan@kernel.org>
---
 mm/zsmalloc.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 2d5f5be..16617e9 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -72,6 +72,8 @@
  *
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #ifdef CONFIG_ZSMALLOC_DEBUG
 #define DEBUG
 #endif
@@ -1460,6 +1462,8 @@ static int __init zs_init(void)
 {
 	int ret = zs_register_cpu_notifier();
 
+	pr_info("loaded\n");
+
 	if (ret)
 		goto notifier_fail;
 
@@ -1474,6 +1478,7 @@ static int __init zs_init(void)
 		pr_err("zs stat initialization failed\n");
 		goto stat_fail;
 	}
+
 	return 0;
 
 stat_fail:
@@ -1483,6 +1488,8 @@ stat_fail:
 notifier_fail:
 	zs_unregister_cpu_notifier();
 
+	pr_info("unloaded\n");
+
 	return ret;
 }
 
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/zsmalloc: add log for module load/unload

[Andrew Morton]

On Sat, 24 Jan 2015 21:48:41 +0800 Ganesh Mahendran <opensource.ganesh@gmail.com> wrote:

> Sometimes, we want to know whether a module is loaded or unloaded
> from the log.

Why?  What's special about zsmalloc?

Please provide much better justification than this.

Re: [PATCH] mm/zsmalloc: add log for module load/unload

[Andrew Morton]

On Sat, 24 Jan 2015 21:48:41 +0800 Ganesh Mahendran <opensource.ganesh@gmail.com> wrote:

> Sometimes, we want to know whether a module is loaded or unloaded
> from the log.

Why?  What's special about zsmalloc?

Please provide much better justification than this.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/zsmalloc: add log for module load/unload

[Ganesh Mahendran]

Hello, Andrew

2015-01-27 7:19 GMT+08:00 Andrew Morton <akpm@linux-foundation.org>:
> On Sat, 24 Jan 2015 21:48:41 +0800 Ganesh Mahendran <opensource.ganesh@gmail.com> wrote:
>
>> Sometimes, we want to know whether a module is loaded or unloaded
>> from the log.
>
> Why?  What's special about zsmalloc?
>
> Please provide much better justification than this.

When I debug with the zsmalloc module built in kernel.
After system boots up, I did not see:
/sys/kernel/debug/zsmalloc dir.

Although the reason for this is that I made a mistake. I
forgot to add debugfs entry in /etc/fstab.
But I think it is suitable to add information for a module load/unload.
Then we can get this by:
dmesg | grep zsmalloc.

Thanks.

Re: [PATCH] mm/zsmalloc: add log for module load/unload

[Ganesh Mahendran]

Hello, Andrew

2015-01-27 7:19 GMT+08:00 Andrew Morton <akpm@linux-foundation.org>:
> On Sat, 24 Jan 2015 21:48:41 +0800 Ganesh Mahendran <opensource.ganesh@gmail.com> wrote:
>
>> Sometimes, we want to know whether a module is loaded or unloaded
>> from the log.
>
> Why?  What's special about zsmalloc?
>
> Please provide much better justification than this.

When I debug with the zsmalloc module built in kernel.
After system boots up, I did not see:
/sys/kernel/debug/zsmalloc dir.

Although the reason for this is that I made a mistake. I
forgot to add debugfs entry in /etc/fstab.
But I think it is suitable to add information for a module load/unload.
Then we can get this by:
dmesg | grep zsmalloc.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/zsmalloc: add log for module load/unload

[Minchan Kim]

Hello Ganesh,

On Tue, Jan 27, 2015 at 10:07:53AM +0800, Ganesh Mahendran wrote:
> Hello, Andrew
> 
> 2015-01-27 7:19 GMT+08:00 Andrew Morton <akpm@linux-foundation.org>:
> > On Sat, 24 Jan 2015 21:48:41 +0800 Ganesh Mahendran <opensource.ganesh@gmail.com> wrote:
> >
> >> Sometimes, we want to know whether a module is loaded or unloaded
> >> from the log.
> >
> > Why?  What's special about zsmalloc?
> >
> > Please provide much better justification than this.
> 
> When I debug with the zsmalloc module built in kernel.
> After system boots up, I did not see:
> /sys/kernel/debug/zsmalloc dir.
> 
> Although the reason for this is that I made a mistake. I
> forgot to add debugfs entry in /etc/fstab.
> But I think it is suitable to add information for a module load/unload.
> Then we can get this by:
> dmesg | grep zsmalloc.

I understand your trouble but it's general problem, not zsmalloc specific.
Then, if you really want to fix, you should approach more generic ways.

Thanks.

-- 
Kind regards,
Minchan Kim

Re: [PATCH] mm/zsmalloc: add log for module load/unload

[Minchan Kim]

Hello Ganesh,

On Tue, Jan 27, 2015 at 10:07:53AM +0800, Ganesh Mahendran wrote:
> Hello, Andrew
> 
> 2015-01-27 7:19 GMT+08:00 Andrew Morton <akpm@linux-foundation.org>:
> > On Sat, 24 Jan 2015 21:48:41 +0800 Ganesh Mahendran <opensource.ganesh@gmail.com> wrote:
> >
> >> Sometimes, we want to know whether a module is loaded or unloaded
> >> from the log.
> >
> > Why?  What's special about zsmalloc?
> >
> > Please provide much better justification than this.
> 
> When I debug with the zsmalloc module built in kernel.
> After system boots up, I did not see:
> /sys/kernel/debug/zsmalloc dir.
> 
> Although the reason for this is that I made a mistake. I
> forgot to add debugfs entry in /etc/fstab.
> But I think it is suitable to add information for a module load/unload.
> Then we can get this by:
> dmesg | grep zsmalloc.

I understand your trouble but it's general problem, not zsmalloc specific.
Then, if you really want to fix, you should approach more generic ways.

Thanks.

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>