[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

[Alexey Brodkin]

If for some reason DMA module fails to reset user oserves only this:
--->---
# dhcp
Trying dwmac.e0018000
FAIL
--->---

This message makes not much sense.
With proposed change error message will be more helpful:
--->---
# dhcp
Trying dwmac.e0018000
DMA reset timeout
FAIL
--->---

For example user may do power toggle to recover board functionality.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@altera.com>
Cc: Albert Aribaud <albert.u.boot@aribaud.net>
Cc: Tom Rini <trini@ti.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Pavel Machek <pavel@denx.de>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
Cc: Ian Campbell <ijc@hellion.org.uk>
Cc: Marek Vasut <marex@denx.de>
---
 drivers/net/designware.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index 9ded895..c03e935 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -236,8 +236,10 @@ static int dw_eth_init(struct eth_device *dev, bd_t *bis)
 
 	start = get_timer(0);
 	while (readl(&dma_p->busmode) & DMAMAC_SRST) {
-		if (get_timer(start) >= CONFIG_MACRESET_TIMEOUT)
+		if (get_timer(start) >= CONFIG_MACRESET_TIMEOUT) {
+			printf("DMA reset timeout\n");
 			return -1;
+		}
 
 		mdelay(100);
 	};
-- 
2.1.0

[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

[Tom Rini]

On Tue, Jan 13, 2015 at 05:10:24PM +0300, Alexey Brodkin wrote:

> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
> 
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
> 
> For example user may do power toggle to recover board functionality.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Marek Vasut <marex@denx.de>

Reviewed-by: Tom Rini <trini@ti.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150113/5a2a1c49/attachment.pgp>

[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

[Pavel Machek]

On Tue 2015-01-13 17:10:24, Alexey Brodkin wrote:
> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
> 
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
> 
> For example user may do power toggle to recover board functionality.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>

Acked-by: Pavel Machek <pavel@denx.de>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

[Marek Vasut]

On Friday, January 30, 2015 at 08:10:34 AM, Alexey Brodkin wrote:
> Hi Marek, Tom,
> 
> On Fri, 2015-01-16 at 22:16 +0100, Pavel Machek wrote:
> > On Tue 2015-01-13 17:10:24, Alexey Brodkin wrote:
> > > If for some reason DMA module fails to reset user oserves only this:
> > > --->---
> > > # dhcp
> > > Trying dwmac.e0018000
> > > FAIL
> > > --->---
> > > 
> > > This message makes not much sense.
> > > With proposed change error message will be more helpful:
> > > --->---
> > > # dhcp
> > > Trying dwmac.e0018000
> > > DMA reset timeout
> > > FAIL
> > > --->---
> > > 
> > > For example user may do power toggle to recover board functionality.
> > > 
> > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > Cc: Chin Liang See <clsee@altera.com>
> > > Cc: Dinh Nguyen <dinguyen@altera.com>
> > > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > > Cc: Tom Rini <trini@ti.com>
> > > Cc: Wolfgang Denk <wd@denx.de>
> > 
> > Acked-by: Pavel Machek <pavel@denx.de>
> 
> Any chance for this trivial change to be applied?

Joe, can you please pick this ?

Best regards,
Marek Vasut

[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

[Joe Hershberger]

On Fri, Jan 30, 2015 at 4:04 AM, Marek Vasut <marex@denx.de> wrote:
>
> On Friday, January 30, 2015 at 08:10:34 AM, Alexey Brodkin wrote:
> > Hi Marek, Tom,
> >
> > On Fri, 2015-01-16 at 22:16 +0100, Pavel Machek wrote:
> > > On Tue 2015-01-13 17:10:24, Alexey Brodkin wrote:
> > > > If for some reason DMA module fails to reset user oserves only this:
> > > > --->---
> > > > # dhcp
> > > > Trying dwmac.e0018000
> > > > FAIL
> > > > --->---
> > > >
> > > > This message makes not much sense.
> > > > With proposed change error message will be more helpful:
> > > > --->---
> > > > # dhcp
> > > > Trying dwmac.e0018000
> > > > DMA reset timeout
> > > > FAIL
> > > > --->---
> > > >
> > > > For example user may do power toggle to recover board functionality.
> > > >
> > > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > > Cc: Chin Liang See <clsee@altera.com>
> > > > Cc: Dinh Nguyen <dinguyen@altera.com>
> > > > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > > > Cc: Tom Rini <trini@ti.com>
> > > > Cc: Wolfgang Denk <wd@denx.de>
> > >
> > > Acked-by: Pavel Machek <pavel@denx.de>
> >
> > Any chance for this trivial change to be applied?
>
> Joe, can you please pick this ?

Sure.

-Joe

[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

[Joe Hershberger]

On Tue, Jan 13, 2015 at 8:10 AM, Alexey Brodkin <Alexey.Brodkin@synopsys.com>
wrote:
>
> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
>
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
>
> For example user may do power toggle to recover board functionality.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Marek Vasut <marex@denx.de>
> ---

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

[Joe Hershberger]

On Tue, Jan 13, 2015 at 8:10 AM, Alexey Brodkin <Alexey.Brodkin@synopsys.com>
wrote:
>
> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
>
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
>
> For example user may do power toggle to recover board functionality.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Marek Vasut <marex@denx.de>
> ---

Applied, Thanks!
-Joe