[PATCH] ACPI / video: Add disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D

[PATCH] ACPI / video: Add disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D

[Jens Reyer]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

Hi

The native intel backlight controls do not work correctly on SAMSUNG
900X3C/900X3D/900X3E/900X4C/900X4D laptops as I reported in
https://bugs.freedesktop.org/show_bug.cgi?id=87286 (and
https://bugs.debian.org/772440).

Aaron Lu told me there to speak up here/to Rafael.

Please find attached a patch to disable the native backlight on this
laptop model, like it was already done for some other older models.

I assume this would be the proper commit comments (or should it be
signed-off?):
Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286.
Reported-and-tested-by: Jens Reyer <jens.reyer@gmail.com>

The patch applies to
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
branch linux-next, head at
389a8d43d64711b0e7282d227e05a6a71b43753d
Rafael J. Wysocki 2015-02-12 22:43:26

I verified the issues are still present in linux-next and get solved
with this patch.

Just tell me if there is anything else I can do to get this applied.

Thanks
Jens Reyer/jre <jre.winesim@gmail.com>

[-- Attachment #2: disable_native_backlight_Samsung_900X.patch --]
[-- Type: text/x-patch, Size: 679 bytes --]

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 88a4f99..debd309 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
 		},
 	},
+	{
+	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
+	 .callback = video_disable_native_backlight,
+	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
+		},
+	},
 
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */

Re: [PATCH] ACPI / video: Add disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D

[Aaron Lu]

On Sun, Feb 15, 2015 at 12:20:50AM +0100, Jens Reyer wrote:
> Hi
> 
> The native intel backlight controls do not work correctly on SAMSUNG
> 900X3C/900X3D/900X3E/900X4C/900X4D laptops as I reported in
> https://bugs.freedesktop.org/show_bug.cgi?id=87286 (and
> https://bugs.debian.org/772440).
> 
> Aaron Lu told me there to speak up here/to Rafael.
> 
> Please find attached a patch to disable the native backlight on this
> laptop model, like it was already done for some other older models.
> 
> I assume this would be the proper commit comments (or should it be
> signed-off?):
> Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286.
> Reported-and-tested-by: Jens Reyer <jens.reyer@gmail.com>

You will need to add the Signed-off-by: line to get the patch merged.

Thanks,
Aaron

> 
> The patch applies to
> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> branch linux-next, head at
> 389a8d43d64711b0e7282d227e05a6a71b43753d
> Rafael J. Wysocki 2015-02-12 22:43:26
> 
> I verified the issues are still present in linux-next and get solved
> with this patch.
> 
> Just tell me if there is anything else I can do to get this applied.
> 
> Thanks
> Jens Reyer/jre <jre.winesim@gmail.com>

> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 88a4f99..debd309 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
>  		},
>  	},
> +	{
> +	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
> +	 .callback = video_disable_native_backlight,
> +	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
> +		},
> +	},
>  
>  	{
>  	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */

[PATCH v2] ACPI / video: Disable native backlight on Samsung Series 9 laptops

[Jens Reyer]

Add video_disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/
900X3E/900X4C/900X4D laptops.

The native intel backlight controls do not work correctly on SAMSUNG
Series 9 (900X3C/900X3D/900X3E/900X4C/900X4D) laptops:
One machine has an completely dimmed (= black) display after boot at the
GDM login screen and brightness controls work only between 0 and 5%
(= no effect).
Another machine has the same brightness control issues if an external
HDMI monitor is or gets connected, although the initial brightness is
ok.
After login to Gnome both machines always work fine.

Tested on both machines.

Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286
Bug-Link: https://bugs.debian.org/772440
Signed-off-by: Jens Reyer <jens.reyer@gmail.com>
---
 drivers/acpi/video.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 88a4f99..debd309 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
 		},
 	},
+	{
+	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
+	 .callback = video_disable_native_backlight,
+	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
+		},
+	},
 
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */
-- 
2.1.4

Re: [PATCH v2] ACPI / video: Disable native backlight on Samsung Series 9 laptops

[Rafael J. Wysocki]

On Tuesday, February 17, 2015 07:07:29 PM Jens Reyer wrote:
> Add video_disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/
> 900X3E/900X4C/900X4D laptops.
> 
> The native intel backlight controls do not work correctly on SAMSUNG
> Series 9 (900X3C/900X3D/900X3E/900X4C/900X4D) laptops:
> One machine has an completely dimmed (= black) display after boot at the
> GDM login screen and brightness controls work only between 0 and 5%
> (= no effect).
> Another machine has the same brightness control issues if an external
> HDMI monitor is or gets connected, although the initial brightness is
> ok.
> After login to Gnome both machines always work fine.
> 
> Tested on both machines.
> 
> Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286
> Bug-Link: https://bugs.debian.org/772440
> Signed-off-by: Jens Reyer <jens.reyer@gmail.com>

Applied, thanks!

> ---
>  drivers/acpi/video.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 88a4f99..debd309 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
>  		},
>  	},
> +	{
> +	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
> +	 .callback = video_disable_native_backlight,
> +	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
> +		},
> +	},
>  
>  	{
>  	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.