* [PATCH 0/3] thermal: exynos: Fix NULL pointer error and bug of PD_DET_EN of Exynos7 @ 2015-02-16 14:20 ` Chanwoo Choi 0 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 14:20 UTC (permalink / raw) To: rui.zhang, edubezval Cc: kgene, b.zolnierkie, kyungmin.park, amit.daniel, l.majewski, a.kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel, Chanwoo Choi This patch-set fix NULL pointer error during kernel booting and the bug of PD_DET_EN bit field of Exynos7 TMU. And the clean-up the exynos compatible table by making oneline entry. Chanwoo Choi (3): thermal: exynos: Fix NULL pointer exception during kernel booting thermal: exynos: Fix wrong control of power down detection mode for Exynos7 thermal: exynos: Clean-up code to use oneline entry for exynos compatible table drivers/thermal/samsung/exynos_tmu.c | 51 ++++++++++++------------------------ 1 file changed, 17 insertions(+), 34 deletions(-) -- 1.8.5.5 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 0/3] thermal: exynos: Fix NULL pointer error and bug of PD_DET_EN of Exynos7 @ 2015-02-16 14:20 ` Chanwoo Choi 0 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 14:20 UTC (permalink / raw) To: linux-arm-kernel This patch-set fix NULL pointer error during kernel booting and the bug of PD_DET_EN bit field of Exynos7 TMU. And the clean-up the exynos compatible table by making oneline entry. Chanwoo Choi (3): thermal: exynos: Fix NULL pointer exception during kernel booting thermal: exynos: Fix wrong control of power down detection mode for Exynos7 thermal: exynos: Clean-up code to use oneline entry for exynos compatible table drivers/thermal/samsung/exynos_tmu.c | 51 ++++++++++++------------------------ 1 file changed, 17 insertions(+), 34 deletions(-) -- 1.8.5.5 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting 2015-02-16 14:20 ` Chanwoo Choi @ 2015-02-16 14:20 ` Chanwoo Choi -1 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 14:20 UTC (permalink / raw) To: rui.zhang, edubezval Cc: kgene, b.zolnierkie, kyungmin.park, amit.daniel, l.majewski, a.kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel, Chanwoo Choi This patch fixes the NULL pointer exception during kernel booting. The thermal_zone _of_sensor_register() registers a sensor to DT thermal zone and then read the current temperature by '.get_temp' callback. The callback function of exynos thermal driver is exynos_get_temp() which must need the 'pdata' instance of exynos_tmu _platform_data structure. - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' instance But, exynos thermal driver is executed before getting the 'pdata' instance. To avoid the kernel panic, have to get the platform data by executing the exynos_map_dt_data() before calling thermal_zone_of_sensor_register() . - kernel panic log [ 4211.324346] PC is at 0x0 [ 4211.326867] LR is at exynos_get_temp+0x3c/0xe4 [ 4211.331289] pc : [<0000000000000000>] lr : [<ffffffc0004df460>] [snip] [ 4211.940625] [< (null)>] (null) [ 4211.945315] [<ffffffc0004de6d8>] of_thermal_get_temp+0x1c/0x30 [ 4211.951132] [<ffffffc0004db86c>] thermal_zone_get_temp+0x48/0x7c [ 4211.957118] [<ffffffc0004dd278>] thermal_zone_device_update+0x20/0x110 [ 4211.963627] [<ffffffc0004de9c8>] of_thermal_set_mode+0x44/0x68 [ 4211.969443] [<ffffffc0004decb8>] thermal_zone_of_sensor_register+0x15c/0x1d8 [ 4211.976475] [<ffffffc0004dfbe4>] exynos_tmu_probe+0x6c/0x814 [ 4211.982120] [<ffffffc0003ef808>] platform_drv_probe+0x48/0xb8 [ 4211.987846] [<ffffffc0003edb28>] driver_probe_device+0x8c/0x244 [ 4211.993747] [<ffffffc0003eddcc>] __driver_attach+0x98/0xa0 [ 4211.999216] [<ffffffc0003ebea0>] bus_for_each_dev+0x54/0x98 [ 4212.004771] [<ffffffc0003ed66c>] driver_attach+0x1c/0x28 [ 4212.010066] [<ffffffc0003ed2e8>] bus_add_driver+0x150/0x208 [ 4212.015622] [<ffffffc0003ee6a4>] driver_register+0x5c/0x11c [ 4212.021178] [<ffffffc0003ef73c>] __platform_driver_register+0x5c/0x68 [ 4212.027600] [<ffffffc000b64eb8>] exynos_tmu_driver_init+0x14/0x20 [ 4212.033678] [<ffffffc0000828d4>] do_one_initcall+0x88/0x1a0 [ 4212.039235] [<ffffffc000b34b34>] kernel_init_freeable+0x1bc/0x260 [ 4212.045311] [<ffffffc0007e9fd4>] kernel_init+0xc/0xd8 Cc: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <edubezval@gmail.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index fbeedc0..b8846f1 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1147,17 +1147,17 @@ static int exynos_tmu_probe(struct platform_device *pdev) platform_set_drvdata(pdev, data); mutex_init(&data->lock); + ret = exynos_map_dt_data(pdev); + if (ret) + return ret; + pdata = data->pdata; + data->tzd = thermal_zone_of_sensor_register(&pdev->dev, 0, data, &exynos_sensor_ops); if (IS_ERR(data->tzd)) { pr_err("thermal: tz: %p ERROR\n", data->tzd); return PTR_ERR(data->tzd); } - ret = exynos_map_dt_data(pdev); - if (ret) - goto err_sensor; - - pdata = data->pdata; INIT_WORK(&data->irq_work, exynos_tmu_work); -- 1.8.5.5 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting @ 2015-02-16 14:20 ` Chanwoo Choi 0 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 14:20 UTC (permalink / raw) To: linux-arm-kernel This patch fixes the NULL pointer exception during kernel booting. The thermal_zone _of_sensor_register() registers a sensor to DT thermal zone and then read the current temperature by '.get_temp' callback. The callback function of exynos thermal driver is exynos_get_temp() which must need the 'pdata' instance of exynos_tmu _platform_data structure. - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' instance But, exynos thermal driver is executed before getting the 'pdata' instance. To avoid the kernel panic, have to get the platform data by executing the exynos_map_dt_data() before calling thermal_zone_of_sensor_register() . - kernel panic log [ 4211.324346] PC is at 0x0 [ 4211.326867] LR is at exynos_get_temp+0x3c/0xe4 [ 4211.331289] pc : [<0000000000000000>] lr : [<ffffffc0004df460>] [snip] [ 4211.940625] [< (null)>] (null) [ 4211.945315] [<ffffffc0004de6d8>] of_thermal_get_temp+0x1c/0x30 [ 4211.951132] [<ffffffc0004db86c>] thermal_zone_get_temp+0x48/0x7c [ 4211.957118] [<ffffffc0004dd278>] thermal_zone_device_update+0x20/0x110 [ 4211.963627] [<ffffffc0004de9c8>] of_thermal_set_mode+0x44/0x68 [ 4211.969443] [<ffffffc0004decb8>] thermal_zone_of_sensor_register+0x15c/0x1d8 [ 4211.976475] [<ffffffc0004dfbe4>] exynos_tmu_probe+0x6c/0x814 [ 4211.982120] [<ffffffc0003ef808>] platform_drv_probe+0x48/0xb8 [ 4211.987846] [<ffffffc0003edb28>] driver_probe_device+0x8c/0x244 [ 4211.993747] [<ffffffc0003eddcc>] __driver_attach+0x98/0xa0 [ 4211.999216] [<ffffffc0003ebea0>] bus_for_each_dev+0x54/0x98 [ 4212.004771] [<ffffffc0003ed66c>] driver_attach+0x1c/0x28 [ 4212.010066] [<ffffffc0003ed2e8>] bus_add_driver+0x150/0x208 [ 4212.015622] [<ffffffc0003ee6a4>] driver_register+0x5c/0x11c [ 4212.021178] [<ffffffc0003ef73c>] __platform_driver_register+0x5c/0x68 [ 4212.027600] [<ffffffc000b64eb8>] exynos_tmu_driver_init+0x14/0x20 [ 4212.033678] [<ffffffc0000828d4>] do_one_initcall+0x88/0x1a0 [ 4212.039235] [<ffffffc000b34b34>] kernel_init_freeable+0x1bc/0x260 [ 4212.045311] [<ffffffc0007e9fd4>] kernel_init+0xc/0xd8 Cc: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <edubezval@gmail.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index fbeedc0..b8846f1 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1147,17 +1147,17 @@ static int exynos_tmu_probe(struct platform_device *pdev) platform_set_drvdata(pdev, data); mutex_init(&data->lock); + ret = exynos_map_dt_data(pdev); + if (ret) + return ret; + pdata = data->pdata; + data->tzd = thermal_zone_of_sensor_register(&pdev->dev, 0, data, &exynos_sensor_ops); if (IS_ERR(data->tzd)) { pr_err("thermal: tz: %p ERROR\n", data->tzd); return PTR_ERR(data->tzd); } - ret = exynos_map_dt_data(pdev); - if (ret) - goto err_sensor; - - pdata = data->pdata; INIT_WORK(&data->irq_work, exynos_tmu_work); -- 1.8.5.5 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting 2015-02-16 14:20 ` Chanwoo Choi @ 2015-02-16 15:06 ` Lukasz Majewski -1 siblings, 0 replies; 18+ messages in thread From: Lukasz Majewski @ 2015-02-16 15:06 UTC (permalink / raw) To: Chanwoo Choi Cc: rui.zhang, edubezval, kgene, b.zolnierkie, kyungmin.park, amit.daniel, a.kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Chanwoo, > This patch fixes the NULL pointer exception during kernel booting. > The thermal_zone _of_sensor_register() registers a sensor to DT > thermal zone and then read the current temperature by '.get_temp' > callback. The callback function of exynos thermal driver is > exynos_get_temp() which must need the 'pdata' instance of exynos_tmu > _platform_data structure. > - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' > instance > > But, exynos thermal driver is executed before getting the 'pdata' > instance. To avoid the kernel panic, have to get the platform data by > executing the exynos_map_dt_data() before calling > thermal_zone_of_sensor_register() . I've already prepared patch for this (unfortunately it isn't yet applied to mainline): "[PATCH] thermal: exynos: fix: Check if data->tmu_read callback is present before read" http://www.spinics.net/lists/linux-samsung-soc/msg42245.html Does applying this patch help? BTW: How can I reproduce this error? Could you point me the SHA1 and repository? > > - kernel panic log > [ 4211.324346] PC is at 0x0 > [ 4211.326867] LR is at exynos_get_temp+0x3c/0xe4 > [ 4211.331289] pc : [<0000000000000000>] lr : [<ffffffc0004df460>] > [snip] > [ 4211.940625] [< (null)>] (null) > [ 4211.945315] [<ffffffc0004de6d8>] of_thermal_get_temp+0x1c/0x30 > [ 4211.951132] [<ffffffc0004db86c>] thermal_zone_get_temp+0x48/0x7c > [ 4211.957118] [<ffffffc0004dd278>] > thermal_zone_device_update+0x20/0x110 [ 4211.963627] > [<ffffffc0004de9c8>] of_thermal_set_mode+0x44/0x68 [ 4211.969443] > [<ffffffc0004decb8>] thermal_zone_of_sensor_register+0x15c/0x1d8 > [ 4211.976475] [<ffffffc0004dfbe4>] exynos_tmu_probe+0x6c/0x814 > [ 4211.982120] [<ffffffc0003ef808>] platform_drv_probe+0x48/0xb8 > [ 4211.987846] [<ffffffc0003edb28>] driver_probe_device+0x8c/0x244 > [ 4211.993747] [<ffffffc0003eddcc>] __driver_attach+0x98/0xa0 > [ 4211.999216] [<ffffffc0003ebea0>] bus_for_each_dev+0x54/0x98 > [ 4212.004771] [<ffffffc0003ed66c>] driver_attach+0x1c/0x28 > [ 4212.010066] [<ffffffc0003ed2e8>] bus_add_driver+0x150/0x208 > [ 4212.015622] [<ffffffc0003ee6a4>] driver_register+0x5c/0x11c > [ 4212.021178] [<ffffffc0003ef73c>] > __platform_driver_register+0x5c/0x68 [ 4212.027600] > [<ffffffc000b64eb8>] exynos_tmu_driver_init+0x14/0x20 [ 4212.033678] > [<ffffffc0000828d4>] do_one_initcall+0x88/0x1a0 [ 4212.039235] > [<ffffffc000b34b34>] kernel_init_freeable+0x1bc/0x260 [ 4212.045311] > [<ffffffc0007e9fd4>] kernel_init+0xc/0xd8 > > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/thermal/samsung/exynos_tmu.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c index fbeedc0..b8846f1 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -1147,17 +1147,17 @@ static int exynos_tmu_probe(struct > platform_device *pdev) platform_set_drvdata(pdev, data); > mutex_init(&data->lock); > > + ret = exynos_map_dt_data(pdev); > + if (ret) > + return ret; > + pdata = data->pdata; > + > data->tzd = thermal_zone_of_sensor_register(&pdev->dev, 0, > data, &exynos_sensor_ops); > if (IS_ERR(data->tzd)) { > pr_err("thermal: tz: %p ERROR\n", data->tzd); > return PTR_ERR(data->tzd); > } > - ret = exynos_map_dt_data(pdev); > - if (ret) > - goto err_sensor; > - > - pdata = data->pdata; > > INIT_WORK(&data->irq_work, exynos_tmu_work); > -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting @ 2015-02-16 15:06 ` Lukasz Majewski 0 siblings, 0 replies; 18+ messages in thread From: Lukasz Majewski @ 2015-02-16 15:06 UTC (permalink / raw) To: linux-arm-kernel Hi Chanwoo, > This patch fixes the NULL pointer exception during kernel booting. > The thermal_zone _of_sensor_register() registers a sensor to DT > thermal zone and then read the current temperature by '.get_temp' > callback. The callback function of exynos thermal driver is > exynos_get_temp() which must need the 'pdata' instance of exynos_tmu > _platform_data structure. > - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' > instance > > But, exynos thermal driver is executed before getting the 'pdata' > instance. To avoid the kernel panic, have to get the platform data by > executing the exynos_map_dt_data() before calling > thermal_zone_of_sensor_register() . I've already prepared patch for this (unfortunately it isn't yet applied to mainline): "[PATCH] thermal: exynos: fix: Check if data->tmu_read callback is present before read" http://www.spinics.net/lists/linux-samsung-soc/msg42245.html Does applying this patch help? BTW: How can I reproduce this error? Could you point me the SHA1 and repository? > > - kernel panic log > [ 4211.324346] PC is at 0x0 > [ 4211.326867] LR is at exynos_get_temp+0x3c/0xe4 > [ 4211.331289] pc : [<0000000000000000>] lr : [<ffffffc0004df460>] > [snip] > [ 4211.940625] [< (null)>] (null) > [ 4211.945315] [<ffffffc0004de6d8>] of_thermal_get_temp+0x1c/0x30 > [ 4211.951132] [<ffffffc0004db86c>] thermal_zone_get_temp+0x48/0x7c > [ 4211.957118] [<ffffffc0004dd278>] > thermal_zone_device_update+0x20/0x110 [ 4211.963627] > [<ffffffc0004de9c8>] of_thermal_set_mode+0x44/0x68 [ 4211.969443] > [<ffffffc0004decb8>] thermal_zone_of_sensor_register+0x15c/0x1d8 > [ 4211.976475] [<ffffffc0004dfbe4>] exynos_tmu_probe+0x6c/0x814 > [ 4211.982120] [<ffffffc0003ef808>] platform_drv_probe+0x48/0xb8 > [ 4211.987846] [<ffffffc0003edb28>] driver_probe_device+0x8c/0x244 > [ 4211.993747] [<ffffffc0003eddcc>] __driver_attach+0x98/0xa0 > [ 4211.999216] [<ffffffc0003ebea0>] bus_for_each_dev+0x54/0x98 > [ 4212.004771] [<ffffffc0003ed66c>] driver_attach+0x1c/0x28 > [ 4212.010066] [<ffffffc0003ed2e8>] bus_add_driver+0x150/0x208 > [ 4212.015622] [<ffffffc0003ee6a4>] driver_register+0x5c/0x11c > [ 4212.021178] [<ffffffc0003ef73c>] > __platform_driver_register+0x5c/0x68 [ 4212.027600] > [<ffffffc000b64eb8>] exynos_tmu_driver_init+0x14/0x20 [ 4212.033678] > [<ffffffc0000828d4>] do_one_initcall+0x88/0x1a0 [ 4212.039235] > [<ffffffc000b34b34>] kernel_init_freeable+0x1bc/0x260 [ 4212.045311] > [<ffffffc0007e9fd4>] kernel_init+0xc/0xd8 > > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/thermal/samsung/exynos_tmu.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c index fbeedc0..b8846f1 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -1147,17 +1147,17 @@ static int exynos_tmu_probe(struct > platform_device *pdev) platform_set_drvdata(pdev, data); > mutex_init(&data->lock); > > + ret = exynos_map_dt_data(pdev); > + if (ret) > + return ret; > + pdata = data->pdata; > + > data->tzd = thermal_zone_of_sensor_register(&pdev->dev, 0, > data, &exynos_sensor_ops); > if (IS_ERR(data->tzd)) { > pr_err("thermal: tz: %p ERROR\n", data->tzd); > return PTR_ERR(data->tzd); > } > - ret = exynos_map_dt_data(pdev); > - if (ret) > - goto err_sensor; > - > - pdata = data->pdata; > > INIT_WORK(&data->irq_work, exynos_tmu_work); > -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting 2015-02-16 15:06 ` Lukasz Majewski @ 2015-02-16 16:15 ` Chanwoo Choi -1 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 16:15 UTC (permalink / raw) To: Lukasz Majewski Cc: Zhang Rui, Eduardo Valentin, Kukjin Kim, Bartlomiej Zolnierkiewicz, Kyungmin Park, Amit Kachhap, Abhilash Kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Lukasz, On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski <l.majewski@samsung.com> wrote: > Hi Chanwoo, > >> This patch fixes the NULL pointer exception during kernel booting. >> The thermal_zone _of_sensor_register() registers a sensor to DT >> thermal zone and then read the current temperature by '.get_temp' >> callback. The callback function of exynos thermal driver is >> exynos_get_temp() which must need the 'pdata' instance of exynos_tmu >> _platform_data structure. >> - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' >> instance >> >> But, exynos thermal driver is executed before getting the 'pdata' >> instance. To avoid the kernel panic, have to get the platform data by >> executing the exynos_map_dt_data() before calling >> thermal_zone_of_sensor_register() . > > I've already prepared patch for this (unfortunately it isn't yet > applied to mainline): > > "[PATCH] thermal: exynos: fix: Check if data->tmu_read callback is > present before read" > > http://www.spinics.net/lists/linux-samsung-soc/msg42245.html There is different issue between you patch and this patch. Your patch check the whether data->tmu_read is NULL or not. But, my patch check the pdata is NULL or not. > > Does applying this patch help? > > BTW: How can I reproduce this error? Could you point me the SHA1 and > repository? I used your patch-set of linux-soc-thermal.git (branch: next). So I applied you patchiest on Linux 3.19 for test. - https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/log/?h=next Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting @ 2015-02-16 16:15 ` Chanwoo Choi 0 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 16:15 UTC (permalink / raw) To: linux-arm-kernel Hi Lukasz, On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski <l.majewski@samsung.com> wrote: > Hi Chanwoo, > >> This patch fixes the NULL pointer exception during kernel booting. >> The thermal_zone _of_sensor_register() registers a sensor to DT >> thermal zone and then read the current temperature by '.get_temp' >> callback. The callback function of exynos thermal driver is >> exynos_get_temp() which must need the 'pdata' instance of exynos_tmu >> _platform_data structure. >> - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' >> instance >> >> But, exynos thermal driver is executed before getting the 'pdata' >> instance. To avoid the kernel panic, have to get the platform data by >> executing the exynos_map_dt_data() before calling >> thermal_zone_of_sensor_register() . > > I've already prepared patch for this (unfortunately it isn't yet > applied to mainline): > > "[PATCH] thermal: exynos: fix: Check if data->tmu_read callback is > present before read" > > http://www.spinics.net/lists/linux-samsung-soc/msg42245.html There is different issue between you patch and this patch. Your patch check the whether data->tmu_read is NULL or not. But, my patch check the pdata is NULL or not. > > Does applying this patch help? > > BTW: How can I reproduce this error? Could you point me the SHA1 and > repository? I used your patch-set of linux-soc-thermal.git (branch: next). So I applied you patchiest on Linux 3.19 for test. - https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/log/?h=next Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting 2015-02-16 16:15 ` Chanwoo Choi @ 2015-02-16 16:28 ` Lukasz Majewski -1 siblings, 0 replies; 18+ messages in thread From: Lukasz Majewski @ 2015-02-16 16:28 UTC (permalink / raw) To: cw00.choi Cc: cwchoi00, Zhang Rui, Eduardo Valentin, Kukjin Kim, Bartlomiej Zolnierkiewicz, Kyungmin Park, Amit Kachhap, Abhilash Kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Chanwoo, > Hi Lukasz, > > On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski > <l.majewski@samsung.com> wrote: > > Hi Chanwoo, > > > >> This patch fixes the NULL pointer exception during kernel booting. > >> The thermal_zone _of_sensor_register() registers a sensor to DT > >> thermal zone and then read the current temperature by '.get_temp' > >> callback. The callback function of exynos thermal driver is > >> exynos_get_temp() which must need the 'pdata' instance of > >> exynos_tmu _platform_data structure. > >> - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' > >> instance > >> > >> But, exynos thermal driver is executed before getting the 'pdata' > >> instance. To avoid the kernel panic, have to get the platform data > >> by executing the exynos_map_dt_data() before calling > >> thermal_zone_of_sensor_register() . > > > > I've already prepared patch for this (unfortunately it isn't yet > > applied to mainline): > > > > "[PATCH] thermal: exynos: fix: Check if data->tmu_read callback is > > present before read" > > > > http://www.spinics.net/lists/linux-samsung-soc/msg42245.html > > There is different issue between you patch and this patch. > Your patch check the whether data->tmu_read is NULL or not. > But, my patch check the pdata is NULL or not. I've tried to do the same previously. Please compare with: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function http://www.spinics.net/lists/linux-samsung-soc/msg41308.html Unfortunately, Abhilash found some issues with this code, so I've looked into different solution. However, I didn't need to move pdata = data->pdata; Hence, I wonder why it need to be reordered. Are you using Exynos3250 based device? > > > > > Does applying this patch help? > > > > BTW: How can I reproduce this error? Could you point me the SHA1 and > > repository? > > I used your patch-set of linux-soc-thermal.git (branch: next). So I > applied you patchiest on Linux 3.19 for test. > - > https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/log/?h=next Is there any special .config? May I ask about the target platform? I will look closely on this problem tomorrow. > > Best Regards, > Chanwoo Choi -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting @ 2015-02-16 16:28 ` Lukasz Majewski 0 siblings, 0 replies; 18+ messages in thread From: Lukasz Majewski @ 2015-02-16 16:28 UTC (permalink / raw) To: linux-arm-kernel Hi Chanwoo, > Hi Lukasz, > > On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski > <l.majewski@samsung.com> wrote: > > Hi Chanwoo, > > > >> This patch fixes the NULL pointer exception during kernel booting. > >> The thermal_zone _of_sensor_register() registers a sensor to DT > >> thermal zone and then read the current temperature by '.get_temp' > >> callback. The callback function of exynos thermal driver is > >> exynos_get_temp() which must need the 'pdata' instance of > >> exynos_tmu _platform_data structure. > >> - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' > >> instance > >> > >> But, exynos thermal driver is executed before getting the 'pdata' > >> instance. To avoid the kernel panic, have to get the platform data > >> by executing the exynos_map_dt_data() before calling > >> thermal_zone_of_sensor_register() . > > > > I've already prepared patch for this (unfortunately it isn't yet > > applied to mainline): > > > > "[PATCH] thermal: exynos: fix: Check if data->tmu_read callback is > > present before read" > > > > http://www.spinics.net/lists/linux-samsung-soc/msg42245.html > > There is different issue between you patch and this patch. > Your patch check the whether data->tmu_read is NULL or not. > But, my patch check the pdata is NULL or not. I've tried to do the same previously. Please compare with: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function http://www.spinics.net/lists/linux-samsung-soc/msg41308.html Unfortunately, Abhilash found some issues with this code, so I've looked into different solution. However, I didn't need to move pdata = data->pdata; Hence, I wonder why it need to be reordered. Are you using Exynos3250 based device? > > > > > Does applying this patch help? > > > > BTW: How can I reproduce this error? Could you point me the SHA1 and > > repository? > > I used your patch-set of linux-soc-thermal.git (branch: next). So I > applied you patchiest on Linux 3.19 for test. > - > https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/log/?h=next Is there any special .config? May I ask about the target platform? I will look closely on this problem tomorrow. > > Best Regards, > Chanwoo Choi -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting 2015-02-16 16:28 ` Lukasz Majewski @ 2015-02-16 17:00 ` Chanwoo Choi -1 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 17:00 UTC (permalink / raw) To: Lukasz Majewski Cc: Zhang Rui, Eduardo Valentin, Kukjin Kim, Bartlomiej Zolnierkiewicz, Kyungmin Park, Amit Kachhap, Abhilash Kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Lukasz, On Tue, Feb 17, 2015 at 1:28 AM, Lukasz Majewski <l.majewski@samsung.com> wrote: > Hi Chanwoo, > >> Hi Lukasz, >> >> On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski >> <l.majewski@samsung.com> wrote: >> > Hi Chanwoo, >> > >> >> This patch fixes the NULL pointer exception during kernel booting. >> >> The thermal_zone _of_sensor_register() registers a sensor to DT >> >> thermal zone and then read the current temperature by '.get_temp' >> >> callback. The callback function of exynos thermal driver is >> >> exynos_get_temp() which must need the 'pdata' instance of >> >> exynos_tmu _platform_data structure. >> >> - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' >> >> instance >> >> >> >> But, exynos thermal driver is executed before getting the 'pdata' >> >> instance. To avoid the kernel panic, have to get the platform data >> >> by executing the exynos_map_dt_data() before calling >> >> thermal_zone_of_sensor_register() . >> > >> > I've already prepared patch for this (unfortunately it isn't yet >> > applied to mainline): >> > >> > "[PATCH] thermal: exynos: fix: Check if data->tmu_read callback is >> > present before read" >> > >> > http://www.spinics.net/lists/linux-samsung-soc/msg42245.html >> >> There is different issue between you patch and this patch. >> Your patch check the whether data->tmu_read is NULL or not. >> But, my patch check the pdata is NULL or not. > > I've tried to do the same previously. Please compare with: > [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function > > http://www.spinics.net/lists/linux-samsung-soc/msg41308.html > > Unfortunately, Abhilash found some issues with this code, so I've > looked into different solution. OK. > > > However, I didn't need to move pdata = data->pdata; Hence, I wonder why > it need to be reordered. Are you using Exynos3250 based device? I think it is necessary to prevent kernel panic. We can check this issue by analyzing the thermal_zone_of_sensor_register() as following issue: of_thermal_get_temp() executes the exynos_get_temp() finally. And exynos_get_temp() function must need the 'pdata' instance. The 'pdata' instance is initialized on exynos_map_dt_data(). If exynos_tmu driver executes the exynos_map_dt_data() after thermal_zone_of_sensor_register(), this issue happen again. [ 4211.945315] [<ffffffc0004de6d8>] of_thermal_get_temp+0x1c/0x30 [ 4211.951132] [<ffffffc0004db86c>] thermal_zone_get_temp+0x48/0x7c [ 4211.957118] [<ffffffc0004dd278>] thermal_zone_device_update+0x20/0x110 [ 4211.963627] [<ffffffc0004de9c8>] of_thermal_set_mode+0x44/0x68 [ 4211.969443] [<ffffffc0004decb8>] thermal_zone_of_sensor_register+0x15c/0x1d8 I tested it on Exynos5433 based device. > > >> >> > >> > Does applying this patch help? >> > >> > BTW: How can I reproduce this error? Could you point me the SHA1 and >> > repository? >> >> I used your patch-set of linux-soc-thermal.git (branch: next). So I >> applied you patchiest on Linux 3.19 for test. >> - >> https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/log/?h=next > > Is there any special .config? There is no special configuration. I tested this patch with CPUFREQ for cooling device. > > May I ask about the target platform? > I will look closely on this problem tomorrow. OK. Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting @ 2015-02-16 17:00 ` Chanwoo Choi 0 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 17:00 UTC (permalink / raw) To: linux-arm-kernel Hi Lukasz, On Tue, Feb 17, 2015 at 1:28 AM, Lukasz Majewski <l.majewski@samsung.com> wrote: > Hi Chanwoo, > >> Hi Lukasz, >> >> On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski >> <l.majewski@samsung.com> wrote: >> > Hi Chanwoo, >> > >> >> This patch fixes the NULL pointer exception during kernel booting. >> >> The thermal_zone _of_sensor_register() registers a sensor to DT >> >> thermal zone and then read the current temperature by '.get_temp' >> >> callback. The callback function of exynos thermal driver is >> >> exynos_get_temp() which must need the 'pdata' instance of >> >> exynos_tmu _platform_data structure. >> >> - exynos_get_temp() -> code_to_temp() -> Must need the 'pdata' >> >> instance >> >> >> >> But, exynos thermal driver is executed before getting the 'pdata' >> >> instance. To avoid the kernel panic, have to get the platform data >> >> by executing the exynos_map_dt_data() before calling >> >> thermal_zone_of_sensor_register() . >> > >> > I've already prepared patch for this (unfortunately it isn't yet >> > applied to mainline): >> > >> > "[PATCH] thermal: exynos: fix: Check if data->tmu_read callback is >> > present before read" >> > >> > http://www.spinics.net/lists/linux-samsung-soc/msg42245.html >> >> There is different issue between you patch and this patch. >> Your patch check the whether data->tmu_read is NULL or not. >> But, my patch check the pdata is NULL or not. > > I've tried to do the same previously. Please compare with: > [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function > > http://www.spinics.net/lists/linux-samsung-soc/msg41308.html > > Unfortunately, Abhilash found some issues with this code, so I've > looked into different solution. OK. > > > However, I didn't need to move pdata = data->pdata; Hence, I wonder why > it need to be reordered. Are you using Exynos3250 based device? I think it is necessary to prevent kernel panic. We can check this issue by analyzing the thermal_zone_of_sensor_register() as following issue: of_thermal_get_temp() executes the exynos_get_temp() finally. And exynos_get_temp() function must need the 'pdata' instance. The 'pdata' instance is initialized on exynos_map_dt_data(). If exynos_tmu driver executes the exynos_map_dt_data() after thermal_zone_of_sensor_register(), this issue happen again. [ 4211.945315] [<ffffffc0004de6d8>] of_thermal_get_temp+0x1c/0x30 [ 4211.951132] [<ffffffc0004db86c>] thermal_zone_get_temp+0x48/0x7c [ 4211.957118] [<ffffffc0004dd278>] thermal_zone_device_update+0x20/0x110 [ 4211.963627] [<ffffffc0004de9c8>] of_thermal_set_mode+0x44/0x68 [ 4211.969443] [<ffffffc0004decb8>] thermal_zone_of_sensor_register+0x15c/0x1d8 I tested it on Exynos5433 based device. > > >> >> > >> > Does applying this patch help? >> > >> > BTW: How can I reproduce this error? Could you point me the SHA1 and >> > repository? >> >> I used your patch-set of linux-soc-thermal.git (branch: next). So I >> applied you patchiest on Linux 3.19 for test. >> - >> https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/log/?h=next > > Is there any special .config? There is no special configuration. I tested this patch with CPUFREQ for cooling device. > > May I ask about the target platform? > I will look closely on this problem tomorrow. OK. Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 2/3] thermal: exynos: Fix wrong control of power down detection mode for Exynos7 2015-02-16 14:20 ` Chanwoo Choi @ 2015-02-16 14:20 ` Chanwoo Choi -1 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 14:20 UTC (permalink / raw) To: rui.zhang, edubezval Cc: kgene, b.zolnierkie, kyungmin.park, amit.daniel, l.majewski, a.kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel, Chanwoo Choi This patch fixes the wrong control of PD_DET_EN (power down detection mode) for Exynos7 because exynos7_tmu_control() always enables the power down detection mode regardless 'on' parameter. Cc: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <edubezval@gmail.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index b8846f1..b199fff 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -682,6 +682,7 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on) if (on) { con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); + con |= (1 << EXYNOS7_PD_DET_EN_SHIFT); interrupt_en = (of_thermal_is_trip_valid(tz, 7) << EXYNOS7_TMU_INTEN_RISE7_SHIFT) | @@ -704,9 +705,9 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on) interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT; } else { con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); + con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT); interrupt_en = 0; /* Disable all interrupts */ } - con |= 1 << EXYNOS7_PD_DET_EN_SHIFT; writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN); writel(con, data->base + EXYNOS_TMU_REG_CONTROL); -- 1.8.5.5 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/3] thermal: exynos: Fix wrong control of power down detection mode for Exynos7 @ 2015-02-16 14:20 ` Chanwoo Choi 0 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 14:20 UTC (permalink / raw) To: linux-arm-kernel This patch fixes the wrong control of PD_DET_EN (power down detection mode) for Exynos7 because exynos7_tmu_control() always enables the power down detection mode regardless 'on' parameter. Cc: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <edubezval@gmail.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index b8846f1..b199fff 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -682,6 +682,7 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on) if (on) { con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); + con |= (1 << EXYNOS7_PD_DET_EN_SHIFT); interrupt_en = (of_thermal_is_trip_valid(tz, 7) << EXYNOS7_TMU_INTEN_RISE7_SHIFT) | @@ -704,9 +705,9 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on) interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT; } else { con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); + con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT); interrupt_en = 0; /* Disable all interrupts */ } - con |= 1 << EXYNOS7_PD_DET_EN_SHIFT; writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN); writel(con, data->base + EXYNOS_TMU_REG_CONTROL); -- 1.8.5.5 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table 2015-02-16 14:20 ` Chanwoo Choi @ 2015-02-16 14:20 ` Chanwoo Choi -1 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 14:20 UTC (permalink / raw) To: rui.zhang, edubezval Cc: kgene, b.zolnierkie, kyungmin.park, amit.daniel, l.majewski, a.kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel, Chanwoo Choi This patch cleanup the code to use oneline for entry of exynos compatible table. Cc: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <edubezval@gmail.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 38 ++++++++++-------------------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index b199fff..7e6baf5 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -919,34 +919,16 @@ static irqreturn_t exynos_tmu_irq(int irq, void *id) } static const struct of_device_id exynos_tmu_match[] = { - { - .compatible = "samsung,exynos3250-tmu", - }, - { - .compatible = "samsung,exynos4210-tmu", - }, - { - .compatible = "samsung,exynos4412-tmu", - }, - { - .compatible = "samsung,exynos5250-tmu", - }, - { - .compatible = "samsung,exynos5260-tmu", - }, - { - .compatible = "samsung,exynos5420-tmu", - }, - { - .compatible = "samsung,exynos5420-tmu-ext-triminfo", - }, - { - .compatible = "samsung,exynos5440-tmu", - }, - { - .compatible = "samsung,exynos7-tmu", - }, - {}, + { .compatible = "samsung,exynos3250-tmu", }, + { .compatible = "samsung,exynos4210-tmu", }, + { .compatible = "samsung,exynos4412-tmu", }, + { .compatible = "samsung,exynos5250-tmu", }, + { .compatible = "samsung,exynos5260-tmu", }, + { .compatible = "samsung,exynos5420-tmu", }, + { .compatible = "samsung,exynos5420-tmu-ext-triminfo", }, + { .compatible = "samsung,exynos5440-tmu", }, + { .compatible = "samsung,exynos7-tmu", }, + { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, exynos_tmu_match); -- 1.8.5.5 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table @ 2015-02-16 14:20 ` Chanwoo Choi 0 siblings, 0 replies; 18+ messages in thread From: Chanwoo Choi @ 2015-02-16 14:20 UTC (permalink / raw) To: linux-arm-kernel This patch cleanup the code to use oneline for entry of exynos compatible table. Cc: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <edubezval@gmail.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 38 ++++++++++-------------------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index b199fff..7e6baf5 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -919,34 +919,16 @@ static irqreturn_t exynos_tmu_irq(int irq, void *id) } static const struct of_device_id exynos_tmu_match[] = { - { - .compatible = "samsung,exynos3250-tmu", - }, - { - .compatible = "samsung,exynos4210-tmu", - }, - { - .compatible = "samsung,exynos4412-tmu", - }, - { - .compatible = "samsung,exynos5250-tmu", - }, - { - .compatible = "samsung,exynos5260-tmu", - }, - { - .compatible = "samsung,exynos5420-tmu", - }, - { - .compatible = "samsung,exynos5420-tmu-ext-triminfo", - }, - { - .compatible = "samsung,exynos5440-tmu", - }, - { - .compatible = "samsung,exynos7-tmu", - }, - {}, + { .compatible = "samsung,exynos3250-tmu", }, + { .compatible = "samsung,exynos4210-tmu", }, + { .compatible = "samsung,exynos4412-tmu", }, + { .compatible = "samsung,exynos5250-tmu", }, + { .compatible = "samsung,exynos5260-tmu", }, + { .compatible = "samsung,exynos5420-tmu", }, + { .compatible = "samsung,exynos5420-tmu-ext-triminfo", }, + { .compatible = "samsung,exynos5440-tmu", }, + { .compatible = "samsung,exynos7-tmu", }, + { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, exynos_tmu_match); -- 1.8.5.5 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table 2015-02-16 14:20 ` Chanwoo Choi @ 2015-02-16 15:07 ` Lukasz Majewski -1 siblings, 0 replies; 18+ messages in thread From: Lukasz Majewski @ 2015-02-16 15:07 UTC (permalink / raw) To: Chanwoo Choi Cc: rui.zhang, edubezval, kgene, b.zolnierkie, kyungmin.park, amit.daniel, a.kesavan, inki.dae, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Chanwoo, > This patch cleanup the code to use oneline for entry of exynos > compatible table. > > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/thermal/samsung/exynos_tmu.c | 38 > ++++++++++-------------------------- 1 file changed, 10 > insertions(+), 28 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c index b199fff..7e6baf5 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -919,34 +919,16 @@ static irqreturn_t exynos_tmu_irq(int irq, void > *id) } > > static const struct of_device_id exynos_tmu_match[] = { > - { > - .compatible = "samsung,exynos3250-tmu", > - }, > - { > - .compatible = "samsung,exynos4210-tmu", > - }, > - { > - .compatible = "samsung,exynos4412-tmu", > - }, > - { > - .compatible = "samsung,exynos5250-tmu", > - }, > - { > - .compatible = "samsung,exynos5260-tmu", > - }, > - { > - .compatible = "samsung,exynos5420-tmu", > - }, > - { > - .compatible = "samsung,exynos5420-tmu-ext-triminfo", > - }, > - { > - .compatible = "samsung,exynos5440-tmu", > - }, > - { > - .compatible = "samsung,exynos7-tmu", > - }, > - {}, > + { .compatible = "samsung,exynos3250-tmu", }, > + { .compatible = "samsung,exynos4210-tmu", }, > + { .compatible = "samsung,exynos4412-tmu", }, > + { .compatible = "samsung,exynos5250-tmu", }, > + { .compatible = "samsung,exynos5260-tmu", }, > + { .compatible = "samsung,exynos5420-tmu", }, > + { .compatible = "samsung,exynos5420-tmu-ext-triminfo", }, > + { .compatible = "samsung,exynos5440-tmu", }, > + { .compatible = "samsung,exynos7-tmu", }, > + { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, exynos_tmu_match); > Acked-by: Lukasz Majewski <l.majewski@samsung.com> Thanks for clean up! -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table @ 2015-02-16 15:07 ` Lukasz Majewski 0 siblings, 0 replies; 18+ messages in thread From: Lukasz Majewski @ 2015-02-16 15:07 UTC (permalink / raw) To: linux-arm-kernel Hi Chanwoo, > This patch cleanup the code to use oneline for entry of exynos > compatible table. > > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/thermal/samsung/exynos_tmu.c | 38 > ++++++++++-------------------------- 1 file changed, 10 > insertions(+), 28 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c index b199fff..7e6baf5 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -919,34 +919,16 @@ static irqreturn_t exynos_tmu_irq(int irq, void > *id) } > > static const struct of_device_id exynos_tmu_match[] = { > - { > - .compatible = "samsung,exynos3250-tmu", > - }, > - { > - .compatible = "samsung,exynos4210-tmu", > - }, > - { > - .compatible = "samsung,exynos4412-tmu", > - }, > - { > - .compatible = "samsung,exynos5250-tmu", > - }, > - { > - .compatible = "samsung,exynos5260-tmu", > - }, > - { > - .compatible = "samsung,exynos5420-tmu", > - }, > - { > - .compatible = "samsung,exynos5420-tmu-ext-triminfo", > - }, > - { > - .compatible = "samsung,exynos5440-tmu", > - }, > - { > - .compatible = "samsung,exynos7-tmu", > - }, > - {}, > + { .compatible = "samsung,exynos3250-tmu", }, > + { .compatible = "samsung,exynos4210-tmu", }, > + { .compatible = "samsung,exynos4412-tmu", }, > + { .compatible = "samsung,exynos5250-tmu", }, > + { .compatible = "samsung,exynos5260-tmu", }, > + { .compatible = "samsung,exynos5420-tmu", }, > + { .compatible = "samsung,exynos5420-tmu-ext-triminfo", }, > + { .compatible = "samsung,exynos5440-tmu", }, > + { .compatible = "samsung,exynos7-tmu", }, > + { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, exynos_tmu_match); > Acked-by: Lukasz Majewski <l.majewski@samsung.com> Thanks for clean up! -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2015-02-16 17:00 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-02-16 14:20 [PATCH 0/3] thermal: exynos: Fix NULL pointer error and bug of PD_DET_EN of Exynos7 Chanwoo Choi 2015-02-16 14:20 ` Chanwoo Choi 2015-02-16 14:20 ` [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting Chanwoo Choi 2015-02-16 14:20 ` Chanwoo Choi 2015-02-16 15:06 ` Lukasz Majewski 2015-02-16 15:06 ` Lukasz Majewski 2015-02-16 16:15 ` Chanwoo Choi 2015-02-16 16:15 ` Chanwoo Choi 2015-02-16 16:28 ` Lukasz Majewski 2015-02-16 16:28 ` Lukasz Majewski 2015-02-16 17:00 ` Chanwoo Choi 2015-02-16 17:00 ` Chanwoo Choi 2015-02-16 14:20 ` [PATCH 2/3] thermal: exynos: Fix wrong control of power down detection mode for Exynos7 Chanwoo Choi 2015-02-16 14:20 ` Chanwoo Choi 2015-02-16 14:20 ` [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table Chanwoo Choi 2015-02-16 14:20 ` Chanwoo Choi 2015-02-16 15:07 ` Lukasz Majewski 2015-02-16 15:07 ` Lukasz Majewski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.