[Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).

[Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).

[Vatika Harlalka]

This patch addresses the checkpatch.pl warning

WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/emxx_udc/emxx_udc.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
index ee1b80d..90c5d1d 100644
--- a/drivers/staging/emxx_udc/emxx_udc.h
+++ b/drivers/staging/emxx_udc/emxx_udc.h
@@ -535,8 +535,7 @@ typedef struct _T_FC_REGS {
 
 	u8 Reserved1200[0x1000-0x200];	/* Reserved */
 
-} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
-
+} __aligned(32) T_FC_REGS, *PT_FC_REGS;
 
 
 
-- 
1.9.1

Re: [Outreachy kernel] [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).

[Julia Lawall]

On Tue, 17 Feb 2015, Vatika Harlalka wrote:

> This patch addresses the checkpatch.pl warning
>
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))

You could try to find out why it is preferred and explain that.  I don't
know if there is an interesting reason, but you might find some comments
in git logs.

> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/emxx_udc/emxx_udc.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index ee1b80d..90c5d1d 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -535,8 +535,7 @@ typedef struct _T_FC_REGS {
>
>  	u8 Reserved1200[0x1000-0x200];	/* Reserved */
>
> -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
> -
> +} __aligned(32) T_FC_REGS, *PT_FC_REGS;

It looks like an extra line has disappeared?  Was that intentional?

julia

>
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150217131048.GA5235%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).

[Vatika Harlalka]

[-- Attachment #1.1: Type: text/plain, Size: 2027 bytes --]



On Tuesday, 17 February 2015 18:52:23 UTC+5:30, Julia Lawall wrote:
>
> On Tue, 17 Feb 2015, Vatika Harlalka wrote: 
>
> > This patch addresses the checkpatch.pl warning 
> > 
> > WARNING: __aligned(size) is preferred over 
> __attribute__((aligned(size))) 
>
> You could try to find out why it is preferred and explain that.  I don't 
> know if there is an interesting reason, but you might find some comments 
> in git logs. 
>
>   >> Thanks for the input. I checked git logs and it seems that aligned(x) 
is a macro :
  >>     #define __aligned(x)                   __attribute__((aligned(x)))

> Signed-off-by: Vatika Harlalka <vatikah...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/emxx_udc/emxx_udc.h | 3 +-- 
> >  1 file changed, 1 insertion(+), 2 deletions(-) 
> > 
> > diff --git a/drivers/staging/emxx_udc/emxx_udc.h 
> b/drivers/staging/emxx_udc/emxx_udc.h 
> > index ee1b80d..90c5d1d 100644 
> > --- a/drivers/staging/emxx_udc/emxx_udc.h 
> > +++ b/drivers/staging/emxx_udc/emxx_udc.h 
> > @@ -535,8 +535,7 @@ typedef struct _T_FC_REGS { 
> > 
> >          u8 Reserved1200[0x1000-0x200];        /* Reserved */ 
> > 
> > -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS; 
> > - 
> > +} __aligned(32) T_FC_REGS, *PT_FC_REGS; 
>
> It looks like an extra line has disappeared?  Was that intentional? 
>
 
 >> The extra line was not a part of the original code. I had added and 
then removed it.
 

> julia 
>
> > 
> > 
> > -- 
> > 1.9.1 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20150217131048.GA5235%40gmail.com. 
>
> > For more options, visit https://groups.google.com/d/optout. 
> > 
>

[-- Attachment #1.2: Type: text/html, Size: 3439 bytes --]

Re: [Outreachy kernel] [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 278 bytes --]

>       It looks like an extra line has disappeared?  Was that
>       intentional?
>
>  
>  >> The extra line was not a part of the original code. I had added and then
> removed it.

OK, you should start over with the file and send a patch against the
original state.

julia

[PATCH] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size)

[aybuke ozdemir]

This fixes the following checkpatch.pl warnings in emxx_udc.h file:
WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))

Signed-off-by: aybuke ozdemir <aybuke.147@gmail.com>
---
 drivers/staging/emxx_udc/emxx_udc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
index ee1b80d..2ac216f 100644
--- a/drivers/staging/emxx_udc/emxx_udc.h
+++ b/drivers/staging/emxx_udc/emxx_udc.h
@@ -535,7 +535,7 @@ typedef struct _T_FC_REGS {
 
 	u8 Reserved1200[0x1000-0x200];	/* Reserved */
 
-} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
+} __aligned(32) T_FC_REGS, *PT_FC_REGS;
 
 
 
-- 
1.9.1