* [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).
@ 2015-02-17 13:10 Vatika Harlalka
2015-02-17 13:24 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Vatika Harlalka @ 2015-02-17 13:10 UTC (permalink / raw)
To: outreachy-kernel
This patch addresses the checkpatch.pl warning
WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
index ee1b80d..90c5d1d 100644
--- a/drivers/staging/emxx_udc/emxx_udc.h
+++ b/drivers/staging/emxx_udc/emxx_udc.h
@@ -535,8 +535,7 @@ typedef struct _T_FC_REGS {
u8 Reserved1200[0x1000-0x200]; /* Reserved */
-} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
-
+} __aligned(32) T_FC_REGS, *PT_FC_REGS;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).
2015-02-17 13:10 [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size) Vatika Harlalka
@ 2015-02-17 13:24 ` Julia Lawall
2015-02-17 14:05 ` Vatika Harlalka
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2015-02-17 13:24 UTC (permalink / raw)
To: Vatika Harlalka; +Cc: outreachy-kernel
On Tue, 17 Feb 2015, Vatika Harlalka wrote:
> This patch addresses the checkpatch.pl warning
>
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
You could try to find out why it is preferred and explain that. I don't
know if there is an interesting reason, but you might find some comments
in git logs.
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index ee1b80d..90c5d1d 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -535,8 +535,7 @@ typedef struct _T_FC_REGS {
>
> u8 Reserved1200[0x1000-0x200]; /* Reserved */
>
> -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
> -
> +} __aligned(32) T_FC_REGS, *PT_FC_REGS;
It looks like an extra line has disappeared? Was that intentional?
julia
>
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150217131048.GA5235%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).
2015-02-17 13:24 ` [Outreachy kernel] " Julia Lawall
@ 2015-02-17 14:05 ` Vatika Harlalka
2015-02-17 14:11 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Vatika Harlalka @ 2015-02-17 14:05 UTC (permalink / raw)
To: outreachy-kernel; +Cc: vatikaharlalka
[-- Attachment #1.1: Type: text/plain, Size: 2027 bytes --]
On Tuesday, 17 February 2015 18:52:23 UTC+5:30, Julia Lawall wrote:
>
> On Tue, 17 Feb 2015, Vatika Harlalka wrote:
>
> > This patch addresses the checkpatch.pl warning
> >
> > WARNING: __aligned(size) is preferred over
> __attribute__((aligned(size)))
>
> You could try to find out why it is preferred and explain that. I don't
> know if there is an interesting reason, but you might find some comments
> in git logs.
>
> >> Thanks for the input. I checked git logs and it seems that aligned(x)
is a macro :
>> #define __aligned(x) __attribute__((aligned(x)))
> Signed-off-by: Vatika Harlalka <vatikah...@gmail.com <javascript:>>
> > ---
> > drivers/staging/emxx_udc/emxx_udc.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/emxx_udc/emxx_udc.h
> b/drivers/staging/emxx_udc/emxx_udc.h
> > index ee1b80d..90c5d1d 100644
> > --- a/drivers/staging/emxx_udc/emxx_udc.h
> > +++ b/drivers/staging/emxx_udc/emxx_udc.h
> > @@ -535,8 +535,7 @@ typedef struct _T_FC_REGS {
> >
> > u8 Reserved1200[0x1000-0x200]; /* Reserved */
> >
> > -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
> > -
> > +} __aligned(32) T_FC_REGS, *PT_FC_REGS;
>
> It looks like an extra line has disappeared? Was that intentional?
>
>> The extra line was not a part of the original code. I had added and
then removed it.
> julia
>
> >
> >
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kern...@googlegroups.com <javascript:>.
> > To post to this group, send email to outreach...@googlegroups.com
> <javascript:>.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20150217131048.GA5235%40gmail.com.
>
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #1.2: Type: text/html, Size: 3439 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).
2015-02-17 14:05 ` Vatika Harlalka
@ 2015-02-17 14:11 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2015-02-17 14:11 UTC (permalink / raw)
To: Vatika Harlalka; +Cc: outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 278 bytes --]
> It looks like an extra line has disappeared? Was that
> intentional?
>
>
> >> The extra line was not a part of the original code. I had added and then
> removed it.
OK, you should start over with the file and send a patch against the
original state.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size)
2015-02-19 16:52 ` [Outreachy kernel] " Julia Lawall
@ 2015-02-19 17:10 ` Navya Sri Nizamkari
0 siblings, 0 replies; 6+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-19 17:10 UTC (permalink / raw)
To: outreachy-kernel; +Cc: aybuke.147
[-- Attachment #1.1: Type: text/plain, Size: 1745 bytes --]
I too submitted a patch for it in the older mailing list last month.
Navya
On Thursday, February 19, 2015 at 10:20:23 PM UTC+5:30, Julia Lawall wrote:
>
> On Thu, 19 Feb 2015, aybuke ozdemir wrote:
>
> > This fixes the following checkpatch.pl warnings in emxx_udc.h file:
> > WARNING: __aligned(size) is preferred over
> __attribute__((aligned(size)))
>
> This was done already by Vatika Harlalka. You can see what has been done
> in the mailing list archives.
>
> julia
>
> > Signed-off-by: aybuke ozdemir <aybuk...@gmail.com <javascript:>>
> > ---
> > drivers/staging/emxx_udc/emxx_udc.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/emxx_udc/emxx_udc.h
> b/drivers/staging/emxx_udc/emxx_udc.h
> > index ee1b80d..2ac216f 100644
> > --- a/drivers/staging/emxx_udc/emxx_udc.h
> > +++ b/drivers/staging/emxx_udc/emxx_udc.h
> > @@ -535,7 +535,7 @@ typedef struct _T_FC_REGS {
> >
> > u8 Reserved1200[0x1000-0x200]; /* Reserved */
> >
> > -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
> > +} __aligned(32) T_FC_REGS, *PT_FC_REGS;
> >
> >
> >
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kern...@googlegroups.com <javascript:>.
> > To post to this group, send email to outreach...@googlegroups.com
> <javascript:>.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/1424364343-3944-1-git-send-email-aybuke.147%40gmail.com.
>
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #1.2: Type: text/html, Size: 2719 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size)
2015-02-19 16:45 [PATCH] " aybuke ozdemir
@ 2015-02-19 16:52 ` Julia Lawall
2015-02-19 17:10 ` Navya Sri Nizamkari
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2015-02-19 16:52 UTC (permalink / raw)
To: aybuke ozdemir; +Cc: outreachy-kernel
On Thu, 19 Feb 2015, aybuke ozdemir wrote:
> This fixes the following checkpatch.pl warnings in emxx_udc.h file:
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
This was done already by Vatika Harlalka. You can see what has been done
in the mailing list archives.
julia
> Signed-off-by: aybuke ozdemir <aybuke.147@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index ee1b80d..2ac216f 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -535,7 +535,7 @@ typedef struct _T_FC_REGS {
>
> u8 Reserved1200[0x1000-0x200]; /* Reserved */
>
> -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
> +} __aligned(32) T_FC_REGS, *PT_FC_REGS;
>
>
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424364343-3944-1-git-send-email-aybuke.147%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-19 17:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 13:10 [Patch] Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size) Vatika Harlalka
2015-02-17 13:24 ` [Outreachy kernel] " Julia Lawall
2015-02-17 14:05 ` Vatika Harlalka
2015-02-17 14:11 ` Julia Lawall
2015-02-19 16:45 [PATCH] " aybuke ozdemir
2015-02-19 16:52 ` [Outreachy kernel] " Julia Lawall
2015-02-19 17:10 ` Navya Sri Nizamkari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.