From: Catalin Marinas <catalin.marinas@arm.com>
To: Laura Abbott <lauraa@codeaurora.org>
Cc: Will Deacon <will.deacon@arm.com>,
Kees Cook <keescook@chromium.org>,
Russell King <linux@arm.linux.org.uk>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] arm64: Don't use is_module_addr in setting page attributes
Date: Wed, 4 Mar 2015 16:47:02 +0000 [thread overview]
Message-ID: <20150304164701.GY28951@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1424902497-32141-2-git-send-email-lauraa@codeaurora.org>
On Wed, Feb 25, 2015 at 02:14:55PM -0800, Laura Abbott wrote:
>
> The set_memory_* functions currently only support module
> addresses. The addresses are validated using is_module_addr.
> That function is special though and relies on internal state
> in the module subsystem to work properly. At the time of
> module initialization and calling set_memory_*, it's too early
> for is_module_addr to work properly so it always returns
> false. Rather than be subject to the whims of the module state,
> just bounds check against the module virtual address range.
>
> Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
Not sure which tree this would be merged through, so:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
I can pick up the arm64 patch and the module.c one with Rusty's ack (as
for the arm one, I think it could go in via rmk's patch system).
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm64: Don't use is_module_addr in setting page attributes
Date: Wed, 4 Mar 2015 16:47:02 +0000 [thread overview]
Message-ID: <20150304164701.GY28951@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1424902497-32141-2-git-send-email-lauraa@codeaurora.org>
On Wed, Feb 25, 2015 at 02:14:55PM -0800, Laura Abbott wrote:
>
> The set_memory_* functions currently only support module
> addresses. The addresses are validated using is_module_addr.
> That function is special though and relies on internal state
> in the module subsystem to work properly. At the time of
> module initialization and calling set_memory_*, it's too early
> for is_module_addr to work properly so it always returns
> false. Rather than be subject to the whims of the module state,
> just bounds check against the module virtual address range.
>
> Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
Not sure which tree this would be merged through, so:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
I can pick up the arm64 patch and the module.c one with Rusty's ack (as
for the arm one, I think it could go in via rmk's patch system).
--
Catalin
next prev parent reply other threads:[~2015-03-04 16:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 22:14 [PATCH 0/3] CONFIG_DEBUG_SET_MODULE_RONX fixups Laura Abbott
2015-02-25 22:14 ` Laura Abbott
2015-02-25 22:14 ` [PATCH 1/3] arm64: Don't use is_module_addr in setting page attributes Laura Abbott
2015-02-25 22:14 ` Laura Abbott
2015-03-04 16:47 ` Catalin Marinas [this message]
2015-03-04 16:47 ` Catalin Marinas
2015-02-25 22:14 ` [PATCH 2/3] arm: " Laura Abbott
2015-02-25 22:14 ` Laura Abbott
2015-02-25 22:14 ` [PATCH 3/3] kernel/module.c: Update debug alignment after symtable generation Laura Abbott
2015-02-25 22:14 ` Laura Abbott
2015-02-26 1:33 ` Rusty Russell
2015-02-26 1:33 ` Rusty Russell
2015-02-25 22:17 ` [PATCH 0/3] CONFIG_DEBUG_SET_MODULE_RONX fixups Kees Cook
2015-02-25 22:17 ` Kees Cook
2015-03-24 12:04 ` Paolo Pisati
2015-03-24 12:04 ` Paolo Pisati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304164701.GY28951@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=keescook@chromium.org \
--cc=lauraa@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rusty@rustcorp.com.au \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.