All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Pisati <p.pisati@gmail.com>
To: Laura Abbott <lauraa@codeaurora.org>
Cc: Kees Cook <keescook@chromium.org>,
	Will Deacon <will.deacon@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Russell King <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] CONFIG_DEBUG_SET_MODULE_RONX fixups
Date: Tue, 24 Mar 2015 13:04:47 +0100	[thread overview]
Message-ID: <20150324120447.GA3570@luxor.wired.org> (raw)
In-Reply-To: <CAGXu5jKKn1f7bnp3Ezsc3o_iqV19Gu62-83ub3s7Rwu=oK7kBA@mail.gmail.com>

On Wed, Feb 25, 2015 at 02:17:55PM -0800, Kees Cook wrote:
> On Wed, Feb 25, 2015 at 2:14 PM, Laura Abbott <lauraa@codeaurora.org> wrote:
> > Hi,
> >
> > CONFIG_DEBUG_SET_MODULE_RONX is currently non-functional on arm and arm64
> > because of changes in behavior of is_module_addr. This series fixes
> > both arm and arm64 to work correctly and corrects a minor bug
> > related to section alignment in modules.
> >
> > Laura Abbott (3):
> >   arm64: Don't use is_module_addr in setting page attributes
> >   arm: Don't use is_module_addr in setting page attributes
> >   kernel/module.c: Update debug alignment after symtable generation
> >
> >  arch/arm/mm/pageattr.c   | 5 ++++-
> >  arch/arm64/mm/pageattr.c | 5 ++++-
> >  kernel/module.c          | 2 ++
> >  3 files changed, 10 insertions(+), 2 deletions(-)
> 
> Thanks for fixing this!
> 
> Out of curiosity, which change broke DEBUG_SET_MODULE_RONX ? (i.e.
> does this need a CC: stable, and if so, through which release?)

we need it for 3.19.x too:

without your patches:

root@beaglebone:~# cat /sys/module/bridge/sections/.text
0xbf199000
root@beaglebone:~# cat /sys/module/bridge/sections/.data
0xbf1ae000
root@beaglebone:~# grep -e 0xbf199000 -e 0xbf1ae000 /sys/kernel/debug/kernel_page_tables
0xbf199000-0xbf1b6000         116K     RW x      MEM/CACHED/WBRA

with you patches:

root@beaglebone:~# cat /sys/module/bridge/sections/.text                                                                                   
0xbf191000
root@beaglebone:~# cat /sys/module/bridge/sections/.data
0xbf1a6000
root@beaglebone:~# grep -e 0xbf191000 -e 0xbf1a6000 /sys/kernel/debug/kernel_page_tables                                                   
0xbf191000-0xbf1a2000          68K     ro x      MEM/CACHED/WBRA
0xbf1a2000-0xbf1a6000          16K     ro NX     MEM/CACHED/WBRA
0xbf1a6000-0xbf1ae000          32K     RW NX     MEM/CACHED/WBRA
root@beaglebone:~# uname -a
Linux beaglebone 3.19.0-9-generic #9~RONXFIX SMP Tue Mar 24 10:34:39 UTC 2015
armv7l armv7l armv7l GNU/Linux
root@beaglebone:~#

can you cc: stable@ ?
-- 
bye,
p.

WARNING: multiple messages have this Message-ID (diff)
From: p.pisati@gmail.com (Paolo Pisati)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] CONFIG_DEBUG_SET_MODULE_RONX fixups
Date: Tue, 24 Mar 2015 13:04:47 +0100	[thread overview]
Message-ID: <20150324120447.GA3570@luxor.wired.org> (raw)
In-Reply-To: <CAGXu5jKKn1f7bnp3Ezsc3o_iqV19Gu62-83ub3s7Rwu=oK7kBA@mail.gmail.com>

On Wed, Feb 25, 2015 at 02:17:55PM -0800, Kees Cook wrote:
> On Wed, Feb 25, 2015 at 2:14 PM, Laura Abbott <lauraa@codeaurora.org> wrote:
> > Hi,
> >
> > CONFIG_DEBUG_SET_MODULE_RONX is currently non-functional on arm and arm64
> > because of changes in behavior of is_module_addr. This series fixes
> > both arm and arm64 to work correctly and corrects a minor bug
> > related to section alignment in modules.
> >
> > Laura Abbott (3):
> >   arm64: Don't use is_module_addr in setting page attributes
> >   arm: Don't use is_module_addr in setting page attributes
> >   kernel/module.c: Update debug alignment after symtable generation
> >
> >  arch/arm/mm/pageattr.c   | 5 ++++-
> >  arch/arm64/mm/pageattr.c | 5 ++++-
> >  kernel/module.c          | 2 ++
> >  3 files changed, 10 insertions(+), 2 deletions(-)
> 
> Thanks for fixing this!
> 
> Out of curiosity, which change broke DEBUG_SET_MODULE_RONX ? (i.e.
> does this need a CC: stable, and if so, through which release?)

we need it for 3.19.x too:

without your patches:

root at beaglebone:~# cat /sys/module/bridge/sections/.text
0xbf199000
root at beaglebone:~# cat /sys/module/bridge/sections/.data
0xbf1ae000
root at beaglebone:~# grep -e 0xbf199000 -e 0xbf1ae000 /sys/kernel/debug/kernel_page_tables
0xbf199000-0xbf1b6000         116K     RW x      MEM/CACHED/WBRA

with you patches:

root at beaglebone:~# cat /sys/module/bridge/sections/.text                                                                                   
0xbf191000
root at beaglebone:~# cat /sys/module/bridge/sections/.data
0xbf1a6000
root at beaglebone:~# grep -e 0xbf191000 -e 0xbf1a6000 /sys/kernel/debug/kernel_page_tables                                                   
0xbf191000-0xbf1a2000          68K     ro x      MEM/CACHED/WBRA
0xbf1a2000-0xbf1a6000          16K     ro NX     MEM/CACHED/WBRA
0xbf1a6000-0xbf1ae000          32K     RW NX     MEM/CACHED/WBRA
root at beaglebone:~# uname -a
Linux beaglebone 3.19.0-9-generic #9~RONXFIX SMP Tue Mar 24 10:34:39 UTC 2015
armv7l armv7l armv7l GNU/Linux
root at beaglebone:~#

can you cc: stable@ ?
-- 
bye,
p.

  reply	other threads:[~2015-03-24 12:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 22:14 [PATCH 0/3] CONFIG_DEBUG_SET_MODULE_RONX fixups Laura Abbott
2015-02-25 22:14 ` Laura Abbott
2015-02-25 22:14 ` [PATCH 1/3] arm64: Don't use is_module_addr in setting page attributes Laura Abbott
2015-02-25 22:14   ` Laura Abbott
2015-03-04 16:47   ` Catalin Marinas
2015-03-04 16:47     ` Catalin Marinas
2015-02-25 22:14 ` [PATCH 2/3] arm: " Laura Abbott
2015-02-25 22:14   ` Laura Abbott
2015-02-25 22:14 ` [PATCH 3/3] kernel/module.c: Update debug alignment after symtable generation Laura Abbott
2015-02-25 22:14   ` Laura Abbott
2015-02-26  1:33   ` Rusty Russell
2015-02-26  1:33     ` Rusty Russell
2015-02-25 22:17 ` [PATCH 0/3] CONFIG_DEBUG_SET_MODULE_RONX fixups Kees Cook
2015-02-25 22:17   ` Kees Cook
2015-03-24 12:04   ` Paolo Pisati [this message]
2015-03-24 12:04     ` Paolo Pisati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324120447.GA3570@luxor.wired.org \
    --to=p.pisati@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=keescook@chromium.org \
    --cc=lauraa@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rusty@rustcorp.com.au \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.