From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] misc: led: Add PCA9551 LED driver
Date: Wed, 11 Mar 2015 10:40:32 -0400 [thread overview]
Message-ID: <20150311144032.GO32541@bill-the-cat> (raw)
In-Reply-To: <1426063900-7267-4-git-send-email-sr@denx.de>
On Wed, Mar 11, 2015 at 09:51:40AM +0100, Stefan Roese wrote:
> This patch adds a driver for the PCA9551 LED controller.
>
> Originated-by: Timo Herbrecher <t.herbrecher@gateware.de>
> Signed-off-by: Stefan Roese <sr@denx.de>
Reviewed-by: Tom Rini <trini@konsulko.com>
But:
> +struct pca9551_blink_rate {
> + u8 psc; /* Frequency preescaler, see PCA9551_7.pdf p. 6 */
> + u8 pwm; /* Pulse width modulation, see PCA9551_7.pdf p. 6 */
> +} __packed;
Yes, really, this must be packed because otherwise we get unwanted
padding in between these u8s?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150311/7aaa2f11/attachment.sig>
next prev parent reply other threads:[~2015-03-11 14:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 8:51 [U-Boot] [PATCH] autoboot.c: Add feature to stop autobooting via SHA256 encrypted password Stefan Roese
2015-03-11 8:51 ` [U-Boot] [PATCH] bootcount: Add dcache flush to bootcount_store() Stefan Roese
2015-03-11 14:39 ` Tom Rini
2015-03-13 13:48 ` [U-Boot] " Tom Rini
2015-03-13 14:34 ` Tom Rini
2015-03-15 18:30 ` Tom Rini
2015-03-16 15:57 ` York Sun
2015-03-16 17:05 ` Tom Rini
2015-03-16 17:11 ` York Sun
2015-03-16 17:22 ` Tom Rini
2015-03-17 9:00 ` Holger Brunck
2015-03-27 13:18 ` Stefan Roese
2015-03-27 13:42 ` Nitin Garg
2015-03-27 15:07 ` [U-Boot] [RFC] powerpc: add 2 common dcache assembly functions Valentin Longchamp
2015-03-28 18:07 ` Tom Rini
2015-05-05 16:35 ` [U-Boot] [U-Boot, RFC] " York Sun
2015-03-11 8:51 ` [U-Boot] [PATCH] cmd_led: Extend led command to support blinking and more leds Stefan Roese
2015-03-11 14:38 ` Tom Rini
2015-04-23 22:02 ` [U-Boot] " Tom Rini
2015-03-11 8:51 ` [U-Boot] [PATCH] misc: led: Add PCA9551 LED driver Stefan Roese
2015-03-11 14:40 ` Tom Rini [this message]
2015-03-11 14:46 ` Fabio Estevam
2015-03-11 14:36 ` [U-Boot] [PATCH] autoboot.c: Add feature to stop autobooting via SHA256 encrypted password Tom Rini
2015-03-12 8:39 ` Stefan Roese
2015-03-13 2:48 ` Simon Glass
2015-03-13 7:15 ` Stefan Roese
2015-03-23 20:28 ` Simon Glass
2015-05-05 15:06 ` Stefan Roese
2015-05-05 15:12 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311144032.GO32541@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.