From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ragavendra BN <ragavendra.bn@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: braces, indents, spaces fix
Date: Fri, 13 Mar 2015 11:24:29 +0530 [thread overview]
Message-ID: <20150313055429.GA4979@sudip-PC> (raw)
In-Reply-To: <20150313051436.GA10544@localhost.localdomain>
On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl script check.
your From: is still having [user] in your email address.
and you are doing too many things in a single patch. one patch should
do only one type of change.
>
>
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
>
this extra blank line is not necessary here.
regards
sudip
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ragavendra BN <ragavendra.bn@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: braces, indents, spaces fix
Date: Fri, 13 Mar 2015 05:54:42 +0000 [thread overview]
Message-ID: <20150313055429.GA4979@sudip-PC> (raw)
In-Reply-To: <20150313051436.GA10544@localhost.localdomain>
On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl script check.
your From: is still having [user] in your email address.
and you are doing too many things in a single patch. one patch should
do only one type of change.
>
>
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
>
this extra blank line is not necessary here.
regards
sudip
next parent reply other threads:[~2015-03-13 5:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150313051436.GA10544@localhost.localdomain>
2015-03-13 5:54 ` Sudip Mukherjee [this message]
2015-03-13 5:54 ` [PATCH] staging: sm750fb: braces, indents, spaces fix Sudip Mukherjee
2015-03-13 6:11 Ragavendra BN
2015-03-13 6:11 ` Ragavendra BN
2015-03-13 7:45 ` Dan Carpenter
2015-03-13 7:45 ` Dan Carpenter
[not found] ` <CAPBgb4=np7Bs=sMTZHpZZ1Ef7uriUDYjjz6Y7+49Vs1rOVo59w@mail.gmail.com>
2015-03-14 8:39 ` Greg KH
2015-03-14 8:39 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-03-13 3:43 Ragavendra BN
2015-03-13 3:43 ` Ragavendra BN
2015-03-13 4:58 ` Sudip Mukherjee
2015-03-13 4:58 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313055429.GA4979@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ragavendra.bn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.