From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ragavendra BN <ragavendra.bn@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: braces, indents, spaces fix
Date: Fri, 13 Mar 2015 10:28:47 +0530 [thread overview]
Message-ID: <20150313045847.GB3687@sudip-PC> (raw)
In-Reply-To: <20150313034333.GA10618@localhost.localdomain>
On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
>
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checkpath.pl script check.
>
Signed-off-by line should come here before the ---
> ---
not at the top like you are giving.
Greg has told you once, I am telling now for the second time.
regards
sudip
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ragavendra BN <ragavendra.bn@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: braces, indents, spaces fix
Date: Fri, 13 Mar 2015 04:58:57 +0000 [thread overview]
Message-ID: <20150313045847.GB3687@sudip-PC> (raw)
In-Reply-To: <20150313034333.GA10618@localhost.localdomain>
On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
>
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checkpath.pl script check.
>
Signed-off-by line should come here before the ---
> ---
not at the top like you are giving.
Greg has told you once, I am telling now for the second time.
regards
sudip
next prev parent reply other threads:[~2015-03-13 4:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 3:43 [PATCH] staging: sm750fb: braces, indents, spaces fix Ragavendra BN
2015-03-13 3:43 ` Ragavendra BN
2015-03-13 4:58 ` Sudip Mukherjee [this message]
2015-03-13 4:58 ` Sudip Mukherjee
[not found] <20150313051436.GA10544@localhost.localdomain>
2015-03-13 5:54 ` Sudip Mukherjee
2015-03-13 5:54 ` Sudip Mukherjee
2015-03-13 6:11 Ragavendra BN
2015-03-13 6:11 ` Ragavendra BN
2015-03-13 7:45 ` Dan Carpenter
2015-03-13 7:45 ` Dan Carpenter
[not found] ` <CAPBgb4=np7Bs=sMTZHpZZ1Ef7uriUDYjjz6Y7+49Vs1rOVo59w@mail.gmail.com>
2015-03-14 8:39 ` Greg KH
2015-03-14 8:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313045847.GB3687@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ragavendra.bn@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.