All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	"Eliad Peller" <eliad@wizery.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Enric Balletbo i Serra" <eballetbo@gmail.com>,
	"Sekhar Nori" <nsekhar@ti.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Kevin Hilman" <khilman@deeprootsystems.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Javier Martinez Canillas" <javier@dowhile0.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Luciano Coelho" <luca@coelho.fi>,
	"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data
Date: Mon, 16 Mar 2015 08:29:39 -0700	[thread overview]
Message-ID: <20150316152939.GP5264@atomide.com> (raw)
In-Reply-To: <2070859.WcMooC33YH@wuerfel>

* Arnd Bergmann <arnd@arndb.de> [150315 05:10]:
> On Sunday 15 March 2015 10:50:42 Eliad Peller wrote:
> > yeah, i missed it :/
> > 
> > looks like there's no platform that defines platform data for it.
> > i'll replace the dev_get_platdata() with a function that only parses
> > the clock-frequency properties (the irq is taken in this case from the
> > spi_device).
> > (or maybe i should just drop it, as no one actually uses it?)
> 
> I don't think we should drop the driver, but dropping the platform_data
> support sounds reasonable. New users of this driver should all be using
> DT, and if there is a good reason to use platform_data, it's easily
> put back.

Well we have n8x0 and n900 using the spi driver. For those, n8x0 boot
all in dts mode, but n900 still also boots in legacy mode. It seems the
board-rx51-peripherals.c only passes the power_gpio though, so that
should be easy to keep around.

We should keep things still working for n900 in legacy mode until the
pending regressions with device tree based booting have been cleared
for at least one merge cycle. I believe the last pending issues is the
support for ATAG_REVISION in device tree mode as posted by Pali.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Eliad Peller" <eliad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	"Ian Campbell"
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	"Enric Balletbo i Serra"
	<eballetbo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Sekhar Nori" <nsekhar-l0cyMroinI0@public.gmane.org>,
	"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Kevin Hilman"
	<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"Javier Martinez Canillas"
	<javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Luciano Coelho" <luca-XPOmlcxoEMv1KXRcyAk9cg@public.gmane.org>,
	"Pali Rohár" <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data
Date: Mon, 16 Mar 2015 08:29:39 -0700	[thread overview]
Message-ID: <20150316152939.GP5264@atomide.com> (raw)
In-Reply-To: <2070859.WcMooC33YH@wuerfel>

* Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> [150315 05:10]:
> On Sunday 15 March 2015 10:50:42 Eliad Peller wrote:
> > yeah, i missed it :/
> > 
> > looks like there's no platform that defines platform data for it.
> > i'll replace the dev_get_platdata() with a function that only parses
> > the clock-frequency properties (the irq is taken in this case from the
> > spi_device).
> > (or maybe i should just drop it, as no one actually uses it?)
> 
> I don't think we should drop the driver, but dropping the platform_data
> support sounds reasonable. New users of this driver should all be using
> DT, and if there is a good reason to use platform_data, it's easily
> put back.

Well we have n8x0 and n900 using the spi driver. For those, n8x0 boot
all in dts mode, but n900 still also boots in legacy mode. It seems the
board-rx51-peripherals.c only passes the power_gpio though, so that
should be easy to keep around.

We should keep things still working for n900 in legacy mode until the
pending regressions with device tree based booting have been cleared
for at least one merge cycle. I believe the last pending issues is the
support for ATAG_REVISION in device tree mode as posted by Pali.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data
Date: Mon, 16 Mar 2015 08:29:39 -0700	[thread overview]
Message-ID: <20150316152939.GP5264@atomide.com> (raw)
In-Reply-To: <2070859.WcMooC33YH@wuerfel>

* Arnd Bergmann <arnd@arndb.de> [150315 05:10]:
> On Sunday 15 March 2015 10:50:42 Eliad Peller wrote:
> > yeah, i missed it :/
> > 
> > looks like there's no platform that defines platform data for it.
> > i'll replace the dev_get_platdata() with a function that only parses
> > the clock-frequency properties (the irq is taken in this case from the
> > spi_device).
> > (or maybe i should just drop it, as no one actually uses it?)
> 
> I don't think we should drop the driver, but dropping the platform_data
> support sounds reasonable. New users of this driver should all be using
> DT, and if there is a good reason to use platform_data, it's easily
> put back.

Well we have n8x0 and n900 using the spi driver. For those, n8x0 boot
all in dts mode, but n900 still also boots in legacy mode. It seems the
board-rx51-peripherals.c only passes the power_gpio though, so that
should be easy to keep around.

We should keep things still working for n900 in legacy mode until the
pending regressions with device tree based booting have been cleared
for at least one merge cycle. I believe the last pending issues is the
support for ATAG_REVISION in device tree mode as posted by Pali.

Regards,

Tony

  reply	other threads:[~2015-03-16 15:34 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 12:09 [PATCH v6 0/6] wlcore: add device-tree support Eliad Peller
2015-03-12 12:09 ` Eliad Peller
2015-03-12 12:09 ` Eliad Peller
2015-03-12 12:09 ` [PATCH v6 1/6] wlcore: set irq_trigger in board files instead of hiding behind a quirk Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09 ` [PATCH v6 2/6] wl12xx: use frequency instead of enumerations for pdata clocks Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-13 15:00   ` Tony Lindgren
2015-03-13 15:00     ` Tony Lindgren
2015-03-13 15:00     ` Tony Lindgren
2015-03-15  8:43     ` Eliad Peller
2015-03-15  8:43       ` Eliad Peller
2015-03-15 12:08       ` Arnd Bergmann
2015-03-15 12:08         ` Arnd Bergmann
2015-03-15 12:08         ` Arnd Bergmann
2015-03-16  6:50         ` Kalle Valo
2015-03-16  6:50           ` Kalle Valo
2015-03-16  6:50           ` Kalle Valo
2015-03-16 15:15           ` Tony Lindgren
2015-03-16 15:15             ` Tony Lindgren
2015-03-20 14:00             ` Kalle Valo
2015-03-20 14:00               ` Kalle Valo
2015-03-20 14:00               ` Kalle Valo
2015-03-20 14:54               ` Tony Lindgren
2015-03-20 14:54                 ` Tony Lindgren
2015-03-12 12:09 ` [PATCH v6 3/6] dt: bindings: add TI's wilink wireless device Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09 ` [PATCH v6 4/6] wlcore: add device-tree support Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09 ` [PATCH v6 5/6] ARM: dts: add wl12xx/wl18xx bindings Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-13  8:01   ` Javier Martinez Canillas
2015-03-13  8:01     ` Javier Martinez Canillas
2015-03-13  8:01     ` Javier Martinez Canillas
2015-03-13  8:17     ` Enric Balletbo Serra
2015-03-13  8:17       ` Enric Balletbo Serra
2015-03-13  8:17       ` Enric Balletbo Serra
2015-03-16 13:08       ` Pau Pajuel
2015-03-17  7:02         ` Eliad Peller
2015-03-17  7:02           ` Eliad Peller
2015-03-17  7:02           ` Eliad Peller
2015-03-13 15:27   ` Tony Lindgren
2015-03-13 15:27     ` Tony Lindgren
2015-03-13 15:27     ` Tony Lindgren
2015-03-15  8:55     ` Eliad Peller
2015-03-15  8:55       ` Eliad Peller
2015-03-15  8:55       ` Eliad Peller
2015-03-12 12:09 ` [PATCH v6 6/6] wlcore: remove wl12xx_platform_data Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-12 12:09   ` Eliad Peller
2015-03-13 15:13   ` Tony Lindgren
2015-03-13 15:13     ` Tony Lindgren
2015-03-13 15:13     ` Tony Lindgren
2015-03-15  8:50     ` Eliad Peller
2015-03-15  8:50       ` Eliad Peller
2015-03-15  8:50       ` Eliad Peller
2015-03-15 12:08       ` Arnd Bergmann
2015-03-15 12:08         ` Arnd Bergmann
2015-03-15 12:08         ` Arnd Bergmann
2015-03-16 15:29         ` Tony Lindgren [this message]
2015-03-16 15:29           ` Tony Lindgren
2015-03-16 15:29           ` Tony Lindgren
2015-03-16 18:25           ` Sebastian Reichel
2015-03-16 18:25             ` Sebastian Reichel
2015-03-16 18:24             ` Tony Lindgren
2015-03-16 18:24               ` Tony Lindgren
2015-03-16 18:24               ` Tony Lindgren
2015-03-17  6:58               ` Eliad Peller
2015-03-17  6:58                 ` Eliad Peller
2015-03-16 20:58           ` Pali Rohár
2015-03-16 20:58             ` Pali Rohár
2015-03-16 20:58             ` Pali Rohár
2015-03-16 21:01             ` Tony Lindgren
2015-03-16 21:01               ` Tony Lindgren
2015-03-16 21:01               ` Tony Lindgren
2015-03-16 21:15               ` Pali Rohár
2015-03-16 21:15                 ` Pali Rohár
2015-03-16 21:25                 ` Tony Lindgren
2015-03-16 21:25                   ` Tony Lindgren
2015-03-16 21:25                   ` Tony Lindgren
2015-03-13 16:11 ` [PATCH v6 0/6] wlcore: add device-tree support Sébastien Szymanski
2015-03-13 16:11   ` Sébastien Szymanski
2015-03-13 16:11   ` Sébastien Szymanski
2015-03-15  8:58   ` Eliad Peller
2015-03-15  8:58     ` Eliad Peller
2015-03-15  8:58     ` Eliad Peller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316152939.GP5264@atomide.com \
    --to=tony@atomide.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eballetbo@gmail.com \
    --cc=eliad@wizery.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=javier@dowhile0.org \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    --cc=mark.rutland@arm.com \
    --cc=nsekhar@ti.com \
    --cc=pali.rohar@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.