From: Richard Cochran <richardcochran@gmail.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
john.stultz@linaro.com, tglx@linutronix.de, arnd@linaro.org
Subject: Re: [PATCH 1/4] ptp/chardev:Introduce another option to get/set time in ptp_clock_info structure
Date: Thu, 19 Mar 2015 08:48:16 +0100 [thread overview]
Message-ID: <20150319074816.GA4568@localhost.localdomain> (raw)
In-Reply-To: <1426743909-24335-2-git-send-email-baolin.wang@linaro.org>
On Thu, Mar 19, 2015 at 01:45:06PM +0800, Baolin Wang wrote:
> diff --git a/include/linux/ptp_clock_kernel.h b/include/linux/ptp_clock_kernel.h
> index 0d8ff3f..86decc2 100644
> --- a/include/linux/ptp_clock_kernel.h
> +++ b/include/linux/ptp_clock_kernel.h
> @@ -105,7 +105,9 @@ struct ptp_clock_info {
> int (*adjfreq)(struct ptp_clock_info *ptp, s32 delta);
> int (*adjtime)(struct ptp_clock_info *ptp, s64 delta);
> int (*gettime)(struct ptp_clock_info *ptp, struct timespec *ts);
> + int (*getktime)(struct ptp_clock_info *ptp, ktime_t *kt);
> int (*settime)(struct ptp_clock_info *ptp, const struct timespec *ts);
> + int (*setktime)(struct ptp_clock_info *ptp, ktime_t kt);
You have added alternate methods that do exactly the same thing as
gettime/settime. Then, you convert just two drivers over to the new
interface.
I don't want to have this job half done, with some driver being
forgotten along the way. Please, just change the signatures of
gettime/settime and convert *all* of the drivers. After all, there
are not that many drivers to convert.
Thanks,
Richard
> int (*enable)(struct ptp_clock_info *ptp,
> struct ptp_clock_request *request, int on);
> int (*verify)(struct ptp_clock_info *ptp, unsigned int pin,
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2015-03-19 7:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 5:45 [PATCH 0/4] Introduce another options to set/get time with "ktime_t" type Baolin Wang
2015-03-19 5:45 ` [PATCH 1/4] ptp/chardev:Introduce another option to get/set time in ptp_clock_info structure Baolin Wang
2015-03-19 7:48 ` Richard Cochran [this message]
2015-03-19 5:45 ` [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type Baolin Wang
2015-03-19 7:54 ` Richard Cochran
[not found] ` <CAMz4kuKyDFCqd-LfoSKJf+tkXdzzLwtPJdp-nF6NbKU8W5HHpQ@mail.gmail.com>
2015-03-20 6:26 ` Richard Cochran
2015-03-20 13:43 ` Arnd Bergmann
2015-03-20 16:49 ` Richard Cochran
2015-03-21 1:16 ` Arnd Bergmann
2015-03-21 7:24 ` Richard Cochran
2015-03-21 16:52 ` Richard Cochran
2015-03-22 2:47 ` Arnd Bergmann
2015-03-21 9:21 ` Richard Cochran
2015-03-19 5:45 ` [PATCH 3/4] ptp/pch:Replace timespec with ktime_t in ptp_pch.c Baolin Wang
2015-03-19 5:45 ` [PATCH 4/4] ptp/ixp46x:Replace timespec with ktime_t in ptp_ixp46x.c Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319074816.GA4568@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=arnd@linaro.org \
--cc=baolin.wang@linaro.org \
--cc=john.stultz@linaro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.