From: Arnd Bergmann <arnd@linaro.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.com>,
tglx@linutronix.de
Subject: Re: [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type
Date: Fri, 20 Mar 2015 14:43:42 +0100 [thread overview]
Message-ID: <201503201443.42672.arnd@linaro.org> (raw)
In-Reply-To: <20150320062603.GC4417@localhost.localdomain>
On Friday 20 March 2015, Richard Cochran wrote:
> On Fri, Mar 20, 2015 at 09:54:05AM +0800, Baolin Wang wrote:
> > Next patch series will contain all of the drivers which need to be changed.
> > But i think the conditional in ptp_clock.c can still in there.
>
> Why?
>
> > Because our plan is once all the drivers are converted, i will remove the
> > conditional, along with the original function pointer.
> > Is that OK? Thanks!
>
> I want to avoid a patch series that introduces something, only to
> remove it later on. Sometimes you have to do that way for a complex
> transformation, but this case is rather simple.
>
> You can change the gettime signature in one patch, and the settime in
> a second patch.
We normally try to avoid doing those global API changes across many drivers
that are maintained by different people. Introducing the new API first
is the easiest way to get the per-driver patches reviewed individually
by the respective maintainers.
Doing gettime separately from settime would be rather silly here, so trying
to avoid the conditional would mean doing a single large patch across all
drivers.
I do agree however that we should merge the entire series at once so
we end up with a reasonable state afterwards, and we only need the conditional
in order to have a bisectable git history.
Arnd
next prev parent reply other threads:[~2015-03-20 13:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 5:45 [PATCH 0/4] Introduce another options to set/get time with "ktime_t" type Baolin Wang
2015-03-19 5:45 ` [PATCH 1/4] ptp/chardev:Introduce another option to get/set time in ptp_clock_info structure Baolin Wang
2015-03-19 7:48 ` Richard Cochran
2015-03-19 5:45 ` [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type Baolin Wang
2015-03-19 7:54 ` Richard Cochran
[not found] ` <CAMz4kuKyDFCqd-LfoSKJf+tkXdzzLwtPJdp-nF6NbKU8W5HHpQ@mail.gmail.com>
2015-03-20 6:26 ` Richard Cochran
2015-03-20 13:43 ` Arnd Bergmann [this message]
2015-03-20 16:49 ` Richard Cochran
2015-03-21 1:16 ` Arnd Bergmann
2015-03-21 7:24 ` Richard Cochran
2015-03-21 16:52 ` Richard Cochran
2015-03-22 2:47 ` Arnd Bergmann
2015-03-21 9:21 ` Richard Cochran
2015-03-19 5:45 ` [PATCH 3/4] ptp/pch:Replace timespec with ktime_t in ptp_pch.c Baolin Wang
2015-03-19 5:45 ` [PATCH 4/4] ptp/ixp46x:Replace timespec with ktime_t in ptp_ixp46x.c Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503201443.42672.arnd@linaro.org \
--to=arnd@linaro.org \
--cc=baolin.wang@linaro.org \
--cc=john.stultz@linaro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.