From: Arnd Bergmann <arnd@linaro.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.com>,
tglx@linutronix.de
Subject: Re: [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type
Date: Sun, 22 Mar 2015 03:47:06 +0100 [thread overview]
Message-ID: <201503220347.06550.arnd@linaro.org> (raw)
In-Reply-To: <20150321072407.GA4701@netboy>
On Saturday 21 March 2015, Richard Cochran wrote:
> On Sat, Mar 21, 2015 at 02:16:41AM +0100, Arnd Bergmann wrote:
> > This was the first idea, but it seems a bit silly when all the drivers
> > use a 64-bit nanosecond value just like ktime_t.
>
> Not true of all drivers. In fact, the most capable devices (phyter
> and i210) have a split representation.
Ok, sorry for missing those earlier, I thought I'd looked at all
of them and not found any that did it like this.
> > but it is not any more
> > or less efficient than the previous method.
>
> Right, so no point in changing it.
>
> > Of course, but it would be rather bad style.
>
> Introducing useless code just to remove it again is also bad style.
>
> I disagree with the approach presented here. The problem at hand is
> the 2038 issue. Let's fix that first, in the easiest way, with the
> least churn, namely by using timespec64 in place of timespec. Once
> that is done, we can change over to ktime_t, if and when the need
> arises.
Ok, fair enough. I only saw this mail now after replying on the
longer series, consider my comment on ktime_t withdrawn.
Arnd
next prev parent reply other threads:[~2015-03-22 2:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 5:45 [PATCH 0/4] Introduce another options to set/get time with "ktime_t" type Baolin Wang
2015-03-19 5:45 ` [PATCH 1/4] ptp/chardev:Introduce another option to get/set time in ptp_clock_info structure Baolin Wang
2015-03-19 7:48 ` Richard Cochran
2015-03-19 5:45 ` [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type Baolin Wang
2015-03-19 7:54 ` Richard Cochran
[not found] ` <CAMz4kuKyDFCqd-LfoSKJf+tkXdzzLwtPJdp-nF6NbKU8W5HHpQ@mail.gmail.com>
2015-03-20 6:26 ` Richard Cochran
2015-03-20 13:43 ` Arnd Bergmann
2015-03-20 16:49 ` Richard Cochran
2015-03-21 1:16 ` Arnd Bergmann
2015-03-21 7:24 ` Richard Cochran
2015-03-21 16:52 ` Richard Cochran
2015-03-22 2:47 ` Arnd Bergmann [this message]
2015-03-21 9:21 ` Richard Cochran
2015-03-19 5:45 ` [PATCH 3/4] ptp/pch:Replace timespec with ktime_t in ptp_pch.c Baolin Wang
2015-03-19 5:45 ` [PATCH 4/4] ptp/ixp46x:Replace timespec with ktime_t in ptp_ixp46x.c Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503220347.06550.arnd@linaro.org \
--to=arnd@linaro.org \
--cc=baolin.wang@linaro.org \
--cc=john.stultz@linaro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.