From: Guenter Roeck <linux@roeck-us.net>
To: Cedric Le Goater <clg@fr.ibm.com>
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
lm-sensors@lm-sensors.org,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
skiboot@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH v2 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype
Date: Fri, 20 Mar 2015 08:27:02 -0700 [thread overview]
Message-ID: <20150320152702.GB10749@roeck-us.net> (raw)
In-Reply-To: <550BD50E.2040009@fr.ibm.com>
On Fri, Mar 20, 2015 at 09:06:38AM +0100, Cedric Le Goater wrote:
> [ ... ]
>
>
> > @@ -265,10 +261,17 @@ static int create_device_attrs(struct pl
> >
> > sdata[count].id = sensor_id;
> > sdata[count].type = type;
> > - err = create_hwmon_attr_name(&pdev->dev, type, np->name,
> > - sdata[count].name);
> > - if (err)
> > +
> > + attr_name = parse_opal_node_name(np->name, type, &opal_index);
> > + if (IS_ERR(attr_name)) {
> > + dev_err(&pdev->dev, "Sensor device node name '%s' is invalid\n",
> > + np->name);
> > + err = IS_ERR(attr_name);
> ^^^^^^
>
> Arg. Bad copy/paste. This should be PTR_ERR() ...
>
> Do you want a full patchset resend or just a resend of this patch ? or a fix maybe.
>
No need to resend; I fixed it up.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Cedric Le Goater <clg@fr.ibm.com>
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
lm-sensors@lm-sensors.org,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
skiboot@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [lm-sensors] [PATCH v2 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype
Date: Fri, 20 Mar 2015 15:27:02 +0000 [thread overview]
Message-ID: <20150320152702.GB10749@roeck-us.net> (raw)
In-Reply-To: <550BD50E.2040009@fr.ibm.com>
On Fri, Mar 20, 2015 at 09:06:38AM +0100, Cedric Le Goater wrote:
> [ ... ]
>
>
> > @@ -265,10 +261,17 @@ static int create_device_attrs(struct pl
> >
> > sdata[count].id = sensor_id;
> > sdata[count].type = type;
> > - err = create_hwmon_attr_name(&pdev->dev, type, np->name,
> > - sdata[count].name);
> > - if (err)
> > +
> > + attr_name = parse_opal_node_name(np->name, type, &opal_index);
> > + if (IS_ERR(attr_name)) {
> > + dev_err(&pdev->dev, "Sensor device node name '%s' is invalid\n",
> > + np->name);
> > + err = IS_ERR(attr_name);
> ^^^^^^
>
> Arg. Bad copy/paste. This should be PTR_ERR() ...
>
> Do you want a full patchset resend or just a resend of this patch ? or a fix maybe.
>
No need to resend; I fixed it up.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2015-03-20 15:28 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1423117857-32759-1-git-send-email-clg@fr.ibm.com>
2015-02-20 15:07 ` [RFC PATCH 0/3] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-02-20 15:07 ` [lm-sensors] " Cédric Le Goater
2015-02-20 16:52 ` Guenter Roeck
2015-02-20 16:52 ` [lm-sensors] " Guenter Roeck
2015-02-20 20:15 ` Cedric Le Goater
2015-02-20 20:15 ` [lm-sensors] " Cedric Le Goater
2015-02-20 23:52 ` Guenter Roeck
2015-02-20 23:52 ` [lm-sensors] " Guenter Roeck
2015-02-21 7:14 ` Cedric Le Goater
2015-02-21 7:14 ` [lm-sensors] " Cedric Le Goater
2015-02-21 11:03 ` Guenter Roeck
2015-02-21 11:03 ` [lm-sensors] " Guenter Roeck
2015-02-23 10:54 ` Cedric Le Goater
2015-02-23 10:54 ` [lm-sensors] " Cedric Le Goater
2015-02-20 15:07 ` [RFC PATCH 1/3] powerpc/powernv: Check OPAL sensor calls exist Cédric Le Goater
2015-02-20 15:07 ` [lm-sensors] " Cédric Le Goater
2015-02-20 16:53 ` Guenter Roeck
2015-02-20 16:53 ` [lm-sensors] " Guenter Roeck
2015-02-20 20:18 ` Cedric Le Goater
2015-02-20 20:18 ` [lm-sensors] " Cedric Le Goater
2015-02-24 4:54 ` Michael Ellerman
2015-02-24 4:54 ` [lm-sensors] " Michael Ellerman
2015-02-25 17:28 ` Cedric Le Goater
2015-02-25 17:28 ` [lm-sensors] " Cedric Le Goater
2015-02-20 15:07 ` [RFC PATCH 2/3] powerpc/powernv: handle OPAL_SUCCESS return in opal_sensor_read Cédric Le Goater
2015-02-20 15:07 ` [lm-sensors] " Cédric Le Goater
2015-02-20 15:07 ` [RFC PATCH 3/3] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-02-20 15:07 ` [lm-sensors] " Cédric Le Goater
2015-03-18 15:47 ` [PATCH 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] " Cédric Le Goater
2015-03-19 4:05 ` Guenter Roeck
2015-03-19 4:05 ` [lm-sensors] " Guenter Roeck
2015-03-18 15:47 ` [PATCH 1/5] hwmon: (ibmpowernv) replace AMBIENT_TEMP by TEMP Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] " Cédric Le Goater
2015-03-18 15:47 ` [PATCH 2/5] hwmon: (ibmpowernv) add a get_sensor_type() routine Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] " Cédric Le Goater
2015-03-18 15:47 ` [PATCH 3/5] hwmon: (ibmpowernv) add a convert_opal_attr_name() routine Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] " Cédric Le Goater
2015-03-19 3:58 ` Guenter Roeck
2015-03-19 3:58 ` [lm-sensors] " Guenter Roeck
2015-03-18 15:47 ` [PATCH 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] " Cédric Le Goater
2015-03-19 4:02 ` Guenter Roeck
2015-03-19 4:02 ` [lm-sensors] " Guenter Roeck
2015-03-18 15:47 ` [PATCH 5/5] hwmon: (ibmpowernv) do not use the OPAL index for hwmon attribute names Cédric Le Goater
2015-03-18 15:47 ` [lm-sensors] " Cédric Le Goater
2015-03-19 17:44 ` [PATCH v2 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] " Cédric Le Goater
2015-03-20 15:26 ` Guenter Roeck
2015-03-20 15:26 ` [lm-sensors] " Guenter Roeck
2015-03-20 16:52 ` Cedric Le Goater
2015-03-20 16:52 ` [lm-sensors] " Cedric Le Goater
2015-04-01 10:15 ` [PATCH 0/4] hwmon: (ibmpowernv) add DTS support Cédric Le Goater
2015-04-01 10:15 ` [lm-sensors] " Cédric Le Goater
2015-04-01 10:15 ` [PATCH 1/4] hwmon: (ibmpowernv) add a helper routine create_hwmon_attr Cédric Le Goater
2015-04-01 10:15 ` [lm-sensors] " Cédric Le Goater
2015-04-01 10:15 ` [PATCH 2/4] hwmon: (ibmpowernv) add support for the new device tree Cédric Le Goater
2015-04-01 10:15 ` [lm-sensors] " Cédric Le Goater
2015-04-01 10:15 ` [PATCH 3/4] hwmon: (ibmpowernv) add a label attribute Cédric Le Goater
2015-04-01 10:15 ` [lm-sensors] " Cédric Le Goater
2015-04-01 10:15 ` [PATCH 4/4] hwmon: (ibmpowernv) pretty print labels Cédric Le Goater
2015-04-01 10:15 ` [lm-sensors] " Cédric Le Goater
2015-04-03 15:49 ` Guenter Roeck
2015-04-03 15:49 ` [lm-sensors] " Guenter Roeck
2015-04-07 14:42 ` Cedric Le Goater
2015-04-07 14:42 ` [lm-sensors] " Cedric Le Goater
2015-04-07 14:45 ` Cédric Le Goater
2015-04-07 14:45 ` [lm-sensors] " Cédric Le Goater
2015-04-07 16:44 ` Guenter Roeck
2015-04-07 16:44 ` [lm-sensors] " Guenter Roeck
2015-04-07 18:03 ` Cedric Le Goater
2015-04-07 18:03 ` [lm-sensors] " Cedric Le Goater
2015-04-07 19:22 ` Guenter Roeck
2015-04-07 19:22 ` [lm-sensors] " Guenter Roeck
2015-04-08 6:57 ` Cedric Le Goater
2015-04-08 6:57 ` [lm-sensors] " Cedric Le Goater
2015-04-07 20:22 ` [Skiboot] " Benjamin Herrenschmidt
2015-04-07 20:22 ` [lm-sensors] " Benjamin Herrenschmidt
2015-03-19 17:44 ` [PATCH v2 1/5] hwmon: (ibmpowernv) replace AMBIENT_TEMP by TEMP Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] " Cédric Le Goater
2015-03-19 17:44 ` [PATCH v2 2/5] hwmon: (ibmpowernv) add a get_sensor_type() routine Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] " Cédric Le Goater
2015-03-19 17:44 ` [PATCH v2 3/5] hwmon: (ibmpowernv) add a convert_opal_attr_name() routine Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] " Cédric Le Goater
2015-03-19 17:44 ` [PATCH v2 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] " Cédric Le Goater
2015-03-20 8:06 ` Cedric Le Goater
2015-03-20 8:06 ` [lm-sensors] " Cedric Le Goater
2015-03-20 15:27 ` Guenter Roeck [this message]
2015-03-20 15:27 ` Guenter Roeck
2015-03-19 17:44 ` [PATCH v2 5/5] hwmon: (ibmpowernv) do not use the OPAL index for hwmon attribute names Cédric Le Goater
2015-03-19 17:44 ` [lm-sensors] " Cédric Le Goater
2015-04-08 15:20 [PATCH 2/4] hwmon: (ibmpowernv) add support for the new device tree Guenter Roeck
2015-04-08 15:20 ` [lm-sensors] " Guenter Roeck
2015-04-08 16:06 ` Cedric Le Goater
2015-04-08 16:06 ` [lm-sensors] " Cedric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320152702.GB10749@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clg@fr.ibm.com \
--cc=jdelvare@suse.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lm-sensors@lm-sensors.org \
--cc=neelegup@linux.vnet.ibm.com \
--cc=skiboot@lists.ozlabs.org \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.