Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

From: Arnd Bergmann <arnd@linaro.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Amir Vadai" <amirv@mellanox.com>,
	"Ariel Elior" <ariel.elior@qlogic.com>,
	"Baolin Wang" <baolin.wang@linaro.org>,
	"Ben Hutchings" <ben@decadent.org.uk>,
	"Bruce Allan" <bruce.w.allan@intel.com>,
	"Carolyn Wyborny" <carolyn.wyborny@intel.com>,
	"Chris Metcalf" <cmetcalf@ezchip.com>,
	"David Miller" <davem@davemloft.net>,
	"Frank Li" <Frank.Li@freescale.com>,
	"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
	"Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
	"John Stultz" <john.stultz@linaro.org>,
	"Luwei Zhou" <b45643@freescale.com>,
	"Matthew Vick" <matthew.vick@intel.com>,
	"Michael Chan" <mchan@broadcom.com>,
	"Prashant Sreedharan" <prashant@broadcom.com>,
	"Shradha Shah" <sshah@solarflare.com>,
	"Solarflare linux maintainers" <linux-net-drivers@solarflare.com>,
	"Sonic Zhang" <sonic.zhang@analog.com>,
	"Stefan Sørensen" <stefan.sorensen@spectralink.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Tom Lendacky" <thomas.lendacky@amd.com>
Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.
Date: Sun, 22 Mar 2015 18:48:02 +0100	[thread overview]
Message-ID: <201503221848.02226.arnd@linaro.org> (raw)
In-Reply-To: <20150322072935.GB4254@localhost.localdomain>

On Sunday 22 March 2015, Richard Cochran wrote:
> On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote:
> > On Saturday 21 March 2015, Richard Cochran wrote:
> > >         mutex_lock(&clock->extreg_lock);
> > >  
> > > -       err = tdr_write(1, phydev, ts, PTP_LOAD_CLK);
> > > +       err = tdr_write(1, phydev, &ts, PTP_LOAD_CLK);
> > >  
> > >         mutex_unlock(&clock->extreg_lock);
> > 
> > I don't see the change to the tdr_write() function that changes the 
> > argument from 'struct timespec ts' to 'struct timespec64 *', so this
> > looks wrong to me.
> 
> There is a 'ts64' parameter, converted to 'ts' beforehand.
> 

Ok, got it. The code looks correct then, though I'd like to see the use
of 'timespec' pushed out as far as possible. How about changing the
type for tdr_write() as well here?

tdr_write() itself should be fine until 2106, as it writes an unsigned number,
but it's probably good to document that inside of that function.

	Arnd