From: Chris Metcalf <cmetcalf@ezchip.com> To: Richard Cochran <richardcochran@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Amir Vadai" <amirv@mellanox.com>, "Ariel Elior" <ariel.elior@qlogic.com>, "Arnd Bergmann" <arnd@linaro.org>, "Baolin Wang" <baolin.wang@linaro.org>, "Ben Hutchings" <ben@decadent.org.uk>, "Bruce Allan" <bruce.w.allan@intel.com>, "Carolyn Wyborny" <carolyn.wyborny@intel.com>, "David Miller" <davem@davemloft.net>, "Frank Li" <Frank.Li@freescale.com>, "Giuseppe Cavallaro" <peppe.cavallaro@st.com>, "Jeff Kirsher" <jeffrey.t.kirsher@intel.com>, "John Stultz" <john.stultz@linaro.org>, "Luwei Zhou" <b45643@freescale.com>, "Matthew Vick" <matthew.vick@intel.com>, "Michael Chan" <mchan@broadcom.com>, "Prashant Sreedharan" <prashant@broadcom.com>, "Shradha Shah" <sshah@solarflare.com>, "Solarflare linux maintainers" <linux-net-drivers@solarflare.com>, "Sonic Zhang" <sonic.zhang@analog.com>, "Stefan Sørensen" <stefan.sorensen@spectralink.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Tom Lendacky" <thomas.lendacky@amd.com> Subject: Re: [PATCH net-next V2 19/23] ptp: tilegx: convert to the 64 bit get/set time methods. Date: Mon, 23 Mar 2015 13:26:22 -0400 [thread overview] Message-ID: <55104CBE.90603@ezchip.com> (raw) In-Reply-To: <20150323165839.GA4330@localhost.localdomain> On 03/23/2015 12:58 PM, Richard Cochran wrote: > On Mon, Mar 23, 2015 at 12:02:03PM -0400, Chris Metcalf wrote: >> >This driver is 64-bit only. Would it make more sense to just change >> >the accessors from gettime/settime to gettime/settime64 and nothing >> >else, i.e. rely on the current behavior that timespec and timespec64 >> >are the same type, and trust the compiler to fail it if somehow someone >> >tried to build this driver into a 32-bit kernel? > On the one hand, I think the best way would be for > gxio_mpipe_get/set_timestamp to also take a timespec64, because it > makes the width clear. With a plain old timespec, you have to > remember whether you are 64 bit or not. However, but I couldn't tell > if changing gxio_mpipe_get/set_timestamp would work for other callers > or not. If you're suggesting changing the gxio_mpipe_xxx_timespec routines to take a timespec64, that sounds reasonable to me, particularly in conjunction with your new gettime64 etc API. As far as I know, the tilegx driver is the only client of those gxio routines. > If the driver is 64 bit only, shouldn't that be reflected in the > Kconfig? Well, the tilegx driver is only supported for the tilegx architecture, which is only 64-bit for kernel-space. It may be a bit confusing because the actual driver is tile_net, which has separate implementations for tilegx (64-bit) and tilepro (32-bit). It's not immediately clear how to make that more obvious. > On the other hand, I wouldn't mind the change you suggest, if it were > super obvious that the code is 64 bit only. It was not obvious to me. I guess that brings us back to changing the gxio_xxx APIs. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com
WARNING: multiple messages have this Message-ID (diff)
From: Chris Metcalf <cmetcalf@ezchip.com> To: Richard Cochran <richardcochran@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Amir Vadai" <amirv@mellanox.com>, "Ariel Elior" <ariel.elior@qlogic.com>, "Arnd Bergmann" <arnd@linaro.org>, "Baolin Wang" <baolin.wang@linaro.org>, "Ben Hutchings" <ben@decadent.org.uk>, "Bruce Allan" <bruce.w.allan@intel.com>, "Carolyn Wyborny" <carolyn.wyborny@intel.com>, "David Miller" <davem@davemloft.net>, "Frank Li" <Frank.Li@freescale.com>, "Giuseppe Cavallaro" <peppe.cavallaro@st.com>, "Jeff Kirsher" <jeffrey.t.kirsher@intel.com>, "John Stultz" <john.stultz@linaro.org>, "Luwei Zhou" <b45643@freescale.com>, "Matthew Vick" <matthew.vick@intel.com>, "Michael Chan" <mchan@broadcom.com>, "Prashant Sreedharan" <prashant@broadcom.com>, "Shradha Shah" <sshah@solarflare.com>, "Solarflare linux maintainers" <linux-net-drivers@solarflare.com>, "Sonic Zhang" <sonic.zhang@analog.com>, "Stefan Sørensen" <stefan.sorensen@spectra> Subject: Re: [PATCH net-next V2 19/23] ptp: tilegx: convert to the 64 bit get/set time methods. Date: Mon, 23 Mar 2015 13:26:22 -0400 [thread overview] Message-ID: <55104CBE.90603@ezchip.com> (raw) In-Reply-To: <20150323165839.GA4330@localhost.localdomain> On 03/23/2015 12:58 PM, Richard Cochran wrote: > On Mon, Mar 23, 2015 at 12:02:03PM -0400, Chris Metcalf wrote: >> >This driver is 64-bit only. Would it make more sense to just change >> >the accessors from gettime/settime to gettime/settime64 and nothing >> >else, i.e. rely on the current behavior that timespec and timespec64 >> >are the same type, and trust the compiler to fail it if somehow someone >> >tried to build this driver into a 32-bit kernel? > On the one hand, I think the best way would be for > gxio_mpipe_get/set_timestamp to also take a timespec64, because it > makes the width clear. With a plain old timespec, you have to > remember whether you are 64 bit or not. However, but I couldn't tell > if changing gxio_mpipe_get/set_timestamp would work for other callers > or not. If you're suggesting changing the gxio_mpipe_xxx_timespec routines to take a timespec64, that sounds reasonable to me, particularly in conjunction with your new gettime64 etc API. As far as I know, the tilegx driver is the only client of those gxio routines. > If the driver is 64 bit only, shouldn't that be reflected in the > Kconfig? Well, the tilegx driver is only supported for the tilegx architecture, which is only 64-bit for kernel-space. It may be a bit confusing because the actual driver is tile_net, which has separate implementations for tilegx (64-bit) and tilepro (32-bit). It's not immediately clear how to make that more obvious. > On the other hand, I wouldn't mind the change you suggest, if it were > super obvious that the code is 64 bit only. It was not obvious to me. I guess that brings us back to changing the gxio_xxx APIs. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com
next prev parent reply other threads:[~2015-03-23 17:26 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-21 21:39 [PATCH net-next V2 00/23] ptp: get ready for 2038 Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 01/23] ptp: introduce get/set time methods with explicit 64 bit seconds Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 02/23] ptp: use the 64 bit gettime method for the SYS_OFFSET ioctl Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 03/23] ptp: use the 64 bit get/set time methods for the posix clock Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 04/23] ptp: blackfin: convert to the 64 bit get/set time methods Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-22 2:28 ` Arnd Bergmann 2015-03-22 2:28 ` Arnd Bergmann 2015-03-22 7:27 ` Richard Cochran 2015-03-22 7:27 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 05/23] ptp: xgbe: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 06/23] ptp: bnx2x: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 07/23] ptp: tg3: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 08/23] ptp: fec: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 09/23] ptp: gianfar: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 10/23] ptp: e1000e: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 11/23] ptp: fm10k: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 12/23] ptp: i40e: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 13/23] ptp: igb: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-22 2:40 ` Arnd Bergmann 2015-03-22 2:40 ` Arnd Bergmann 2015-03-21 21:39 ` [PATCH net-next V2 14/23] ptp: ixgbe: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 15/23] ptp: mlx4: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 16/23] ptp: sfc: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 17/23] ptp: stmmac: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-23 15:35 ` Giuseppe CAVALLARO 2015-03-23 15:35 ` Giuseppe CAVALLARO 2015-03-31 13:22 ` Rayagond Kokatanur 2015-03-31 13:22 ` Rayagond Kokatanur 2015-03-21 21:39 ` [PATCH net-next V2 18/23] ptp: cpts: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 19/23] ptp: tilegx: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-23 16:02 ` Chris Metcalf 2015-03-23 16:02 ` Chris Metcalf 2015-03-23 16:58 ` Richard Cochran 2015-03-23 16:58 ` Richard Cochran 2015-03-23 17:26 ` Chris Metcalf [this message] 2015-03-23 17:26 ` Chris Metcalf 2015-03-23 20:06 ` Richard Cochran 2015-03-23 20:06 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 20/23] ptp: dp83640: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-22 2:36 ` Arnd Bergmann 2015-03-22 2:36 ` Arnd Bergmann 2015-03-22 7:29 ` Richard Cochran 2015-03-22 7:29 ` Richard Cochran 2015-03-22 17:48 ` Arnd Bergmann 2015-03-22 17:48 ` Arnd Bergmann 2015-03-23 8:10 ` Richard Cochran 2015-03-23 8:10 ` Richard Cochran 2015-03-23 15:06 ` Arnd Bergmann 2015-03-23 15:06 ` Arnd Bergmann 2015-03-21 21:39 ` [PATCH net-next V2 21/23] ptp: ixp46x: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 22/23] ptp: pch: " Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-21 21:39 ` [PATCH net-next V2 23/23] ptp: remove 32 bit get/set methods Richard Cochran 2015-03-21 21:39 ` Richard Cochran 2015-03-22 2:43 ` [PATCH net-next V2 00/23] ptp: get ready for 2038 Arnd Bergmann 2015-03-22 2:43 ` Arnd Bergmann 2015-03-23 10:16 ` Jeff Kirsher 2015-03-23 10:16 ` Jeff Kirsher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55104CBE.90603@ezchip.com \ --to=cmetcalf@ezchip.com \ --cc=Frank.Li@freescale.com \ --cc=amirv@mellanox.com \ --cc=ariel.elior@qlogic.com \ --cc=arnd@linaro.org \ --cc=b45643@freescale.com \ --cc=baolin.wang@linaro.org \ --cc=ben@decadent.org.uk \ --cc=bruce.w.allan@intel.com \ --cc=carolyn.wyborny@intel.com \ --cc=davem@davemloft.net \ --cc=jeffrey.t.kirsher@intel.com \ --cc=john.stultz@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-net-drivers@solarflare.com \ --cc=matthew.vick@intel.com \ --cc=mchan@broadcom.com \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ --cc=prashant@broadcom.com \ --cc=richardcochran@gmail.com \ --cc=sonic.zhang@analog.com \ --cc=sshah@solarflare.com \ --cc=stefan.sorensen@spectralink.com \ --cc=tglx@linutronix.de \ --cc=thomas.lendacky@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.