[PATCH net-next] bonding: Remove hardcoded initialization

[PATCH net-next] bonding: Remove hardcoded initialization

[Mahesh Bandewar]

Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
 drivers/net/bonding/bond_3ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 3cce25818b57..48f3bd7e2350 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -1776,7 +1776,7 @@ static void ad_initialize_port(struct port *port, int lacp_fast)
 
 		port->is_enabled = true;
 		/* private parameters */
-		port->sm_vars = 0x3;
+		port->sm_vars = AD_PORT_BEGIN | AD_PORT_LACP_ENABLED;
 		port->sm_rx_state = 0;
 		port->sm_rx_timer_counter = 0;
 		port->sm_periodic_state = 0;
-- 
2.2.0.rc0.207.ga3a616c

Re: [PATCH net-next] bonding: Remove hardcoded initialization

[Andy Gospodarek]

On Fri, Mar 27, 2015 at 10:34:31PM -0700, Mahesh Bandewar wrote:
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>

I realize that the changelog would be identical to the title, so
probably not critical here, but please add one whenever possible.

Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>

> ---
>  drivers/net/bonding/bond_3ad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> index 3cce25818b57..48f3bd7e2350 100644
> --- a/drivers/net/bonding/bond_3ad.c
> +++ b/drivers/net/bonding/bond_3ad.c
> @@ -1776,7 +1776,7 @@ static void ad_initialize_port(struct port *port, int lacp_fast)
>  
>  		port->is_enabled = true;
>  		/* private parameters */
> -		port->sm_vars = 0x3;
> +		port->sm_vars = AD_PORT_BEGIN | AD_PORT_LACP_ENABLED;
>  		port->sm_rx_state = 0;
>  		port->sm_rx_timer_counter = 0;
>  		port->sm_periodic_state = 0;
> -- 
> 2.2.0.rc0.207.ga3a616c
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next] bonding: Remove hardcoded initialization

[Cong Wang]

On Mon, Mar 30, 2015 at 7:25 AM, Andy Gospodarek
<gospo@cumulusnetworks.com> wrote:
> On Fri, Mar 27, 2015 at 10:34:31PM -0700, Mahesh Bandewar wrote:
>> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
>
> I realize that the changelog would be identical to the title, so
> probably not critical here, but please add one whenever possible.
>

Email subject is already a part of changelog, no need to duplicate it.

Re: [PATCH net-next] bonding: Remove hardcoded initialization

[David Miller]

From: Mahesh Bandewar <maheshb@google.com>
Date: Fri, 27 Mar 2015 22:34:31 -0700

> Signed-off-by: Mahesh Bandewar <maheshb@google.com>

Applied, thanks.