* [PATCH net-next] bonding: Remove hardcoded initialization
@ 2015-03-28 5:34 Mahesh Bandewar
2015-03-30 14:25 ` Andy Gospodarek
2015-03-31 17:26 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Mahesh Bandewar @ 2015-03-28 5:34 UTC (permalink / raw)
To: Jay Vosburgh, Andy Gospodarek, Veaceslav Falico,
Nikolay Aleksandrov, David Miller
Cc: Mahesh Bandewar, Maciej Zenczykowski, netdev, Eric Dumazet
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
drivers/net/bonding/bond_3ad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 3cce25818b57..48f3bd7e2350 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -1776,7 +1776,7 @@ static void ad_initialize_port(struct port *port, int lacp_fast)
port->is_enabled = true;
/* private parameters */
- port->sm_vars = 0x3;
+ port->sm_vars = AD_PORT_BEGIN | AD_PORT_LACP_ENABLED;
port->sm_rx_state = 0;
port->sm_rx_timer_counter = 0;
port->sm_periodic_state = 0;
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bonding: Remove hardcoded initialization
2015-03-28 5:34 [PATCH net-next] bonding: Remove hardcoded initialization Mahesh Bandewar
@ 2015-03-30 14:25 ` Andy Gospodarek
2015-03-30 17:07 ` Cong Wang
2015-03-31 17:26 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Andy Gospodarek @ 2015-03-30 14:25 UTC (permalink / raw)
To: Mahesh Bandewar
Cc: Jay Vosburgh, Andy Gospodarek, Veaceslav Falico,
Nikolay Aleksandrov, David Miller, Maciej Zenczykowski, netdev,
Eric Dumazet
On Fri, Mar 27, 2015 at 10:34:31PM -0700, Mahesh Bandewar wrote:
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
I realize that the changelog would be identical to the title, so
probably not critical here, but please add one whenever possible.
Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
> ---
> drivers/net/bonding/bond_3ad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> index 3cce25818b57..48f3bd7e2350 100644
> --- a/drivers/net/bonding/bond_3ad.c
> +++ b/drivers/net/bonding/bond_3ad.c
> @@ -1776,7 +1776,7 @@ static void ad_initialize_port(struct port *port, int lacp_fast)
>
> port->is_enabled = true;
> /* private parameters */
> - port->sm_vars = 0x3;
> + port->sm_vars = AD_PORT_BEGIN | AD_PORT_LACP_ENABLED;
> port->sm_rx_state = 0;
> port->sm_rx_timer_counter = 0;
> port->sm_periodic_state = 0;
> --
> 2.2.0.rc0.207.ga3a616c
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bonding: Remove hardcoded initialization
2015-03-30 14:25 ` Andy Gospodarek
@ 2015-03-30 17:07 ` Cong Wang
0 siblings, 0 replies; 4+ messages in thread
From: Cong Wang @ 2015-03-30 17:07 UTC (permalink / raw)
To: Andy Gospodarek
Cc: Mahesh Bandewar, Jay Vosburgh, Andy Gospodarek, Veaceslav Falico,
Nikolay Aleksandrov, David Miller, Maciej Zenczykowski, netdev,
Eric Dumazet
On Mon, Mar 30, 2015 at 7:25 AM, Andy Gospodarek
<gospo@cumulusnetworks.com> wrote:
> On Fri, Mar 27, 2015 at 10:34:31PM -0700, Mahesh Bandewar wrote:
>> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
>
> I realize that the changelog would be identical to the title, so
> probably not critical here, but please add one whenever possible.
>
Email subject is already a part of changelog, no need to duplicate it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bonding: Remove hardcoded initialization
2015-03-28 5:34 [PATCH net-next] bonding: Remove hardcoded initialization Mahesh Bandewar
2015-03-30 14:25 ` Andy Gospodarek
@ 2015-03-31 17:26 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2015-03-31 17:26 UTC (permalink / raw)
To: maheshb; +Cc: j.vosburgh, andy, vfalico, nikolay, maze, netdev, edumazet
From: Mahesh Bandewar <maheshb@google.com>
Date: Fri, 27 Mar 2015 22:34:31 -0700
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-31 17:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-28 5:34 [PATCH net-next] bonding: Remove hardcoded initialization Mahesh Bandewar
2015-03-30 14:25 ` Andy Gospodarek
2015-03-30 17:07 ` Cong Wang
2015-03-31 17:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.